Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Usage Of npro In Favor Of Just numpyro #316

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

There is, in some instances, the use of import numpyro as npro. This has not been a uniform behavior though, despite this syntax being more preferable to MSR developers than import numpyro. This PR changes all instances of import numpyro to import numpyro as npro and modifies the code correspondingly.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the 🦆 Olorotitan milestone Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (4ea2e4b) to head (4777b58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         904      904           
=======================================
  Hits          839      839           
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @AFg6K7h4fhy2! Unfortunately, the current PR does the exact opposite of what I was hoping for. I would like to standardize on import numpyro.

@AFg6K7h4fhy2
Copy link
Collaborator Author

Thanks for working on this, @AFg6K7h4fhy2! Unfortunately, the current PR does the exact opposite of what I was hoping for. I would like to standardize on import numpyro.

Oof. That's kind of funny. My apologies, I do not know how I misread the issue title. I will fix once I finish up some more on #300

@AFg6K7h4fhy2
Copy link
Collaborator Author

@damonbayer Changes have been made appropriately.

@dylanhmorris
Copy link
Collaborator

@AFg6K7h4fhy2 can you merge in main now that #317 has landed? Will review once that's done.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AFg6K7h4fhy2!

@damonbayer damonbayer self-requested a review July 25, 2024 14:41
@AFg6K7h4fhy2 AFg6K7h4fhy2 merged commit ddb45cd into main Jul 25, 2024
8 checks passed
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting my previous review. See @dylanhmorris's comment regarding #317. #316 (comment)

@AFg6K7h4fhy2 AFg6K7h4fhy2 deleted the 309-replace-all-instances-of-npro-with-numpyro branch July 25, 2024 14:44
@AFg6K7h4fhy2 AFg6K7h4fhy2 restored the 309-replace-all-instances-of-npro-with-numpyro branch July 25, 2024 14:44
damonbayer added a commit that referenced this pull request Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 changed the title Change Certain numpyros To npro Remove Usage Of npro In Favor Of Just numpyro Jul 25, 2024
@dylanhmorris dylanhmorris deleted the 309-replace-all-instances-of-npro-with-numpyro branch July 30, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all instances of npro with numpyro
3 participants