Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change Certain numpyros To npro" #318

Conversation

damonbayer
Copy link
Collaborator

Reverts #316

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ddb45cd) to head (0a3113f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #318      +/-   ##
===========================================
+ Coverage   92.80%   100.00%   +7.19%     
===========================================
  Files          39         2      -37     
  Lines         904         7     -897     
===========================================
- Hits          839         7     -832     
+ Misses         65         0      -65     
Flag Coverage Δ
unittests 100.00% <ø> (+7.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer closed this Jul 25, 2024
@dylanhmorris
Copy link
Collaborator

dylanhmorris commented Jul 25, 2024

I have examined the diffs for the landed commit, and I don't think it actually undid any of #317. I think it simply revealed that #317 didn't catch all cases. I think we can close this but should open a new issue/PR to fix the remaining cases of numpyro.handlers.seed calling np.random.randint @damonbayer @AFg6K7h4fhy2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants