Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/async grb v2 #2995

Draft
wants to merge 137 commits into
base: main
Choose a base branch
from
Draft

Feature/async grb v2 #2995

wants to merge 137 commits into from

Conversation

StevenWadeOddball
Copy link
Contributor

EASI-0000

Description

How to test this change

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

adamodd and others added 30 commits December 18, 2024 11:34
* add presentation links schema

* move column declarations

* add presentation links model and stub URL/status resolvers, remove bucket name

* add mutation/query to postman
* email template

* create template support code

* add to tests

* use acronym

* Update pkg/email/templates/grb_review_presentation_links_updated.gohtml

Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com>

* remove extra <br>

* updates to system_intake_admin_upload_doc.gohtml

* fix oops

* fix mistaken bold

* spacing

---------

Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com>
* add sql file, sqlqueries file, storage file

* add to schema/resolvers

* err when row not found

* whoops

* add some form of a test
* working on dataloaders + storage

* app code should be done, working on tests

* remove mock code

* add quick test to be expanded on later

* remove todos
* Form component and route

* Basic form fields

* Presentation links mutation

* Update fields type to match mutation

* Form submit

* Transcript fields tabs

* Update allowed file types

* Fix field bugs

* Field validation

* Edit form default values

* FileInput component with defaultFileName prop

* Disable form if no fields changed

* Basic unit tests

* Basic unit tests

* Tab field updates

* Fix routes

* Update props

* Prop typo fix

* Update file field values to base64

* Bug fixes

* Fix TS error

* Update variable name

* FileInput unit test

* Fix disabled submit button on edit

- Submit button was disabled on edit if presentation deck file was previously uploaded, and a different field was updated
- Updated form to set default values for file upload fields

* Fix transcript fields default tab

* Fix mobile view grid layout
* (no verify) checking somethign

* fix lint

* working on status calculating resolvers

* cleanup whitespace

* add standard as default to tests

* bump snaps

* whoops - remove leftover code

* filled in other test cases with defaults

* add in status i missed earlier!

* naming

* swap complete for ready

* use "Ready" status

* add test

* use proper date when checking for in progress

* clean up params

* adding tests

* adding more tests

* add some more tests

---------

Co-authored-by: Steven Wade <99294987+StevenWadeOddball@users.noreply.github.com>
* add more task status copy translation

* Add conditional alert render

* update copy

* update conditnioalrenders

* moved upload button under the conditional

* add grbReviewType, grbReviewStartedAt, grbReviewAsyncEndDate to query'

* add reviewTypes

* conditional rendering the butotn

* add a few more things to the query

* add one more to the query

* datemapping to conditional render the date

* add a few mroe dates

* updating snaps

* update test and mocks

* updated test to match that there is two review types now

* addressing tests

* used grbDate instead of what is being used there

* remove unused query

* adjusting the dates to the right values

* remove unused props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants