Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zombienet): add zombienet testing to github workflow #3172

Closed
wants to merge 12 commits into from

Conversation

edwardmack
Copy link
Contributor

@edwardmack edwardmack commented Mar 23, 2023

Changes

This PR adds configuration and test files to add Zombienet testing to github workflow to trigger Zombienet tests on pull requests.

Tests

Create pull request to trigger workflow action, then review results of workflow to confirm zombienet has executed tests.

Issues

closes: #2842
closes: #2843
closes: #2998

Primary Reviewer

@timwu20

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3172 (da671f8) into development (7c08365) will increase coverage by 0.02%.
The diff coverage is 60.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3172      +/-   ##
===============================================
+ Coverage        51.45%   51.47%   +0.02%     
===============================================
  Files              221      221              
  Lines            28281    28284       +3     
===============================================
+ Hits             14551    14559       +8     
+ Misses           12410    12407       -3     
+ Partials          1320     1318       -2     

@edwardmack edwardmack force-pushed the ed/add_zombienet_testing branch from 1167c47 to 6dcba03 Compare March 24, 2023 13:24
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@edwardmack edwardmack force-pushed the ed/add_zombienet_testing branch from 6dcba03 to d12e0a6 Compare March 29, 2023 14:19
.github/workflows/zombienet.yml Show resolved Hide resolved
.github/workflows/zombienet.yml Outdated Show resolved Hide resolved
.github/workflows/zombienet.yml Outdated Show resolved Hide resolved
.github/workflows/zombienet.yml Outdated Show resolved Hide resolved
.github/workflows/zombienet.yml Show resolved Hide resolved
dot/network/service.go Outdated Show resolved Hide resolved
dot/node.go Show resolved Hide resolved
dot/network/service.go Outdated Show resolved Hide resolved
dot/network/service.go Outdated Show resolved Hide resolved
@edwardmack edwardmack force-pushed the ed/add_zombienet_testing branch from a42c6c1 to e38e7e5 Compare April 3, 2023 15:16
dot/network/service.go Show resolved Hide resolved
dot/network/service.go Outdated Show resolved Hide resolved
dot/rpc/modules/state_integration_test.go Show resolved Hide resolved
@edwardmack
Copy link
Contributor Author

This PR will be replaced by PR #3192, please resolve comments, and approve that PR.

@edwardmack
Copy link
Contributor Author

Closed, this PR has been replaced by PR #3192.

@edwardmack edwardmack closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants