-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update libp2p-crypto #113
chore: update libp2p-crypto #113
Conversation
libp2p-crypto@0.20.0 uses noble-secp256k1 and noble-ed25519 which are smaller and faster than the version in https://www.npmjs.com/package/secp256k1 This PR updates the dep so we don't pull in 0.19.x and 0.20.x in consuming bundles.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 16 16
Lines 1832 1832
Branches 243 243
=======================================
Hits 1633 1633
Misses 199 199 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to benchmark and consider using native bindings for Lodestar at least
@dapplion native bindings are much, much faster 😁 , though require node 15+ - libp2p/js-libp2p-crypto#211
Actually, scratch that, I updated the libp2p-crypto PR to fall back to the pure-js implementation if Ed25519 isn't supported. |
Oh! Very interested! gossip encryption shows up in our Lodestar benchmarks. Do you have benchmarks comparing native bindings, current lib and noble's? We just bumped Lodestar to use NodeJS v16 by default so it shouldn't be an issue 👍 |
Oh! Very interested! We just bumped Lodestar to use NodeJS v16 by default so it shouldn't be an issue 👍 Damn with those benchmarks, crazy differences |
Superseded by #115 |
And/or #116 |
libp2p-crypto@0.20.0 uses noble-ed25519 and noble-secp256k1 which
is smaller and faster than the version in https://www.npmjs.com/package/secp256k1
This PR updates the dep so we don't pull in 0.19.x and 0.20.x in
consuming bundles.
Ref: libp2p/js-libp2p-crypto#202