Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make libp2p-crypto a dev dep #115

Merged

Conversation

achingbrain
Copy link
Collaborator

It's only used to verify incoming message payloads but the pubKey property on PeerId can do that.

@dapplion
Copy link
Contributor

Makes sense! Agree with the change. However should we keep both the package-lock.json and yarn.lock?

@achingbrain
Copy link
Collaborator Author

should we keep both the package-lock.json and yarn.lock?

Ha! Oops. I've removed the newly added package-lock.json file.

It's only used to verify incoming message payloads but the `pubKey`
property on `PeerId` can do that.
@achingbrain achingbrain force-pushed the chore/make-libp2p-crypto-a-dev-dep branch from 8c59466 to a48294c Compare November 30, 2021 11:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #115 (a48294c) into master (735f287) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   89.13%   89.13%   -0.01%     
==========================================
  Files          16       16              
  Lines        1832     1831       -1     
  Branches      243      243              
==========================================
- Hits         1633     1632       -1     
  Misses        199      199              
Impacted Files Coverage Δ
src/utils.ts 98.40% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735f287...a48294c. Read the comment docs.

@dapplion dapplion merged commit 07a6cd6 into ChainSafe:master Dec 1, 2021
@achingbrain achingbrain deleted the chore/make-libp2p-crypto-a-dev-dep branch December 1, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants