-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update peer-id and libp2p-crypto #116
chore: update peer-id and libp2p-crypto #116
Conversation
Updates to the latest peer-id and libp2p-crypto. No API changes, but libp2p-crypto removes some deps now that support for RSA in node core is better, though you need a modern node to use it. BREAKING CHANGE: requires node 15+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! That works well for Lodestar we are recommending running with Node v16 now
This will cause a conflict with #115 - I'm happy to resolve it when that happens but one of them needs merging first 😉 |
Merged #115 would you mind rebasing now? |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 16 16
Lines 1831 1831
Branches 243 243
=======================================
Hits 1632 1632
Misses 199 199 Continue to review full report at Codecov.
|
This is still showing ci jobs running under node 14, even though ci for this PR has completed successfully. Must be a gh actions oddity 🤷 |
Updated branch protection rules to no longer expect v14 runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Thanks for merging - any chance of a release with this in please? |
👍 PR for a new version here, release should follow after merging: #119 |
#119 was merged a few days ago but it doesn't look like this has been released yet, npm still shows the latest as 4.1.1? |
Dang, the CI failed https://github.com/ChainSafe/js-libp2p-noise/runs/4409802719?check_suite_focus=true |
Ok, 5.0.0 should be released with #120 |
Updates to the latest peer-id and libp2p-crypto.
No API changes, but libp2p-crypto removes some deps now that support for RSA in node core is better, though you need a modern node to use it.
BREAKING CHANGE: requires node 15+