Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update peer-id and libp2p-crypto #116

Merged
merged 8 commits into from
Dec 1, 2021

Conversation

achingbrain
Copy link
Collaborator

Updates to the latest peer-id and libp2p-crypto.

No API changes, but libp2p-crypto removes some deps now that support for RSA in node core is better, though you need a modern node to use it.

BREAKING CHANGE: requires node 15+

Updates to the latest peer-id and libp2p-crypto.

No API changes, but libp2p-crypto removes some deps now that support
for RSA in node core is better, though you need a modern node to
use it.

BREAKING CHANGE: requires node 15+
dapplion
dapplion previously approved these changes Dec 1, 2021
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! That works well for Lodestar we are recommending running with Node v16 now

@achingbrain
Copy link
Collaborator Author

This will cause a conflict with #115 - I'm happy to resolve it when that happens but one of them needs merging first 😉

@dapplion
Copy link
Contributor

dapplion commented Dec 1, 2021

Merged #115 would you mind rebasing now?

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #116 (202f245) into master (07a6cd6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          16       16           
  Lines        1831     1831           
  Branches      243      243           
=======================================
  Hits         1632     1632           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a6cd6...202f245. Read the comment docs.

@achingbrain
Copy link
Collaborator Author

This is still showing ci jobs running under node 14, even though ci for this PR has completed successfully. Must be a gh actions oddity 🤷

@dapplion
Copy link
Contributor

dapplion commented Dec 1, 2021

This is still showing ci jobs running under node 14, even though ci for this PR has completed successfully. Must be a gh actions oddity shrug

Updated branch protection rules to no longer expect v14 runs

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@wemeetagain wemeetagain merged commit 61251ed into ChainSafe:master Dec 1, 2021
@achingbrain achingbrain deleted the chore/update-peer-id branch December 1, 2021 18:33
@achingbrain
Copy link
Collaborator Author

Thanks for merging - any chance of a release with this in please?

@wemeetagain
Copy link
Member

👍 PR for a new version here, release should follow after merging: #119

@achingbrain
Copy link
Collaborator Author

achingbrain commented Dec 6, 2021

#119 was merged a few days ago but it doesn't look like this has been released yet, npm still shows the latest as 4.1.1?

@wemeetagain
Copy link
Member

Dang, the CI failed https://github.com/ChainSafe/js-libp2p-noise/runs/4409802719?check_suite_focus=true
I'll try to release now manually

@wemeetagain
Copy link
Member

Ok, 5.0.0 should be released with #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants