Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TOC text design in Boolean Algebra and redesigned search-bar. #322

Merged
merged 2 commits into from
May 20, 2020
Merged

Fixed TOC text design in Boolean Algebra and redesigned search-bar. #322

merged 2 commits into from
May 20, 2020

Conversation

coding-CEO
Copy link
Contributor

@coding-CEO coding-CEO commented May 19, 2020 •
edited
Loading

Fixes #321

Ref #

Before:->

2

After:->

3

Changes done:

  • Fixed text in TOC boolean algebra

✅️ By submitting this PR, I have verified the following

@coding-CEO coding-CEO mentioned this pull request May 19, 2020
Closed
@coding-CEO
Copy link
Contributor Author

Review @YashKumarVerma @Shivansh2407.

abhinavsri360
abhinavsri360 reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@abhinavsri360 abhinavsri360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if you make that 1.1, 1.2 ...... instead of a,b,c,d...

@coding-CEO
Copy link
Contributor Author

It will be better if you make that 1.1, 1.2 ...... instead of a,b,c,d...

I never touched the a,b,c,d. It is same as it was before.
because, I don't know how to change that.

@abhinavsri360
Copy link
Contributor

How did you made it in small case?

@coding-CEO
Copy link
Contributor Author

coding-CEO commented May 19, 2020 •
edited
Loading

How did you made it in small case?

You can check the changes I made in tab of "Files Changed". above.

@abhinavsri360
Copy link
Contributor

abhinavsri360 commented May 19, 2020 •
edited
Loading

Fine, in that case.

@coding-CEO coding-CEO mentioned this pull request May 19, 2020
Merged
5 tasks
@coding-CEO
Copy link
Contributor Author

https://5ec3baaa11d7650006d1404f--tender-ardinghelli-ebb79f.netlify.app/docs/bool.html

Scss changes not visible in Netlify.
You may see the search-bar unchanged.

@YashKumarVerma
Copy link
Member

@Shivansh2407 merge this PR.

I think
@Shivansh2407 can you merge this pr or
@Shivansh2407 would you merge this pr
would have been better

@coding-CEO
Copy link
Contributor Author

@Shivansh2407 Can you merge this PR.

Dishebh
Dishebh suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@Dishebh Dishebh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title as per the changes made and issues solved.

@coding-CEO coding-CEO changed the title Fixed TOC text in Boolean Algebra Fixed TOC text design in Boolean Algebra and redesigned search-bar. May 20, 2020
@coding-CEO
Copy link
Contributor Author

Please update the PR title as per the changes made and issues solved.

Done.

YashKumarVerma
YashKumarVerma reviewed May 20, 2020
View reviewed changes
Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shivansh2407 do you think that all caps in the list were better?

@Shivansh2407
Copy link
Member

For a nested list, I think these are fine. Let me know your views.

@YashKumarVerma YashKumarVerma merged commit 4bb9419 into CircuitVerse:master May 20, 2020
@YashKumarVerma
Copy link
Member

Thanks a lot for your contributions.

@coding-CEO coding-CEO deleted the boolean-toc-text-fix branch May 21, 2020 05:52
JoshHeng pushed a commit to JoshHeng/Interactive-Book that referenced this pull request May 21, 2020
@coding-CEO @JoshHeng
Fixed TOC text design in Boolean Algebra and redesigned search-bar. (C…
05b1b60 
…ircuitVerse#322)
Dishebh pushed a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@coding-CEO @Dishebh
Fixed TOC text design in Boolean Algebra and redesigned search-bar. (C…
7e52937 
…ircuitVerse#322)
Dishebh pushed a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@coding-CEO @Dishebh
Fixed TOC text design in Boolean Algebra and redesigned search-bar. (C…
7c06b88 
…ircuitVerse#322)
Dishebh pushed a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@deepak2431 @ShubhankarKG
@abhinavsri360 @Dishebh
Reference links added
4e3a4b2 
Added gates' images (CircuitVerse#291)

* added gates images in gates.md

* updated images' resolutions

* updating and && or gates' images

* added images of gates

* added or gate

Update Binary.md (CircuitVerse#282)

fixed typo (CircuitVerse#299)

Changed 'n' to 'In'

request for meaningful PR title (CircuitVerse#302)

Adding examples for binary operations (CircuitVerse#298)

Removed unnecessary files in _layout folder (CircuitVerse#297)

Made commutative and associative law examples look good on mobile (CircuitVerse#296)

* Made commutative and associative law look good on mobile
* Updated bool.md and changed design of all examples in boolean algebra
* changed distributive law design

* Redesigned SVG paths for dark mode

Fixed grammatical errors of application.md (CircuitVerse#301)

removed redundant data and made alu.md prettier (CircuitVerse#300)

Boolean Algebra page contents made organic (CircuitVerse#304)

Add multiplexer and demultiplexer examples

Update mux.md

Removed a redundant circuit and updated text

Update demux.md

Updated Text

Alignment issue fixed for Binary Numbers Representation (CircuitVerse#312)

Update PULL_REQUEST_TEMPLATE.md (CircuitVerse#316)

Spell check of the word 'meaningful'

Fixed the cap condition input in binary operator (CircuitVerse#319)

Redesigned list in Boolean Algebra dropdown (CircuitVerse#307)

* Added images in Boolean Algebra dropdown

* improved scss code in selects.scss

* updated selects.scss

made changes according to hound bot

* updated selects.scss

fixed trailing whitespace issue according to hound bot

* added the dropdown arrow

* Added image of NOT gate and changed the image in dropdown

Added interactive ALU circuit (CircuitVerse#119)

* Add interactive ALU circuit and truth table (CircuitVerse#114)

Embedded a CircuitVerse ALU circuit and updated the relevant truth table
Circuit link - https://circuitverse.org/users/14122/projects/42961

* Update alu.md

Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com>

added toc to the top (CircuitVerse#327)

Make deploy URLs relative, Fixes CircuitVerse#328

Fixed the Search Input in Boolean Function (CircuitVerse#324)

Boolean functions page content refactored (CircuitVerse#315)

corrected grammatical errs and made more prettier (CircuitVerse#313)

Fixed the Invisible search text in darkmode

Generate references from config (CircuitVerse#306)

added toc and refactored combinational logic (CircuitVerse#318)

Added more types of latches and refactored it (CircuitVerse#326)

Fixed TOC text design in Boolean Algebra and redesigned search-bar. (CircuitVerse#322)

Added more types of encoder (CircuitVerse#314)

added truth table for POS example (CircuitVerse#333)

Req. screenshots in pull request for UI Changes (CircuitVerse#334)

Added table of contents and refactored registers (CircuitVerse#317)

added table of contents and refactored registers
made some changes to the registers docs
fixing docs of registers

Fixes regarding ToC, it's position and links (CircuitVerse#332)

Fixing Typos (CircuitVerse#338)

Word -> 'fixed'
Grammatical error

New NAND Gate Method for boolean simplification (CircuitVerse#341)

fixed error in boolean function (CircuitVerse#344)

Refactor the Disqus Code (CircuitVerse#172)

* Refactor Disqus code into the default layout
* The Disqus commenting code has been refactored from in each page's file to the default layout. Commenting can be disabled by adding `page.disable_comments` to true

Update copyright notice

Update copyright notice as copyright of interactive book is not an individual

Update copyright notice in the Readme file

New feature:Add previous and next buttons(Fixes CircuitVerse#73 , CircuitVerse#160) (CircuitVerse#340)

added simulations for digital-registers (CircuitVerse#347)

switch decoder/encoder order in side-nav (CircuitVerse#350)

update (#8)

* Fixed favicon.ico link in head.html (CircuitVerse#353)

* Updated Boolean functions page (CircuitVerse#309)

Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms.

* Sidebar logo fixed (CircuitVerse#346)

Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com>
Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dishebh Dishebh Dishebh requested changes

@abhinavsri360 abhinavsri360 abhinavsri360 approved these changes

@YashKumarVerma YashKumarVerma YashKumarVerma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix this text of table of content in Boolean Algebra
5 participants
@coding-CEO @abhinavsri360 @YashKumarVerma @Shivansh2407 @Dishebh