Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar logo fixed in all the pages #346

Merged
merged 1 commit into from
May 23, 2020
Merged

Sidebar logo fixed in all the pages #346

merged 1 commit into from
May 23, 2020

Conversation

abhinavsri360
Copy link
Contributor

@abhinavsri360 abhinavsri360 commented May 22, 2020 •
edited
Loading

A meaningful title for PR, not like: made changes to xyz.md

Fixes #
There was an issue with the sidebar button in some pages i.e., the button was not uniform across all pages. Though I found an alternative way to fix that still I would like to bring to everyone's notice that when the pages with children are loaded they throw an error of something like this:
image
But pages work fine and Sidebar logo is fixed in all the pages even in the page 404
Closes #236
Ref #

Changes done:

Screenshots

✅️ By submitting this PR, I have verified the following

@abhinavsri360
Copy link
Contributor Author

I would request all of you to review this:
@YashKumarVerma @ShubhankarKG @Shivansh2407
@Shivansh2407 this works for the page 404 as well.

ShubhankarKG
ShubhankarKG suggested changes May 22, 2020
View reviewed changes
Copy link
Contributor

@ShubhankarKG ShubhankarKG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly fix the part mentioned. Rest looks good. Nice work.

_includes/head.html
{% if page.parent %}
<script defer src="../../assets/js/fontawesome-solid.js"></script>
<script defer src="../../assets/js/fontawesome-main.js"></script>
{% else if parent %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does parent refer to ? All page attributes are available via page.something syntax. Might consider removing this.

@abhinavsri360
Copy link
Contributor Author

parent refers to the file something like flipflop/flip-flops.md here flipflop is not in docs directory also it is not even a child page that's why parent refers to the page which contains all child's. Removing this line will cause sidebar logo differences in parent pages, you can try removing this line in your local machine and navigate to msi components page sidebar logo will differ from what it should be that's why that line is there hope you get that 😅

@Shivansh2407
Copy link
Member

parent refers to the file something like flipflop/flip-flops.md here flipflop is not in docs directory also it is not even a child page that's why parent refers to the page which contains all child's. Removing this line will cause sidebar logo differences in parent pages, you can try removing this line in your local machine and navigate to msi components page sidebar logo will differ from what it should be that's why that line is there hope you get that

It would be better if you can post a screenshot for this situation. Rest all looks good to me. Nice work @abhinavsri360 👍

@abhinavsri360
Copy link
Contributor Author

parent refers to the file something like flipflop/flip-flops.md here flipflop is not in docs directory also it is not even a child page that's why parent refers to the page which contains all child's. Removing this line will cause sidebar logo differences in parent pages, you can try removing this line in your local machine and navigate to msi components page sidebar logo will differ from what it should be that's why that line is there hope you get that

It would be better if you can post a screenshot for this situation. Rest all looks good to me. Nice work @abhinavsri360 👍

image
@Shivansh2407 Have a look at what happens when we remove that line
@ShubhankarKG It do makes a difference

ShubhankarKG
ShubhankarKG approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@ShubhankarKG ShubhankarKG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @YashKumarVerma @Shivansh2407

Shivansh2407
Shivansh2407 approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@Shivansh2407 Shivansh2407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @abhinavsri360 👍

@Shivansh2407 Shivansh2407 merged commit 8966cfa into CircuitVerse:master May 23, 2020
@Shivansh2407 Shivansh2407 mentioned this pull request May 23, 2020
Closed
Dishebh added a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@Dishebh @ShubhankarKG @abhinavsri360
update (#8)
1541ede 
* Fixed favicon.ico link in head.html (CircuitVerse#353)

* Updated Boolean functions page (CircuitVerse#309)

Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms.

* Sidebar logo fixed (CircuitVerse#346)

Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com>
Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
Dishebh added a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@Dishebh @ShubhankarKG @abhinavsri360
update (#9)
9da0bc3 
* Fixed favicon.ico link in head.html (CircuitVerse#353)

* Updated Boolean functions page (CircuitVerse#309)

Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms.

* Sidebar logo fixed (CircuitVerse#346)

Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com>
Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
Dishebh added a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@Dishebh @ShubhankarKG @abhinavsri360
update (#8)
21c00a7 
* Fixed favicon.ico link in head.html (CircuitVerse#353)

* Updated Boolean functions page (CircuitVerse#309)

Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms.

* Sidebar logo fixed (CircuitVerse#346)

Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com>
Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
Dishebh pushed a commit to Dishebh/Interactive-Book that referenced this pull request May 23, 2020
@deepak2431 @ShubhankarKG
@abhinavsri360 @Dishebh
Reference links added
4e3a4b2 
Added gates' images (CircuitVerse#291)

* added gates images in gates.md

* updated images' resolutions

* updating and && or gates' images

* added images of gates

* added or gate

Update Binary.md (CircuitVerse#282)

fixed typo (CircuitVerse#299)

Changed 'n' to 'In'

request for meaningful PR title (CircuitVerse#302)

Adding examples for binary operations (CircuitVerse#298)

Removed unnecessary files in _layout folder (CircuitVerse#297)

Made commutative and associative law examples look good on mobile (CircuitVerse#296)

* Made commutative and associative law look good on mobile
* Updated bool.md and changed design of all examples in boolean algebra
* changed distributive law design

* Redesigned SVG paths for dark mode

Fixed grammatical errors of application.md (CircuitVerse#301)

removed redundant data and made alu.md prettier (CircuitVerse#300)

Boolean Algebra page contents made organic (CircuitVerse#304)

Add multiplexer and demultiplexer examples

Update mux.md

Removed a redundant circuit and updated text

Update demux.md

Updated Text

Alignment issue fixed for Binary Numbers Representation (CircuitVerse#312)

Update PULL_REQUEST_TEMPLATE.md (CircuitVerse#316)

Spell check of the word 'meaningful'

Fixed the cap condition input in binary operator (CircuitVerse#319)

Redesigned list in Boolean Algebra dropdown (CircuitVerse#307)

* Added images in Boolean Algebra dropdown

* improved scss code in selects.scss

* updated selects.scss

made changes according to hound bot

* updated selects.scss

fixed trailing whitespace issue according to hound bot

* added the dropdown arrow

* Added image of NOT gate and changed the image in dropdown

Added interactive ALU circuit (CircuitVerse#119)

* Add interactive ALU circuit and truth table (CircuitVerse#114)

Embedded a CircuitVerse ALU circuit and updated the relevant truth table
Circuit link - https://circuitverse.org/users/14122/projects/42961

* Update alu.md

Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com>

added toc to the top (CircuitVerse#327)

Make deploy URLs relative, Fixes CircuitVerse#328

Fixed the Search Input in Boolean Function (CircuitVerse#324)

Boolean functions page content refactored (CircuitVerse#315)

corrected grammatical errs and made more prettier (CircuitVerse#313)

Fixed the Invisible search text in darkmode

Generate references from config (CircuitVerse#306)

added toc and refactored combinational logic (CircuitVerse#318)

Added more types of latches and refactored it (CircuitVerse#326)

Fixed TOC text design in Boolean Algebra and redesigned search-bar. (CircuitVerse#322)

Added more types of encoder (CircuitVerse#314)

added truth table for POS example (CircuitVerse#333)

Req. screenshots in pull request for UI Changes (CircuitVerse#334)

Added table of contents and refactored registers (CircuitVerse#317)

added table of contents and refactored registers
made some changes to the registers docs
fixing docs of registers

Fixes regarding ToC, it's position and links (CircuitVerse#332)

Fixing Typos (CircuitVerse#338)

Word -> 'fixed'
Grammatical error

New NAND Gate Method for boolean simplification (CircuitVerse#341)

fixed error in boolean function (CircuitVerse#344)

Refactor the Disqus Code (CircuitVerse#172)

* Refactor Disqus code into the default layout
* The Disqus commenting code has been refactored from in each page's file to the default layout. Commenting can be disabled by adding `page.disable_comments` to true

Update copyright notice

Update copyright notice as copyright of interactive book is not an individual

Update copyright notice in the Readme file

New feature:Add previous and next buttons(Fixes CircuitVerse#73 , CircuitVerse#160) (CircuitVerse#340)

added simulations for digital-registers (CircuitVerse#347)

switch decoder/encoder order in side-nav (CircuitVerse#350)

update (#8)

* Fixed favicon.ico link in head.html (CircuitVerse#353)

* Updated Boolean functions page (CircuitVerse#309)

Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms.

* Sidebar logo fixed (CircuitVerse#346)

Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com>
Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
@abhinavsri360 abhinavsri360 deleted the sidebar branch May 27, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhankarKG ShubhankarKG ShubhankarKG approved these changes

@Shivansh2407 Shivansh2407 Shivansh2407 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Sidebar button in some pages
3 participants
@abhinavsri360 @Shivansh2407 @ShubhankarKG