Table of Contents rendered at the bottom fixed and rendered at the top of the page #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean functions page refactored
Boolean functions page refactored Truth table refactored Update PULL_REQUEST_TEMPLATE.md (#316) Spell check of the word 'meaningful' Fixed the cap condition input in binary operator (#319) Redesigned list in Boolean Algebra dropdown (#307) * Added images in Boolean Algebra dropdown * improved scss code in selects.scss * updated selects.scss made changes according to hound bot * updated selects.scss fixed trailing whitespace issue according to hound bot * added the dropdown arrow * Added image of NOT gate and changed the image in dropdown Added interactive ALU circuit (#119) * Add interactive ALU circuit and truth table (#114) Embedded a CircuitVerse ALU circuit and updated the relevant truth table Circuit link - https://circuitverse.org/users/14122/projects/42961 * Update alu.md Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com> added toc to the top (#327) Make deploy URLs relative, Fixes #328 Fixed the Search Input in Boolean Function (#324) Boolean functions page content refactored (#315) corrected grammatical errs and made more prettier (#313) Fixed the Invisible search text in darkmode Generate references from config (#306)
author Dishebh Bhayana <43489708+Dishebh@users.noreply.github.com> 1589733881 +0530 committer abhinavsri360 <abhinav.022000@gmail.com> 1589969819 +0530 Fixed grammatical errors of application.md (#301) removed redundant data and made alu.md prettier (#300) Boolean Algebra page contents made organic (#304) parent 948d496 author Pratik Raut <52625909+coding-CEO@users.noreply.github.com> 1589796027 +0530 committer abhinavsri360 <abhinav.022000@gmail.com> 1589969724 +0530 Alignment issue fixed for Binary Numbers Representation (#312) Update bool2.md Boolean functions page refactored Truth table refactored Update PULL_REQUEST_TEMPLATE.md (#316) Spell check of the word 'meaningful' Fixed the cap condition input in binary operator (#319) Redesigned list in Boolean Algebra dropdown (#307) * Added images in Boolean Algebra dropdown * improved scss code in selects.scss * updated selects.scss made changes according to hound bot * updated selects.scss fixed trailing whitespace issue according to hound bot * added the dropdown arrow * Added image of NOT gate and changed the image in dropdown Added interactive ALU circuit (#119) * Add interactive ALU circuit and truth table (#114) Embedded a CircuitVerse ALU circuit and updated the relevant truth table Circuit link - https://circuitverse.org/users/14122/projects/42961 * Update alu.md Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com> added toc to the top (#327) Make deploy URLs relative, Fixes #328 Fixed the Search Input in Boolean Function (#324) Boolean functions page content refactored (#315) corrected grammatical errs and made more prettier (#313) Fixed the Invisible search text in darkmode Generate references from config (#306) Truth table refactored Update PULL_REQUEST_TEMPLATE.md (#316) Spell check of the word 'meaningful' Fixed the cap condition input in binary operator (#319) Redesigned list in Boolean Algebra dropdown (#307) * Added images in Boolean Algebra dropdown * improved scss code in selects.scss * updated selects.scss made changes according to hound bot * updated selects.scss fixed trailing whitespace issue according to hound bot * added the dropdown arrow * Added image of NOT gate and changed the image in dropdown Added interactive ALU circuit (#119) * Add interactive ALU circuit and truth table (#114) Embedded a CircuitVerse ALU circuit and updated the relevant truth table Circuit link - https://circuitverse.org/users/14122/projects/42961 * Update alu.md Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com> added toc to the top (#327) Make deploy URLs relative, Fixes #328 Fixed the Search Input in Boolean Function (#324) Boolean functions page content refactored (#315) corrected grammatical errs and made more prettier (#313) Fixed the Invisible search text in darkmode Generate references from config (#306)
|
@YashKumarVerma I have made the necessary changes, now you can review this PR |
|
It's best you first open issues and confirm it from one of the mentors prior to working on that issue. |
|
Should I open one now? |
YashKumarVerma
suggested changes
May 20, 2020
|
Deployment link: https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/combinational |
YashKumarVerma
suggested changes
May 21, 2020
There was a problem hiding this comment.
I'm afraid it's not about numbering format.
Check these out
- Fixed TOC text design in Boolean Algebra and redesigned search-bar. #322
- Shifted ToC to the top of the page #327
- Added toc and refactored Combinational Logic #318
and see how Table of content are added.
|
Extremely Sorry for that @YashKumarVerma, I should take care of everything. |
YashKumarVerma
suggested changes
May 21, 2020
There was a problem hiding this comment.
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/msi/decoder
has the wrong title as multiplexer
|
Title fixed |
|
Thanks a lot for your contributions. |
|
Thank you so much 😄 |
JoshHeng
pushed a commit
to JoshHeng/Interactive-Book
that referenced
this pull request
May 21, 2020
Dishebh
pushed a commit
to Dishebh/Interactive-Book
that referenced
this pull request
May 23, 2020
Dishebh
pushed a commit
to Dishebh/Interactive-Book
that referenced
this pull request
May 23, 2020
Dishebh
pushed a commit
to Dishebh/Interactive-Book
that referenced
this pull request
May 23, 2020
Added gates' images (CircuitVerse#291) * added gates images in gates.md * updated images' resolutions * updating and && or gates' images * added images of gates * added or gate Update Binary.md (CircuitVerse#282) fixed typo (CircuitVerse#299) Changed 'n' to 'In' request for meaningful PR title (CircuitVerse#302) Adding examples for binary operations (CircuitVerse#298) Removed unnecessary files in _layout folder (CircuitVerse#297) Made commutative and associative law examples look good on mobile (CircuitVerse#296) * Made commutative and associative law look good on mobile * Updated bool.md and changed design of all examples in boolean algebra * changed distributive law design * Redesigned SVG paths for dark mode Fixed grammatical errors of application.md (CircuitVerse#301) removed redundant data and made alu.md prettier (CircuitVerse#300) Boolean Algebra page contents made organic (CircuitVerse#304) Add multiplexer and demultiplexer examples Update mux.md Removed a redundant circuit and updated text Update demux.md Updated Text Alignment issue fixed for Binary Numbers Representation (CircuitVerse#312) Update PULL_REQUEST_TEMPLATE.md (CircuitVerse#316) Spell check of the word 'meaningful' Fixed the cap condition input in binary operator (CircuitVerse#319) Redesigned list in Boolean Algebra dropdown (CircuitVerse#307) * Added images in Boolean Algebra dropdown * improved scss code in selects.scss * updated selects.scss made changes according to hound bot * updated selects.scss fixed trailing whitespace issue according to hound bot * added the dropdown arrow * Added image of NOT gate and changed the image in dropdown Added interactive ALU circuit (CircuitVerse#119) * Add interactive ALU circuit and truth table (CircuitVerse#114) Embedded a CircuitVerse ALU circuit and updated the relevant truth table Circuit link - https://circuitverse.org/users/14122/projects/42961 * Update alu.md Co-authored-by: Shivansh Srivastava <42182955+Shivansh2407@users.noreply.github.com> added toc to the top (CircuitVerse#327) Make deploy URLs relative, Fixes CircuitVerse#328 Fixed the Search Input in Boolean Function (CircuitVerse#324) Boolean functions page content refactored (CircuitVerse#315) corrected grammatical errs and made more prettier (CircuitVerse#313) Fixed the Invisible search text in darkmode Generate references from config (CircuitVerse#306) added toc and refactored combinational logic (CircuitVerse#318) Added more types of latches and refactored it (CircuitVerse#326) Fixed TOC text design in Boolean Algebra and redesigned search-bar. (CircuitVerse#322) Added more types of encoder (CircuitVerse#314) added truth table for POS example (CircuitVerse#333) Req. screenshots in pull request for UI Changes (CircuitVerse#334) Added table of contents and refactored registers (CircuitVerse#317) added table of contents and refactored registers made some changes to the registers docs fixing docs of registers Fixes regarding ToC, it's position and links (CircuitVerse#332) Fixing Typos (CircuitVerse#338) Word -> 'fixed' Grammatical error New NAND Gate Method for boolean simplification (CircuitVerse#341) fixed error in boolean function (CircuitVerse#344) Refactor the Disqus Code (CircuitVerse#172) * Refactor Disqus code into the default layout * The Disqus commenting code has been refactored from in each page's file to the default layout. Commenting can be disabled by adding `page.disable_comments` to true Update copyright notice Update copyright notice as copyright of interactive book is not an individual Update copyright notice in the Readme file New feature:Add previous and next buttons(Fixes CircuitVerse#73 , CircuitVerse#160) (CircuitVerse#340) added simulations for digital-registers (CircuitVerse#347) switch decoder/encoder order in side-nav (CircuitVerse#350) update (#8) * Fixed favicon.ico link in head.html (CircuitVerse#353) * Updated Boolean functions page (CircuitVerse#309) Created new docs for SOP, Standard POS and SOP and Conversion from SOP to POS and minimal to standard forms. * Sidebar logo fixed (CircuitVerse#346) Co-authored-by: Shubhankar Kanchan Gupta <shubhankar.gupto.11@gmail.com> Co-authored-by: Abhinav Srivastava <abhinav.022000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A meaningful title for PR, not like: made changes to xyz.md
Fixes #
I have fixed the position of Table of Contents in the following pages namely:
Registers, MSI, Flipflops, and Combinational. In all these pages Table of Contents was rendered at the bottom of the page, I have fixed that and made Table of contents render at the top of the page.
Also, In all the sub-pages of these pages, some of them were not having Table of Contents in them, I have fixed that as well.
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/flipflop
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/Latches
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/register
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/combinational
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/msi
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/registers/pp
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/Combinational/half_sub
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/flipflop/t_flipflop
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/flipflop/sr_flipflop
https://deploy-preview-332--tender-ardinghelli-ebb79f.netlify.app/docs/registers/sp
Ref #
Changes done:
Table of Contents rendered at the bottom, fixed in the pages mentioned above.
✅️ By submitting this PR, I have verified the following
All changes are present in the commit: 7eb4576