-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tin as a material and make some "tin" dining items from it. #33092
Conversation
I need to use coffee before using git. |
Hope you are aware of https://en.wikipedia.org/wiki/Tin_pest |
I'm very much aware of grey tin and tin pest (and zinc pest!), but I'm not going to be covering those in this PR. :) |
Merged already? I guess that means I didn't make any unforseen mistakes. Thank you! :) |
WTH. I was just doing the same thing! |
Given that we have a freezing point but no boiling point in the materials properties I'm fairly sure that the |
Yes, I believe I have the correct chemical properties in my PR. The latent heat of fusion for tin is 59 J/g (equivalent to kJ/kg): https://www.engineeringtoolbox.com/fusion-heat-metals-d_1266.html Also the specific heat of liquid tin is 0.24. https://www.engineeringtoolbox.com/liquid-metal-boiling-points-specific-heat-d_1893.html |
@ampersand55 : You rock! Have opened a PR with your updates figures and assigned you attribution in git! :) |
Summary
SUMMARY: Bugfixes "Tin is now a first-class material, and tin items can be disassembled or smelted into tin scrap."
Purpose of change
Despite scrap "tin" being in game and used in recipes, items described as being made from tin (such as a "tin plate") were instead made from aluminium or other metals.
Describe the solution
I've added "tin" as a material, and changed at least one set of items described as being made of tin to use it.
A few things to note:
burn_products
to produce tin scrap, but I'm not 100% sure of the arguments here. I'd appreciate extra checking.Describe alternatives you've considered