Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tin recipe to use actual tin items #33111

Merged
merged 3 commits into from
Aug 10, 2019

Conversation

ampersand55
Copy link
Contributor

@ampersand55 ampersand55 commented Aug 10, 2019

Summary

SUMMARY: Bugfixes "Make the recipe for tin use actual tin items"

Purpose of change

Realism. Modern tin cans are made out of steel or aluminium. Some cans have a minimal coating of tin, but not enough to extract efficiently.

Contrary to its name, a tin can made using modern processes actually contains no tin. Tin is relatively rare, and modern cans are usually made of aluminum or other treated metals.

https://sciencing.com/tin-cans-made-5344942.html

No cans currently in wide use are composed primarily or wholly of tin;that term rather reflects the nearly exclusive use in cans, until the second half of the 20th century, of tinplate steel, which combined the physical strength and relatively low price of steel with the corrosion resistance of tin. Depending on contents and available coatings, some canneries still use tin-free steel.

https://en.wikipedia.org/wiki/Steel_and_tin_cans#Materials

Describe the solution

As we now have proper tin items as of #33092, it's a good time to change the tin recipe to use those instead.

Describe alternatives you've considered

Additional context

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Aug 10, 2019
@ZhilkinSerg ZhilkinSerg merged commit 51e24d9 into CleverRaven:master Aug 10, 2019
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* change tin recipe to use tin items

* change tin yield to better match materials used

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants