feat(update): Pydantic model #3828
Conversation
|
@ahdamin Thx for the review! @Karl-Svard Do you have a good way to test this model and do you agree with the type changes? |
There was a problem hiding this comment.
Nice work! I believe this shouldn't break anything specific, with the exception of maybe one value (see the comment below). I would test this PR through the order portal as this model is responsible for converting order data before pushing it to LIMS. Use a test order that populates as many of these UDFs as possible and then double-check that it propagates to LIMS correctly. I can help with checking the LIMS part and maybe @islean or @Vince-janv have good examples of orders to use.
| reference_genome: str | None | ||
| region: str | None | ||
| region_code: str | None | ||
| quantity: float | None = None |
There was a problem hiding this comment.
This value will populate the text UDF "Quantity" in LIMS. It could be good to test that it doesn't break something
|
|
@sysdev Anyone that have time to test this? |
|
|
@sysdev Anyone that have time to test this? Should we wait with this until the improve order flow project is done? |
Description
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan