Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket status for existing samples #4150

Merged
merged 22 commits into from
Feb 4, 2025
Merged

Ticket status for existing samples #4150

merged 22 commits into from
Feb 4, 2025

Conversation

eliottBo
Copy link
Contributor

Description

Close #4006

Added

  • Ticket with only existing samples get the status open

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

eliottBo added 14 commits January 23, 2025 14:26
@eliottBo
Add utility functions for order data validation and ticket tag genera…
2f0dfa6 
…tion
@eliottBo
Integrate ticket tag generation into TicketHandler
4062b04
@eliottBo
Add unit test for ticket tag generation based on order type
71909ce
@eliottBo
Refactor ticket tag generation and enhance unit tests for accuracy
da49a5c
@eliottBo
Rename function and update references in ticket tag generation
5555920
@eliottBo
Add fixture for MIP DNA order with existing samples
19efd0f
@eliottBo
Update internal_id for existing sample in MIP DNA order fixture
0af8611
@eliottBo
Rename function for clarity and update ticket tag generation logic to…
5fad3d0 
… check for existing data in orders
@eliottBo
Add functions to check if only existing samples and retrieve ticket s…
c905331 
…tatus
@eliottBo
Update ticket status constants in get_ticket_status function
b5db7a7
@eliottBo
Add fixture for MIP DNA order with only existing samples and test tic…
bd6401c 
…ket status
@eliottBo
Add ticket status retrieval in TicketHandler for ticket creation
dbd8bf1
@eliottBo
Refactor contains_only_existing_samples to accept OrderWithCases and …
93b5448 
…update get_ticket_status logic
@eliottBo
Fix return value in mip_dna_order_with_only_existing_samples function…
9770d13 
… to return correct variable
@eliottBo eliottBo requested a review from a team as a code owner January 23, 2025 14:11
@eliottBo eliottBo requested a review from Vince-janv January 23, 2025 15:37
@Vince-janv Vince-janv changed the base branch from master to ticket-tag-existing-data January 23, 2025 15:41
Vince-janv
Vince-janv approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean 👍

cg/meta/orders/utils.py Outdated Show resolved Hide resolved
tests/services/orders/submitter/test_order_submitter.py Outdated Show resolved Hide resolved
cg/meta/orders/utils.py Outdated Show resolved Hide resolved
eliottBo and others added 4 commits January 24, 2025 08:40
@eliottBo @Vince-janv
Update cg/meta/orders/utils.py
7efea83 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo @Vince-janv
Update tests/services/orders/submitter/test_order_submitter.py
384ea30 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo @Vince-janv
Remove space cg/meta/orders/utils.py
a3836a0 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo
Add import for Status constant in test_order_submitter.py
0965558
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 24, 2025 09:11 Inactive
@eliottBo
Copy link
Contributor Author

Test:

Screenshot 2025-01-24 at 10 21 53

islean
islean approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cg/meta/orders/utils.py Outdated Show resolved Hide resolved
cg/meta/orders/utils.py Show resolved Hide resolved
eliottBo and others added 2 commits January 29, 2025 13:14
@eliottBo @islean
Update cg/meta/orders/utils.py
7eca66f 
Co-authored-by: Isak Ohlsson Ångnell <40887124+islean@users.noreply.github.com>
@eliottBo
Fix indentation in contains_only_existing_samples function in utils.py
c08b4ba
Base automatically changed from ticket-tag-existing-data to master February 4, 2025 07:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@eliottBo eliottBo merged commit 69d87b8 into master Feb 4, 2025
10 checks passed
@eliottBo eliottBo deleted the ticket-status-for-existing-samples branch February 4, 2025 09:25
@eliottBo
Copy link
Contributor Author

eliottBo commented Feb 4, 2025

Deployment to prod:

cg, version 67.1.4

...

Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/eliott.bosshard
done.
Log deploy... done.
cg, version 67.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@Vince-janv Vince-janv Vince-janv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order tickets containing ONLY existing samples should have the status "open"
4 participants
@eliottBo @islean @Vince-janv @clingen-sthlm