Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests from improve order flow #4152

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Fix tests from improve order flow #4152

merged 4 commits into from
Jan 27, 2025

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Jan 23, 2025

Description

Fix some tests set to fail in the main branch and adds a test for the case when skipping reception control is set to true.

How to test

  • No production code touched

Review

  • "Merge and deploy" approved by IO
    Thanks for filling in who performed the code review and the test!

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Deployed to stage:
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
cg, version 67.0.5
[js.diazboada@hasta:~] [S_base] $ up
  • Deployed to production:
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
cg, version 67.0.5

@diitaz93 diitaz93 changed the title fix failing tests Fix tests from improve order flow Jan 23, 2025
@diitaz93 diitaz93 marked this pull request as ready for review January 23, 2025 16:09
@diitaz93 diitaz93 requested a review from a team as a code owner January 23, 2025 16:09
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@diitaz93 diitaz93 merged commit 0eb9374 into master Jan 27, 2025
10 checks passed
@diitaz93 diitaz93 deleted the fix-remaining-tests branch January 27, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants