Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nallo store command #4171

Merged
merged 28 commits into from
Feb 12, 2025
Merged

Add nallo store command #4171

merged 28 commits into from
Feb 12, 2025

Conversation

rannick
Copy link
Contributor

@rannick rannick commented Jan 30, 2025

Description

Added

  • Store and store housekeeper command for nallo, resources might change slightly in a subsequent PR

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@rannick rannick requested a review from a team as a code owner January 30, 2025 10:42
@rannick rannick self-assigned this Feb 12, 2025
@diitaz93 diitaz93 self-requested a review February 12, 2025 10:02
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍 Can't say anything about the yamls

Co-authored-by: Sebastian Diaz <juan.sebastian.diaz.boada@scilifelab.se>
@rannick rannick merged commit f36b6b2 into master Feb 12, 2025
9 checks passed
@rannick rannick deleted the add_nallo_store_command branch February 12, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants