-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadialGauge sample does not load when opened while narrator open #3537
Labels
accessibility ♿
bug 🐛
An unexpected issue that highlights incorrect behavior
Completed 🔥
sample app 🖼
Milestone
Comments
ghost
added
the
needs triage 🔍
label
Oct 21, 2020
Hello chingucoding, thank you for opening an issue with us! I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌 |
Closed
2 tasks
Kyaa-dost
added
help wanted
Issues identified as good community contribution opportunities
sample app 🖼
labels
Oct 22, 2020
This was referenced Oct 22, 2020
Open
2 tasks
Kyaa-dost
removed
help wanted
Issues identified as good community contribution opportunities
needs triage 🔍
labels
Oct 22, 2020
ghost
added
the
In-PR 🚀
label
Oct 23, 2020
ghost
pushed a commit
that referenced
this issue
Oct 29, 2020
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 --> ## Fixes # <!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. --> Fixes #3537 , Fixes #3539 , Fixes #3542 (this PR is all we can do, see microsoft/microsoft-ui-xaml#3469) <!-- Add a brief overview here of the feature/bug & fix. --> The issues with the sample were caused by microsoft/microsoft-ui-xaml#3467 , switching to RangeBaseAutomationPeer as base class for the RadialGauge peer fixes that. Afaik, the only thing we can (and should do) for #3542 is raise the appropriate event on the AutomationPeer. ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> RadialGauge is not accessible ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> RadialGauge is accessible ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets) - [x] Tests for the changes have been added (for bug fixes / features) (if applicable) - [x] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [Maybe?] Contains **NO** breaking changes <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information I left out the RangeSelector from this PR as fixing that controls behavior needs more discussion on how to approach that.
ghost
locked as resolved and limited conversation to collaborators
Dec 28, 2020
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accessibility ♿
bug 🐛
An unexpected issue that highlights incorrect behavior
Completed 🔥
sample app 🖼
Describe the bug
A clear and concise description of what the bug is.
When opening the RadialGauge sample page while narrator is open, the sample does not load and the XAML sample code reports an error.
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Sample should load
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
Additional context
The text was updated successfully, but these errors were encountered: