RadialGauge UIA improvements

[marcelwgn]

Fixes

Fixes #3537 , Fixes #3539 , Fixes #3542 (this PR is all we can do, see microsoft/microsoft-ui-xaml#3469)

The issues with the sample were caused by microsoft/microsoft-ui-xaml#3467 , switching to RangeBaseAutomationPeer as base class for the RadialGauge peer fixes that.

Afaik, the only thing we can (and should do) for #3542 is raise the appropriate event on the AutomationPeer.

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

RadialGauge is not accessible

What is the new behavior?

RadialGauge is accessible

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• [Maybe?] Contains NO breaking changes

Other information

I left out the RangeSelector from this PR as fixing that controls behavior needs more discussion on how to approach that.

[ghost]

Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[Kyaa-dost]

@chingucoding Seems like The Toolkit-CI keeps failing. Everything looks good on your end?

[marcelwgn]

Seems like there was an issue with the header of the new test file, thanks for the reminder @Kyaa-dost !

[Kyaa-dost]

@chingucoding still failing... Wondering if there is a conflict between the base class and variable. Not sure 🤔

[marcelwgn]

Yes, that build failure was because of the RadialGaugeAutomationPeer inheriting from RangeBase peer now which also implements the IRangeValueProvider interface. Added new keyword to hide inherited members.

[Kyaa-dost]

@chingucoding Thanks for the PR. Looks great and ready to 🚀 🚀

[ghost]

Hello @Kyaa-dost!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[Kyaa-dost]

@msftbot merge this pull request once it is approved by @vgromfeld

[ghost]

Hello @Kyaa-dost!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I'll only merge this pull request if it's approved by @vgromfeld

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".