Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadialGauge: Changing value does not announce changes to Narrator #3542

Closed
1 of 2 tasks
marcelwgn opened this issue Oct 22, 2020 · 5 comments · Fixed by #3544
Closed
1 of 2 tasks

RadialGauge: Changing value does not announce changes to Narrator #3542

marcelwgn opened this issue Oct 22, 2020 · 5 comments · Fixed by #3544
Assignees
Labels
accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼
Milestone

Comments

@marcelwgn
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

When using arrow keys to change the value of a RadialGauge control, the narrator is not being updated on the new value.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Assuming app does not crash on pressing a key while having a RadialGauge focused with narrator
  2. Press a key and observe value changed
  3. Notice the lack of value change being announced

Expected behavior

A clear and concise description of what you expected to happen.
New value should be announced.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

NuGet Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [x] Insider Build (build number: 20236)

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: ) 
- [ ] 2019 Preview (version: )

Additional context

Add any other context about the problem here.
If it's fine I would add it to my batch PR that updates UIA of RadialGauge and RangeSelector.

@marcelwgn marcelwgn added the bug 🐛 An unexpected issue that highlights incorrect behavior label Oct 22, 2020
@ghost ghost added the needs triage 🔍 label Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

Hello chingucoding, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

@chingucoding Is this also related to #3539 #3537?

@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Oct 22, 2020
@Kyaa-dost
Copy link
Contributor

@chingucoding also do you want me to assign these issues to you since you mentioned you will be working on them?

@marcelwgn
Copy link
Contributor Author

No, this is a separate bug as the RadialGauge automationpeer does not handle value changes.

Yes, sure feel free to assign the issues to me.

@Kyaa-dost
Copy link
Contributor

@chingucoding Thanks for the clarification and it makes sense ❤️

@ghost ghost added the In-PR 🚀 label Oct 23, 2020
@ghost ghost closed this as completed in #3544 Oct 29, 2020
ghost pushed a commit that referenced this issue Oct 29, 2020
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

## Fixes #
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

Fixes #3537 , Fixes #3539 , Fixes #3542 (this PR is all we can do, see microsoft/microsoft-ui-xaml#3469)

<!-- Add a brief overview here of the feature/bug & fix. -->

The issues with the sample were caused by microsoft/microsoft-ui-xaml#3467 , switching to RangeBaseAutomationPeer as base class for the RadialGauge peer fixes that.

Afaik, the only thing we can (and should do) for #3542 is raise the appropriate event on the AutomationPeer.

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

RadialGauge is not accessible

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->

RadialGauge is accessible

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [x] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [x] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [Maybe?] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information

I left out the RangeSelector from this PR as fixing that controls behavior needs more discussion on how to approach that.
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Oct 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 28, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants