Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gaiaflex to Makefile and Dockerfile #229

Merged
merged 15 commits into from
Jul 28, 2020
Merged

Add gaiaflex to Makefile and Dockerfile #229

merged 15 commits into from
Jul 28, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jul 27, 2020

Closes #210 (removed wasmgovd)

  • Create a new Makefile target build-gaiaflex
  • Add it to the Dockerfile
  • Allow us to set the enabled proposals via build flags:

-X github.com/CosmWasm/wasmd/app.ProposalsEnabled=true to enable all governance proposals (default all disabled)

-X github.com/CosmWasm/wasmd/app.EnableSpecificProposals=MigrateContract,UpdateAdmin,ClearAdmin to enable some governance proposals

@ethanfrey ethanfrey requested a review from alpe as a code owner July 27, 2020 17:42
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #229 into master will increase coverage by 0.13%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   72.34%   72.47%   +0.13%     
==========================================
  Files          27       27              
  Lines        2632     2652      +20     
==========================================
+ Hits         1904     1922      +18     
  Misses        616      616              
- Partials      112      114       +2     
Impacted Files Coverage Δ
app/app.go 88.82% <80.00%> (-0.53%) ⬇️
x/wasm/internal/types/proposal.go 95.21% <91.66%> (+0.26%) ⬆️
x/wasm/internal/keeper/keeper.go 91.15% <0.00%> (-0.54%) ⬇️
lcd_test/helpers.go 75.71% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d1fd8...f3cf373. Read the comment docs.

@ethanfrey
Copy link
Member Author

@orkunkl you can follow this to see when gaiaflex is in the Dockerfile

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 changes look good. Very nice to see how configurable the build process became

I did only smoke tests:

  • docker build ✅
  • gaiaflexd start ✅
  • gaiaflex query wasm code list ✅
  • home dirs ✅

x/wasm/internal/types/proposal.go Show resolved Hide resolved
x/wasm/internal/types/proposal_test.go Show resolved Hide resolved
x/wasm/internal/types/proposal_test.go Outdated Show resolved Hide resolved
@ethanfrey ethanfrey merged commit de9ebe8 into master Jul 28, 2020
@ethanfrey ethanfrey deleted the add-gaiaflex branch July 28, 2020 09:48
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
Update broken link to peers docs

[skip ci]
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…ster

* remotes/gaia/master: (38 commits)
  Merge PR CosmWasm#259: Bump SDK master commit
  Exec go mod tidy (CosmWasm#267)
  Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG
  Fix broken link in delegator guide (CosmWasm#262)
  docs: removed redundant readme.md (CosmWasm#261)
  Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2
  Merge PR CosmWasm#250: Docs-update
  Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1
  Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0
  Merge PR CosmWasm#253: Bump SDK master commit
  Merge PR CosmWasm#252: v2.0.4 Changelog
  Merge PR CosmWasm#249: docker image build and upload for release tags
  Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc
  Merge PR CosmWasm#246: Update Archive page with explorers
  Merge PR CosmWasm#245: archives
  Bump SDK commit to the latest master (CosmWasm#239)
  Merge PR CosmWasm#215: Update simulation tests
  Update join-mainnet.md (CosmWasm#229)
  Incorporate SDK's latest changes (CosmWasm#227)
  Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine wasmd and wasmgovd into one code package
3 participants