Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex ibc spike2d #253

Closed
wants to merge 11 commits into from
Closed

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 18, 2020

Spike for IBC contract integration. Super early version. Do not use for anything 🚧

Background discussions can be found on (closed PR): #231

@alpe alpe changed the base branch from master to 0.10_to_cosmos-stargate_ce9c2b2 August 18, 2020 09:20
@ethanfrey ethanfrey mentioned this pull request Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #253 into 0.10_to_cosmos-stargate_ce9c2b2 will decrease coverage by 0.22%.
The diff coverage is 17.42%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           0.10_to_cosmos-stargate_ce9c2b2     #253      +/-   ##
===================================================================
- Coverage                            17.68%   17.45%   -0.23%     
===================================================================
  Files                                   32       36       +4     
  Lines                                10593    11516     +923     
===================================================================
+ Hits                                  1873     2010     +137     
- Misses                                8636     9405     +769     
- Partials                                84      101      +17     
Impacted Files Coverage Δ
app/integration/test_common.go 0.00% <0.00%> (ø)
x/wasm/internal/types/codec.go 44.44% <0.00%> (-2.62%) ⬇️
x/wasm/internal/types/msg.pb.go 0.58% <ø> (ø)
x/wasm/internal/types/types.pb.go 0.73% <0.00%> (-0.02%) ⬇️
x/wasm/module.go 59.18% <0.00%> (+42.85%) ⬆️
x/wasm/internal/types/ibc.pb.go 1.05% <1.05%> (ø)
x/wasm/internal/types/msg.go 44.69% <8.69%> (-7.99%) ⬇️
x/wasm/internal/keeper/ibc.go 9.37% <9.37%> (ø)
app/export.go 7.59% <23.07%> (ø)
x/wasm/internal/keeper/handler_plugin.go 56.47% <26.74%> (-17.28%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3040a...9073b89. Read the comment docs.

@alpe alpe force-pushed the 0.10_to_cosmos-stargate_ce9c2b2 branch from fa61594 to 5b3040a Compare August 18, 2020 13:39
@ethanfrey
Copy link
Member

I see 2 things needed to finish up the IBC spike:

  1. Align this spike with the spec. Either by changing the implementation, or by changing the spec. Once aligned, let's merge this before adding more functionality.
  2. Implement Complete IBC Mock testing #255 after merging this to finalize the demo

@ethanfrey
Copy link
Member

Anything you feel missing here? I am waiting til it is ready to review to give a final review on it

* IBC callback redesign

* Add ping pong ibc example

* Cleanup some commented out code

* Apply review feedback

* Revert unintended renamings
@alpe
Copy link
Contributor Author

alpe commented Aug 25, 2020

Replaced by #261

@alpe alpe closed this Aug 25, 2020
@alpe alpe deleted the alex_ibc_spike2d branch August 27, 2020 09:55
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…ster

* remotes/gaia/master: (38 commits)
  Merge PR CosmWasm#259: Bump SDK master commit
  Exec go mod tidy (CosmWasm#267)
  Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG
  Fix broken link in delegator guide (CosmWasm#262)
  docs: removed redundant readme.md (CosmWasm#261)
  Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2
  Merge PR CosmWasm#250: Docs-update
  Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1
  Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0
  Merge PR CosmWasm#253: Bump SDK master commit
  Merge PR CosmWasm#252: v2.0.4 Changelog
  Merge PR CosmWasm#249: docker image build and upload for release tags
  Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc
  Merge PR CosmWasm#246: Update Archive page with explorers
  Merge PR CosmWasm#245: archives
  Bump SDK commit to the latest master (CosmWasm#239)
  Merge PR CosmWasm#215: Update simulation tests
  Update join-mainnet.md (CosmWasm#229)
  Incorporate SDK's latest changes (CosmWasm#227)
  Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants