Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.1 to cosmos stargate cli fixes #249

Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 7, 2020

  • Fix wasmcli + wasmd cli context
  • Upgrade sdk to 3322e26

The encoding issues on wasmd start are not solved with this, yet. Waiting for sdk updates to apply/ adopt them.

@alpe alpe marked this pull request as ready for review August 10, 2020 07:31
@alpe alpe requested a review from ethanfrey as a code owner August 10, 2020 07:31
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #249 into 0.9.1_to_cosmos-sdk-0.39-master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           0.9.1_to_cosmos-sdk-0.39-master     #249      +/-   ##
===================================================================
+ Coverage                            19.80%   19.91%   +0.11%     
===================================================================
  Files                                   25       25              
  Lines                                 6419     6428       +9     
===================================================================
+ Hits                                  1271     1280       +9     
  Misses                                5079     5079              
  Partials                                69       69              
Impacted Files Coverage Δ
app/app.go 91.90% <100.00%> (ø)
app/encoding.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e535077...c91b526. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Good to merge.

Two questions:

  1. This works to launch an app? Or is there an issue in genesis parsing still? (Please add that to the TODO in the stargate tracking branch, so we can keep track of what needs to be done).
  2. Is there a reason we cannot just copy the simapp/params into our app and use it. I would prefer not to import anything from simapp directly, and just use that as a model for what we want in our app dir.

app/app.go Outdated Show resolved Hide resolved
app/encoding.go Outdated Show resolved Hide resolved
cmd/wasmcli/main.go Show resolved Hide resolved
docker/setup.sh Show resolved Hide resolved
@alpe
Copy link
Contributor Author

alpe commented Aug 12, 2020

This works to launch an app? Or is there an issue in genesis parsing still?

Unfortunately not. It still fails with wasmd start. I will add a TODO

@alpe alpe merged commit 6b5133e into 0.9.1_to_cosmos-sdk-0.39-master Aug 12, 2020
@alpe alpe deleted the 0.9.1_to_cosmos-stargate_cli_fixes branch August 12, 2020 08:09
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…ster

* remotes/gaia/master: (38 commits)
  Merge PR CosmWasm#259: Bump SDK master commit
  Exec go mod tidy (CosmWasm#267)
  Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG
  Fix broken link in delegator guide (CosmWasm#262)
  docs: removed redundant readme.md (CosmWasm#261)
  Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2
  Merge PR CosmWasm#250: Docs-update
  Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1
  Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0
  Merge PR CosmWasm#253: Bump SDK master commit
  Merge PR CosmWasm#252: v2.0.4 Changelog
  Merge PR CosmWasm#249: docker image build and upload for release tags
  Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc
  Merge PR CosmWasm#246: Update Archive page with explorers
  Merge PR CosmWasm#245: archives
  Bump SDK commit to the latest master (CosmWasm#239)
  Merge PR CosmWasm#215: Update simulation tests
  Update join-mainnet.md (CosmWasm#229)
  Incorporate SDK's latest changes (CosmWasm#227)
  Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants