Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial load JS much too large #19

Closed
gavindoughtie opened this issue Oct 18, 2021 · 7 comments · Fixed by #479
Closed

Initial load JS much too large #19

gavindoughtie opened this issue Oct 18, 2021 · 7 comments · Fixed by #479
Labels
enhancement New feature or request

Comments

@gavindoughtie
Copy link
Contributor

The current first load JS payload for prod builds is over 600K before we've really developed much functionality. This is going to make the app sucky, especially on mobile. Look into using the next/bundle-analyzer and codesplitting/dynamic loading.

@gavindoughtie gavindoughtie added the bug Something isn't working label Oct 18, 2021
@elsehow
Copy link
Contributor

elsehow commented Oct 21, 2021

For the libsodium.js dependency, progress is here: cosmos/cosmjs#904

For the bip39 dependency, I think we can handle that on our side with a bit better optimization. A good static analyzer should be capable of removing it. It's just a regular (i.e., js, non-compiled) dependency of cosmjs/crypto: https://github.com/cosmos/cosmjs/blob/main/packages/crypto/package.json#L47

@webmaster128
Copy link

I wonder why libsodium.js isn't optimized out entirely. In thise codebase you use none of its functionality. However, I'm not aware of state of the art in JS optimization.

@elsehow
Copy link
Contributor

elsehow commented Oct 24, 2021

I have the same question @webmaster128. I think whatever the next build optimizer does is just not up to snuff---reasonable tree-shaking should get rid of the dependency. (libsodium.js size is still an issue, but shouldn't be our issue).

@webmaster128
Copy link

Jupp. I found a pretty good explanation in gcanti/fp-ts#813 and gcanti/fp-ts#814 for what needs to be done in CosmJS to make this work.

@JakeHartnell
Copy link
Member

I think this is a "Won't Fix" because it's upstream. Closing for now.

@elsehow
Copy link
Contributor

elsehow commented Jan 22, 2022

Re-opening this issue, as there is some hope of trimming the bundle sizes by removing dependencies on libsodium and bip39 using the tricks described here: cosmos/cosmjs#904 (comment)

@elsehow elsehow reopened this Jan 22, 2022
@elsehow elsehow added enhancement New feature or request and removed bug Something isn't working labels Jan 22, 2022
@elsehow elsehow modified the milestone: v2 Jan 22, 2022
@ebaker
Copy link
Contributor

ebaker commented Mar 31, 2022

fixed in cosmjs v0.28 - just need to upgrade the package

@ebaker ebaker added this to the v0.4.0 (Better MVP) milestone Mar 31, 2022
0xekez added a commit that referenced this issue Apr 10, 2022
JakeHartnell added a commit that referenced this issue Apr 16, 2022
* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

* Persist description newlines on ContractView (#476)

* Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

* Make connect wallet and wallet display button same sizes. (#482)

* feat(ui): update reach tooltip styles (#485)

* Fix treasury typo (#488)

* Fix treasury typo

* lint

* Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

* Better display when user did not vote on proposal. (#478)

* Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

* feat: improve eslint and prettier integration (#487)

* New proposal status UI (#489)

* chore: format and lint all sources (#493)

* Redeploy Vercel.

* Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

* feat(dapp): add create dao field tooltips (#486)

* Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

* feat(dapp): add create dao field tooltips (#486)

* Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: zeke <30676292+ezekiiel@users.noreply.github.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>
Co-authored-by: Sashimi <93623541+sashimi36@users.noreply.github.com>
Co-authored-by: Griko Nibras <grikomsn@live.com>
Co-authored-by: bao <baoskee@users.noreply.github.com>
Co-authored-by: Griko Nibras <git@griko.id>
0xekez pushed a commit that referenced this issue Apr 18, 2022
Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

Add utils package

newline at the end of tsconfig.json

remove debugging console.log

Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

Show second by second countdown when unstaking. (#456)

Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

Fix formatting issue in Button.tsx. (#461)

Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

Allow voting abstain on proposals. (#454)

Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Persist description newlines on ContractView (#476)

Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

Make connect wallet and wallet display button same sizes. (#482)

feat(ui): update reach tooltip styles (#485)

Fix treasury typo (#488)

* Fix treasury typo

* lint

Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

Better display when user did not vote on proposal. (#478)

Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

feat: improve eslint and prettier integration (#487)

New proposal status UI (#489)

chore: format and lint all sources (#493)

Redeploy Vercel.

Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

feat(dapp): add create dao field tooltips (#486)

Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Only show time left when proposal is open.

Split StakingModal into stateless and stateful components.
0xekez added a commit that referenced this issue Apr 18, 2022
* Only show abstain clarification once people vote.

* Split staking modal into stateless and statefull components.

Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

Add utils package

newline at the end of tsconfig.json

remove debugging console.log

Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

Show second by second countdown when unstaking. (#456)

Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

Fix formatting issue in Button.tsx. (#461)

Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

Allow voting abstain on proposals. (#454)

Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Persist description newlines on ContractView (#476)

Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

Make connect wallet and wallet display button same sizes. (#482)

feat(ui): update reach tooltip styles (#485)

Fix treasury typo (#488)

* Fix treasury typo

* lint

Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

Better display when user did not vote on proposal. (#478)

Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

feat: improve eslint and prettier integration (#487)

New proposal status UI (#489)

chore: format and lint all sources (#493)

Redeploy Vercel.

Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

feat(dapp): add create dao field tooltips (#486)

Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Only show time left when proposal is open.

Split StakingModal into stateless and stateful components.

* Pre moving templates to package rollback point oh boy.

* Stateless ProposalDetails.

* Migrate icons to icons package.

* Stateless wallet connect button.

* Stateless proposal details sidebar.

* Split StakingModal into stateless and stateful components.

* Pre moving templates to package rollback point oh boy.

* Stateless ProposalDetails.

* Migrate icons to icons package.

* Stateless wallet connect button.

* Merge in development post force push.

* Move all ContractView components to packages.

* Move claims components into packages.

* Improve visuals for claims pending.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants