Better empty state for new users #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baoskee is attempting to deploy a commit to the DAO DAO Team on Vercel. To accomplish this, @baoskee needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
baoskee
changed the title
ebaker
reviewed
Mar 30, 2022
apps/dapp/pages/dao/list.tsx
Outdated
| @@ -75,12 +71,55 @@ export function DaoCard({ | |||
| ) | |||
| } | |||
|
|
|||
| const EmptyStateContractCard = ({ | |||
There was a problem hiding this comment.
let's move this to components/EmptyStateContractCard.tsx
apps/dapp/pages/dao/list.tsx
Outdated
| <MysteryContractCard | ||
| title="Create a DAO" | ||
| body="You are not staking with any DAOs. Why not create one?" | ||
| <EmptyStateContractCard |
There was a problem hiding this comment.
let's just place this component inline on line 141 and get rid of MysteryContractCard here
apps/dapp/pages/dao/list.tsx
Outdated
| ) | ||
| } | ||
|
|
||
| export function MysteryMultisigCard() { |
There was a problem hiding this comment.
let's put this component inline where we use it for multisig.
There was a problem hiding this comment.
move to /multisig/list page
apps/dapp/pages/starred.tsx
Outdated
| @@ -100,7 +99,7 @@ const Starred: NextPage = () => { | |||
| <StarIcon className="inline w-5 h-5 mr-2 mb-1" /> | |||
| DAOs | |||
| </h2> | |||
| <div className="grid grid-cols-1 md:grid-cols-2 xl:grid-cols-3 2xl:grid-cols-4"> | |||
There was a problem hiding this comment.
guess we don't need grid here anymore?
ebaker
approved these changes
Apr 8, 2022
| @@ -0,0 +1,30 @@ | |||
| import { useRouter } from 'next/router' | |||
|
|
|||
| export const EmptyContractCard = ({ | |||
There was a problem hiding this comment.
let's use export default wherever possible - remove the export here and add
export default EmptyContractCard to the end of the file
| @@ -0,0 +1,12 @@ | |||
| import { EmptyContractCard } from './EmptyContractCard' | |||
|
|
|||
| export const EmptyDaoCard = () => { | |||
There was a problem hiding this comment.
remove export here and add export default EmptyDaoCard to the end of the file
| @@ -0,0 +1,12 @@ | |||
| import { EmptyContractCard } from './EmptyContractCard' | |||
|
|
|||
| export function EmptyMultisigCard() { | |||
There was a problem hiding this comment.
remove export here and add export default EmptyMultisigCard to end of file
| @@ -21,19 +21,15 @@ import { | |||
|
|
|||
| import { Button } from '@components' | |||
|
|
|||
| import { EmptyDaoCard } from '@components/EmptyDaoCard' | |||
There was a problem hiding this comment.
import using default export from above - import EmptyDaoCard from '@components/EmptyDaoCard'
| @@ -19,14 +19,11 @@ import { | |||
| UserIcon, | |||
| } from '@heroicons/react/outline' | |||
|
|
|||
| import { EmptyMultisigCard } from '@components/EmptyMultisigCard' | |||
There was a problem hiding this comment.
update import to use default export
| @@ -5,6 +5,8 @@ import { useRecoilState, useRecoilValue } from 'recoil' | |||
|
|
|||
| import { MapIcon, PlusIcon, StarIcon } from '@heroicons/react/outline' | |||
|
|
|||
| import { EmptyDaoCard } from '@components/EmptyDaoCard' | |||
There was a problem hiding this comment.
update import to use default export
0xekez
force-pushed
the
baoskee/empty-state-adding
branch
from
dc68ffb to
e284573
Compare
|
Rebased so we can merge this now. Thank you @baoskee ! This looks so good. Will make one more pass to test in the AM and then merge. |
Merged
JakeHartnell
added a commit
that referenced
this pull request
Apr 16, 2022
* Add utils package * newline at the end of tsconfig.json * remove debugging console.log * Crispier toasts (#442) * Increased duration toasts display on screen. * Display notifications above suspense loader. * Fixed vscode eslint fixing incorrect rules, and reformatted. * Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. * Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. * Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> * Add check for connected wallet (#452) * Show second by second countdown when unstaking. (#456) * Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. * Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" * Fix formatting issue in Button.tsx. (#461) * Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. * Allow voting abstain on proposals. (#454) * Use version number from package.json. (#455) * Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> * Persist description newlines on ContractView (#476) * Reuse @cosmjs clients (#480) * ChainClientRouter and its integration * upd comment * pr feedback * Make connect wallet and wallet display button same sizes. (#482) * feat(ui): update reach tooltip styles (#485) * Fix treasury typo (#488) * Fix treasury typo * lint * Update cosmJS dependency to reduce initial JS load size. (#479) Resolves #19. * Better display when user did not vote on proposal. (#478) * Swap positions of submit and preview in proposal form. (#477) * Merge development into main! (#473) * Add utils package * newline at the end of tsconfig.json * remove debugging console.log * Crispier toasts (#442) * Increased duration toasts display on screen. * Display notifications above suspense loader. * Fixed vscode eslint fixing incorrect rules, and reformatted. * Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. * Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. * Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> * Add check for connected wallet (#452) * Show second by second countdown when unstaking. (#456) * Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. * Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" * Fix formatting issue in Button.tsx. (#461) * Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. * Allow voting abstain on proposals. (#454) * Use version number from package.json. (#455) * Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> * Add missing daotoken image. (#474) * Swap positions of submit and preview in proposal form. Resolves #475 * fixup! correctly line wrap. Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> * Better empty state for new users (#449) * Empty state contract cards * Hover animation * Moved to components/ * Renamed Mystery to Empty cards * feat: improve eslint and prettier integration (#487) * New proposal status UI (#489) * chore: format and lint all sources (#493) * Redeploy Vercel. * Create proposal details card & make proposal details page responsive (#494) * Turned proposal details into card, and created details card and vote status components. * Made proposal details page responsive! * feat(dapp): add create dao field tooltips (#486) * Minor hindsight proposal status UI tweaks (#498) * Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars. * Improved passing threshold indicator language to be less prescriptive. * Added helpful status text for threshold and quorum cases for clarification purpses. * feat(dapp): add create dao field tooltips (#486) * Minor hindsight proposal status UI tweaks (#498) * Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars. * Improved passing threshold indicator language to be less prescriptive. * Added helpful status text for threshold and quorum cases for clarification purpses. Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: zeke <30676292+ezekiiel@users.noreply.github.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> Co-authored-by: Sashimi <93623541+sashimi36@users.noreply.github.com> Co-authored-by: Griko Nibras <grikomsn@live.com> Co-authored-by: bao <baoskee@users.noreply.github.com> Co-authored-by: Griko Nibras <git@griko.id>
0xekez
pushed a commit
that referenced
this pull request
Apr 18, 2022
Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. Add utils package newline at the end of tsconfig.json remove debugging console.log Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> Show second by second countdown when unstaking. (#456) Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" Fix formatting issue in Button.tsx. (#461) Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. Allow voting abstain on proposals. (#454) Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Persist description newlines on ContractView (#476) Reuse @cosmjs clients (#480) * ChainClientRouter and its integration * upd comment * pr feedback Make connect wallet and wallet display button same sizes. (#482) feat(ui): update reach tooltip styles (#485) Fix treasury typo (#488) * Fix treasury typo * lint Update cosmJS dependency to reduce initial JS load size. (#479) Resolves #19. Better display when user did not vote on proposal. (#478) Swap positions of submit and preview in proposal form. (#477) * Merge development into main! (#473) * Add utils package * newline at the end of tsconfig.json * remove debugging console.log * Crispier toasts (#442) * Increased duration toasts display on screen. * Display notifications above suspense loader. * Fixed vscode eslint fixing incorrect rules, and reformatted. * Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. * Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. * Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> * Add check for connected wallet (#452) * Show second by second countdown when unstaking. (#456) * Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. * Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" * Fix formatting issue in Button.tsx. (#461) * Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. * Allow voting abstain on proposals. (#454) * Use version number from package.json. (#455) * Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> * Add missing daotoken image. (#474) * Swap positions of submit and preview in proposal form. Resolves #475 * fixup! correctly line wrap. Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> Better empty state for new users (#449) * Empty state contract cards * Hover animation * Moved to components/ * Renamed Mystery to Empty cards feat: improve eslint and prettier integration (#487) New proposal status UI (#489) chore: format and lint all sources (#493) Redeploy Vercel. Create proposal details card & make proposal details page responsive (#494) * Turned proposal details into card, and created details card and vote status components. * Made proposal details page responsive! feat(dapp): add create dao field tooltips (#486) Minor hindsight proposal status UI tweaks (#498) * Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars. * Improved passing threshold indicator language to be less prescriptive. * Added helpful status text for threshold and quorum cases for clarification purpses. Only show time left when proposal is open. Split StakingModal into stateless and stateful components.
0xekez
added a commit
that referenced
this pull request
Apr 18, 2022
* Only show abstain clarification once people vote. * Split staking modal into stateless and statefull components. Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. Add utils package newline at the end of tsconfig.json remove debugging console.log Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> Show second by second countdown when unstaking. (#456) Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" Fix formatting issue in Button.tsx. (#461) Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. Allow voting abstain on proposals. (#454) Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Persist description newlines on ContractView (#476) Reuse @cosmjs clients (#480) * ChainClientRouter and its integration * upd comment * pr feedback Make connect wallet and wallet display button same sizes. (#482) feat(ui): update reach tooltip styles (#485) Fix treasury typo (#488) * Fix treasury typo * lint Update cosmJS dependency to reduce initial JS load size. (#479) Resolves #19. Better display when user did not vote on proposal. (#478) Swap positions of submit and preview in proposal form. (#477) * Merge development into main! (#473) * Add utils package * newline at the end of tsconfig.json * remove debugging console.log * Crispier toasts (#442) * Increased duration toasts display on screen. * Display notifications above suspense loader. * Fixed vscode eslint fixing incorrect rules, and reformatted. * Display executed proposal TX hashes with link to Mintscan (#441) * Display executed proposal TX hash in sidebar. * Added link to executed proposal TX on mintscan. * Improved user messages about tx hash. * Made TX hash loadable in case the query takes some time. * Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present. * Formatted. * Generalized copy to clipboard message. * Improve proposal template UX (#440) * Preview proposal message JSON when creating. Renamed messages to actions on proposal create page. * Recognize and display message templates on existing proposals. * Fixed spend cosmos msg detection. * Formatted. * PR fixes. * Fixed prettier lint error. * Update packages/utils/package.json Co-authored-by: Noah Saso <noahsaso@gmail.com> * Add check for connected wallet (#452) * Show second by second countdown when unstaking. (#456) * Icons package (#428) * Init 'icons' package. * Add init assets to 'icons' package. * Use Wallet from @dao-dao/icons. * Added "Add Token" Button (#458) * Added "Add Token" Button * Use "addTokenCallback" in "StarButton" * Moved "Add Token" inside "DaoTreasury" * Fix formatting issue in Button.tsx. (#461) * Disable check for staked balance at proposal creation time. (#464) Currently there is an issue with querying past chain state from before the chain halted. This makes voting on proposals created before the chain halt not possible as that check requires those queries to work. This removes that check for now. Next week, once those proposals have cleared we can re enable it. * Allow voting abstain on proposals. (#454) * Use version number from package.json. (#455) * Migrate away from Daisy UI and bring design closer to spec. (#457) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Address feedback from Sager. * Add label to DAO / Multisig name field (#470) * WIP - migrate away from Daisy UI. * Use text sizes from spec in pages covered so far. Have mostly completed: - /starred - DAO homepage - staking modal - nav bar * Proposal view working and new proposal template selection modal. * WIP - proposal voting page. * Update ProposalDetails and allow voting. * Add proposal execute button. * Add loading state to button. * Update multisig page visuals. * Fix build errors. * Updated DAO create page. * DAO create page visual improvements. * Update Multisig create page. * Remove unused component files. * Checkpoint don't commit this Zeke. * Added weeks and days to seconds formatter. * Add Token image field and update most templates. * Prompt to stake if no voting power for voting. * Address feedback from Sager. * Accent DAO / Multisig page with average color of logo (#460) * Use average color from DAO's logo as accent color. * Added colorization to multisig page. * Ran next formatter. * Fixed yarn lock URLs. * Failsafe and load page if client fails to connect when averaging color. * Add label to DAO / Multisig name field (#470) * Misc fixes. * Swap to a tooltip library that actually works. * Marketing token image & ensure sufficent contrast in accent color. * Prompt to configure keplr if installed but not configured. * Don't perform accent color check in useEffect. Pls vercel. * Final fixups from testing. * Feedback from elgorithm. * Correctly center background token images. Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> * Add missing daotoken image. (#474) * Swap positions of submit and preview in proposal form. Resolves #475 * fixup! correctly line wrap. Co-authored-by: Sagar Saija <sagarsaija@yahoo.com> Co-authored-by: Noah Saso <noahsaso@gmail.com> Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com> Co-authored-by: Joshua Van Deren <livetoscout@gmail.com> Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com> Better empty state for new users (#449) * Empty state contract cards * Hover animation * Moved to components/ * Renamed Mystery to Empty cards feat: improve eslint and prettier integration (#487) New proposal status UI (#489) chore: format and lint all sources (#493) Redeploy Vercel. Create proposal details card & make proposal details page responsive (#494) * Turned proposal details into card, and created details card and vote status components. * Made proposal details page responsive! feat(dapp): add create dao field tooltips (#486) Minor hindsight proposal status UI tweaks (#498) * Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars. * Improved passing threshold indicator language to be less prescriptive. * Added helpful status text for threshold and quorum cases for clarification purpses. Only show time left when proposal is open. Split StakingModal into stateless and stateful components. * Pre moving templates to package rollback point oh boy. * Stateless ProposalDetails. * Migrate icons to icons package. * Stateless wallet connect button. * Stateless proposal details sidebar. * Split StakingModal into stateless and stateful components. * Pre moving templates to package rollback point oh boy. * Stateless ProposalDetails. * Migrate icons to icons package. * Stateless wallet connect button. * Merge in development post force push. * Move all ContractView components to packages. * Move claims components into packages. * Improve visuals for claims pending. Co-authored-by: Noah Saso <noahsaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better empty state for new users. Pastoral imagery is known to create a calming effect.
