Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Add Token" Button #458

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Added "Add Token" Button #458

merged 3 commits into from
Apr 4, 2022

Conversation

jvanderen1
Copy link
Contributor

Issue

Resolves #312

Fix

I added a button labeled "Add Token" which can be accessed by underneath the star button:

Screen Shot 2022-04-02 at 9 21 51 PM

Remarks

  • Ideally, we should either hide or disable this button if the token is already added. However, I am not seeing a way to access this information using the Keplr SecretJS API.
  • I would also vote to remove adding a token when clicking the star button, but I left that functionality as is.

@jvanderen1 jvanderen1 requested a review from ebaker April 3, 2022 04:39
@vercel
Copy link

vercel bot commented Apr 3, 2022

@jvanderen1 is attempting to deploy a commit to the DAO DAO Team on Vercel.

To accomplish this, @jvanderen1 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

"required": [
"bank"
],
"required": ["bank"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to note that these changes were made from invoking prettier:write.

@0xekez
Copy link
Contributor

0xekez commented Apr 3, 2022

Thanks for the PR and for including the screenshot! Visually having the add token button in the top right seems a little jarring to me. How would you feel about moving it down into the treasury section? Could do something like what is in this design here with the send / request button:

image

@jvanderen1
Copy link
Contributor Author

jvanderen1 commented Apr 3, 2022

Sure thing 👌🏻. Would you like the add token button inline with both send / request?

@jvanderen1
Copy link
Contributor Author

@ezekiiel I just realized the screenshot provided was a mock and not the actual state. The PR has been updated with the new desired layout:

Screen Shot 2022-04-03 at 3 38 33 PM

I advise the designer to consider changing either the layout for "send" and "request" into a vertical flex list, or moving the "add token" button to another location . This space will become tight for 3 or more things.

I also have some thoughts on how we are styling our components. I know we are considering transitioning to twin.macro and there are some patterns I would like to implement once that work is complete (starting with Button.tsx).

@0xekez
Copy link
Contributor

0xekez commented Apr 4, 2022

This is looking really great! Will give this a review tomorrow. Thank you. :)

cc @mamimisan - this adds a second button to that treasury section. You may want to rebase your deposit work on this if you're not already too deep into the implementation.

Copy link
Contributor

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :) Thanks for breaking the treasury out into a component. :shipit:

@@ -55,7 +55,7 @@ function ButtonComponent(
const withIcon = iconBefore || iconAfter
let other = disabled ? ' disabled' : ''

if (!withIcon) other += ' truncate'
if (!withIcon) { other += ' truncate' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@0xekez 0xekez merged commit b4b4076 into development Apr 4, 2022
@0xekez 0xekez deleted the jvanderen1-312 branch April 4, 2022 08:15
0xekez added a commit that referenced this pull request Apr 9, 2022
* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>
0xekez added a commit that referenced this pull request Apr 14, 2022
* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>
@NoahSaso NoahSaso mentioned this pull request Apr 14, 2022
JakeHartnell added a commit that referenced this pull request Apr 16, 2022
* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

* Persist description newlines on ContractView (#476)

* Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

* Make connect wallet and wallet display button same sizes. (#482)

* feat(ui): update reach tooltip styles (#485)

* Fix treasury typo (#488)

* Fix treasury typo

* lint

* Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

* Better display when user did not vote on proposal. (#478)

* Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

* feat: improve eslint and prettier integration (#487)

* New proposal status UI (#489)

* chore: format and lint all sources (#493)

* Redeploy Vercel.

* Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

* feat(dapp): add create dao field tooltips (#486)

* Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

* feat(dapp): add create dao field tooltips (#486)

* Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: zeke <30676292+ezekiiel@users.noreply.github.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>
Co-authored-by: Sashimi <93623541+sashimi36@users.noreply.github.com>
Co-authored-by: Griko Nibras <grikomsn@live.com>
Co-authored-by: bao <baoskee@users.noreply.github.com>
Co-authored-by: Griko Nibras <git@griko.id>
0xekez pushed a commit that referenced this pull request Apr 18, 2022
Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

Add utils package

newline at the end of tsconfig.json

remove debugging console.log

Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

Show second by second countdown when unstaking. (#456)

Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

Fix formatting issue in Button.tsx. (#461)

Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

Allow voting abstain on proposals. (#454)

Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Persist description newlines on ContractView (#476)

Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

Make connect wallet and wallet display button same sizes. (#482)

feat(ui): update reach tooltip styles (#485)

Fix treasury typo (#488)

* Fix treasury typo

* lint

Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

Better display when user did not vote on proposal. (#478)

Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

feat: improve eslint and prettier integration (#487)

New proposal status UI (#489)

chore: format and lint all sources (#493)

Redeploy Vercel.

Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

feat(dapp): add create dao field tooltips (#486)

Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Only show time left when proposal is open.

Split StakingModal into stateless and stateful components.
0xekez added a commit that referenced this pull request Apr 18, 2022
* Only show abstain clarification once people vote.

* Split staking modal into stateless and statefull components.

Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

Add utils package

newline at the end of tsconfig.json

remove debugging console.log

Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

Show second by second countdown when unstaking. (#456)

Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

Fix formatting issue in Button.tsx. (#461)

Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

Allow voting abstain on proposals. (#454)

Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Persist description newlines on ContractView (#476)

Reuse @cosmjs clients (#480)

* ChainClientRouter and its integration

* upd comment

* pr feedback

Make connect wallet and wallet display button same sizes. (#482)

feat(ui): update reach tooltip styles (#485)

Fix treasury typo (#488)

* Fix treasury typo

* lint

Update cosmJS dependency to reduce initial JS load size. (#479)

Resolves #19.

Better display when user did not vote on proposal. (#478)

Swap positions of submit and preview in proposal form. (#477)

* Merge development into main! (#473)

* Add utils package

* newline at the end of tsconfig.json

* remove debugging console.log

* Crispier toasts (#442)

* Increased duration toasts display on screen.

* Display notifications above suspense loader.

* Fixed vscode eslint fixing incorrect rules, and reformatted.

* Display executed proposal TX hashes with link to Mintscan (#441)

* Display executed proposal TX hash in sidebar.

* Added link to executed proposal TX on mintscan.

* Improved user messages about tx hash.

* Made TX hash loadable in case the query takes some time.

* Only add link to proposal tx hash if NEXT_PUBLIC_CHAIN_TXN_URL_PREFIX present.

* Formatted.

* Generalized copy to clipboard message.

* Improve proposal template UX (#440)

* Preview proposal message JSON when creating. Renamed messages to actions on proposal create page.

* Recognize and display message templates on existing proposals.

* Fixed spend cosmos msg detection.

* Formatted.

* PR fixes.

* Fixed prettier lint error.

* Update packages/utils/package.json

Co-authored-by: Noah Saso <noahsaso@gmail.com>

* Add check for connected wallet (#452)

* Show second by second countdown when unstaking. (#456)

* Icons package (#428)

* Init 'icons' package.

* Add init assets to 'icons' package.

* Use Wallet from @dao-dao/icons.

* Added "Add Token" Button (#458)

* Added "Add Token" Button

* Use "addTokenCallback" in "StarButton"

* Moved "Add Token" inside "DaoTreasury"

* Fix formatting issue in Button.tsx. (#461)

* Disable check for staked balance at proposal creation time. (#464)

Currently there is an issue with querying past chain state from before
the chain halted. This makes voting on proposals created before the
chain halt not possible as that check requires those queries to work.

This removes that check for now. Next week, once those proposals have
cleared we can re enable it.

* Allow voting abstain on proposals. (#454)

* Use version number from package.json. (#455)

* Migrate away from Daisy UI and bring design closer to spec. (#457)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Address feedback from Sager.

* Add label to DAO / Multisig name field (#470)

* WIP - migrate away from Daisy UI.

* Use text sizes from spec in pages covered so far.

Have mostly completed:

- /starred
- DAO homepage
- staking modal
- nav bar

* Proposal view working and new proposal template selection modal.

* WIP - proposal voting page.

* Update ProposalDetails and allow voting.

* Add proposal execute button.

* Add loading state to button.

* Update multisig page visuals.

* Fix build errors.

* Updated DAO create page.

* DAO create page visual improvements.

* Update Multisig create page.

* Remove unused component files.

* Checkpoint don't commit this Zeke.

* Added weeks and days to seconds formatter.

* Add Token image field and update most templates.

* Prompt to stake if no voting power for voting.

* Address feedback from Sager.

* Accent DAO / Multisig page with average color of logo (#460)

* Use average color from DAO's logo as accent color.

* Added colorization to multisig page.

* Ran next formatter.

* Fixed yarn lock URLs.

* Failsafe and load page if client fails to connect when averaging color.

* Add label to DAO / Multisig name field (#470)

* Misc fixes.

* Swap to a tooltip library that actually works.

* Marketing token image & ensure sufficent contrast in accent color.

* Prompt to configure keplr if installed but not configured.

* Don't perform accent color check in useEffect.

Pls vercel.

* Final fixups from testing.

* Feedback from elgorithm.

* Correctly center background token images.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

* Add missing daotoken image. (#474)

* Swap positions of submit and preview in proposal form.

Resolves #475

* fixup! correctly line wrap.

Co-authored-by: Sagar Saija <sagarsaija@yahoo.com>
Co-authored-by: Noah Saso <noahsaso@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Joshua Van Deren <livetoscout@gmail.com>
Co-authored-by: ebaker <430383+ebaker@users.noreply.github.com>

Better empty state for new users (#449)

* Empty state contract cards

* Hover animation

* Moved to components/

* Renamed Mystery to Empty cards

feat: improve eslint and prettier integration (#487)

New proposal status UI (#489)

chore: format and lint all sources (#493)

Redeploy Vercel.

Create proposal details card & make proposal details page responsive (#494)

* Turned proposal details into card, and created details card and vote status components.

* Made proposal details page responsive!

feat(dapp): add create dao field tooltips (#486)

Minor hindsight proposal status UI tweaks (#498)

* Increased height of vertical bars on progress bars, added message when proposal is passing, cleaned up unnecessary classes, and removed unused label prop from vertical bars on progress bars.

* Improved passing threshold indicator language to be less prescriptive.

* Added helpful status text for threshold and quorum cases for clarification purpses.

Only show time left when proposal is open.

Split StakingModal into stateless and stateful components.

* Pre moving templates to package rollback point oh boy.

* Stateless ProposalDetails.

* Migrate icons to icons package.

* Stateless wallet connect button.

* Stateless proposal details sidebar.

* Split StakingModal into stateless and stateful components.

* Pre moving templates to package rollback point oh boy.

* Stateless ProposalDetails.

* Migrate icons to icons package.

* Stateless wallet connect button.

* Merge in development post force push.

* Move all ContractView components to packages.

* Move claims components into packages.

* Improve visuals for claims pending.

Co-authored-by: Noah Saso <noahsaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button for adding token to keplr
2 participants