-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create secondary subject page #4363
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments @joegibb
app/views/content/life-as-a-teacher/age-groups-and-specialisms/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few mini comments for you @joegibb
app/views/content/life-as-a-teacher/age-groups-and-specialisms/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary.md
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah-DfE <103052329+Sarah-DfE@users.noreply.github.com>
app/views/content/shared/qualifications-training/_get_school_experience.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a teeny change, but this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @joegibb - some comments for you!
app/views/content/life-as-a-teacher/age-groups-and-specialisms/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/shared/age-groups-and-specialisms/_teaching_send.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/shared/teaching/_progression_in_teaching.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/shared/age-groups-and-specialisms/_ages_abilities.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/shared/age-groups-and-specialisms/_teaching_send.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions based on our chat earlier, it's looking really good @joegibb!
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/age-groups-and-specialisms/secondary/_article.html.erb
Outdated
Show resolved
Hide resolved
Review app deployed to https://get-into-teaching-app-review-4363.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
https://trello.com/c/duO9bedj
Create a secondary page which is similar to the subject pages being created.