Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create secondary subject page #4363

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Nov 20, 2024

https://trello.com/c/duO9bedj

Create a secondary page which is similar to the subject pages being created.

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Nov 20, 2024
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments @joegibb

@Sarah-DfE Sarah-DfE added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Nov 25, 2024
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few mini comments for you @joegibb

Co-authored-by: Sarah-DfE <103052329+Sarah-DfE@users.noreply.github.com>
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a teeny change, but this looks good

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @joegibb - some comments for you!

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions based on our chat earlier, it's looking really good @joegibb!

Copy link

Copy link

sonarcloud bot commented Nov 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants