Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create secondary subject page #4363
base: master
Are you sure you want to change the base?
Create secondary subject page #4363
Changes from 12 commits
6fecff7
cbbf31b
50804bc
1956f7b
b327894
98ff9c0
3b49d56
8634078
4bd28a0
fae0ba0
7a22ddc
856a7b3
a587d66
f5185e4
434bfe1
1cc863b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any merit in referencing the subjects taught at each stage (possibly not and this might get too complex!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this partial be in the
qualifications-training
folder rather thanage-groups-and-specialisms
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - and far more importantly - this is almost an exact duplicate of https://github.com/DFE-Digital/get-into-teaching-app/blob/master/app/views/content/shared/qualifications-training/_check_qualifcations.html.erb which is the partial used on the subject pages
The only difference I can see is:
Having relevant A levels can show your subject knowledge, if you do not have a degree in the subject you want to teach.
Having relevant A levels can show your subject knowledge, if you do not have a degree in <%= @front_matter["subject"] %>.
I don't think the benefit of the slightly different wording outweighs having two partials to maintain?
I would suggest that rather than creating a new partial, you update the one used on the subject pages to slightly more generic ie
subject you want to teach
. I think there is still enough mention of the subject in the Quals section on the subject pages for this not to make too much difference?But do discuss with @Sarah-DfE and disagree if needed!
(Either way, this partial should not be in
age-groups-and specialisms
- the folder should relate to what the partial is about, not where it is used!)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be adding this partial (separate ticket!) to subject pages where there is not an internship?