Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build godot project on CI #63

Merged
merged 8 commits into from
May 18, 2022
Merged

Build godot project on CI #63

merged 8 commits into from
May 18, 2022

Conversation

Dreia
Copy link
Contributor

@Dreia Dreia commented May 18, 2022

This workflow outputs an Island.zip file into_ build/mods_ folder (if successful). It is meant to run on workflow dispatch, that means it creates a run button.

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Code change tested manually if not covered by automated tests
  • Pull request linked to one or more issues/stories
  • Acceptance criteria of the linked stories satisfied
  • Code change comprehended by those who approved it
  • State of target branch maintained or improved after the code change

This workflow outputs an Island.zip file into_ build/mods_ folder (if successful). It is meant to run on workflow dispatch, that means it creates a run button.
@Dreia Dreia added duplicate This issue or pull request already exists help wanted Extra attention is needed labels May 18, 2022
@Dreia Dreia requested a review from AeroStun May 18, 2022 10:37
@Dreia Dreia removed the duplicate This issue or pull request already exists label May 18, 2022
run: |
mkdir -v -p build/linux
cd $EXPORT_NAME
timeout 30s godot . --editor --no-window

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this works then you do not have to move the templates at all FYI as they are unused when just zipping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll remove that step.

@Dreia Dreia added the duplicate This issue or pull request already exists label May 18, 2022
@Dreia Dreia requested a review from RuthgerD May 18, 2022 10:38
Fixes Related issues: #61, #27
@RuthgerD
Copy link

I suggest trying this as well instead of doing the timeout thing:

godot --export-pack linux --no-window output.pck

(with linux being the export preset you have, I think you have "Linux/X11")

@Dreia Dreia self-assigned this May 18, 2022
@Dreia
Copy link
Contributor Author

Dreia commented May 18, 2022

It looks like it does nothing although the checks pass. If I export then I need to move the templates as well right ? Do I also need to get the headless version of Godot, because I think for that I really need to download the binary and set it up on PATH like you guys did.

@@ -0,0 +1,29 @@
name: Build Island.zip Artifact

on: [workflow_dispatch]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be how it was before i.e [push, pull_request]

@RuthgerD
Copy link

timeout is probably returning a non 0 exit code which is fine but the action is thinking it failed

@Dreia
Copy link
Contributor Author

Dreia commented May 18, 2022

In details we can see that the poor thing generated all the .import files and the operation seems to have worked.

@RuthgerD
Copy link

Seems like the artifact name isn't being expanded properly

@RuthgerD
Copy link

image
Looks like the mod works! nice job 👍

@Dreia
Copy link
Contributor Author

Dreia commented May 18, 2022

Thanks, should I merge then ? I can't find the file tbh so I can't check the name

@Dreia Dreia removed help wanted Extra attention is needed duplicate This issue or pull request already exists labels May 18, 2022
- name: Upload Artifact
uses: actions/upload-artifact@v1
with: # the final result should be called Island.zip
name: $EXPORT_NAME

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable expansion works different in github actions (opposed to bash) so it would be ${{ EXPORT_NAME }}

@RuthgerD
Copy link

RuthgerD commented May 18, 2022

I can't find the file tbh so I can't check the name

If you want to find the artifacts, click on the little green checkmark next to the commit and go to the details of the respective action, from there go to "Summary" and it should be easy from there.

@Dreia Dreia removed the request for review from AeroStun May 18, 2022 12:28
Copy link

@RuthgerD RuthgerD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it does what we want now, the action yml itself can be improved but not really important

Changed comments, small fixes
@Dreia Dreia merged commit 0486d3d into Finish-Line May 18, 2022
@Dreia Dreia mentioned this pull request May 18, 2022
6 tasks
@Dreia Dreia deleted the Godot-CI branch May 18, 2022 17:15
@faisal1201 faisal1201 linked an issue May 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot CI
2 participants