-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build godot project on CI #63
Conversation
This workflow outputs an Island.zip file into_ build/mods_ folder (if successful). It is meant to run on workflow dispatch, that means it creates a run button.
.github/workflows/Godot CI.yml
Outdated
run: | | ||
mkdir -v -p build/linux | ||
cd $EXPORT_NAME | ||
timeout 30s godot . --editor --no-window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this works then you do not have to move the templates at all FYI as they are unused when just zipping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll remove that step.
I suggest trying this as well instead of doing the timeout thing:
(with |
It looks like it does nothing although the checks pass. If I export then I need to move the templates as well right ? Do I also need to get the headless version of Godot, because I think for that I really need to download the binary and set it up on PATH like you guys did. |
.github/workflows/Godot CI.yml
Outdated
@@ -0,0 +1,29 @@ | |||
name: Build Island.zip Artifact | |||
|
|||
on: [workflow_dispatch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be how it was before i.e [push, pull_request]
timeout is probably returning a non 0 exit code which is fine but the action is thinking it failed |
In details we can see that the poor thing generated all the .import files and the operation seems to have worked. |
Seems like the artifact name isn't being expanded properly |
Thanks, should I merge then ? I can't find the file tbh so I can't check the name |
.github/workflows/Godot CI.yml
Outdated
- name: Upload Artifact | ||
uses: actions/upload-artifact@v1 | ||
with: # the final result should be called Island.zip | ||
name: $EXPORT_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable expansion works different in github actions (opposed to bash) so it would be ${{ EXPORT_NAME }}
If you want to find the artifacts, click on the little green checkmark next to the commit and go to the details of the respective action, from there go to "Summary" and it should be easy from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it does what we want now, the action yml itself can be improved but not really important
Changed comments, small fixes
This workflow outputs an Island.zip file into_ build/mods_ folder (if successful). It is meant to run on workflow dispatch, that means it creates a run button.
☑️ Definition of Done checklist