Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build godot project on CI" #64

Merged
merged 2 commits into from
May 18, 2022
Merged

Revert "Build godot project on CI" #64

merged 2 commits into from
May 18, 2022

Conversation

Dreia
Copy link
Contributor

@Dreia Dreia commented May 18, 2022

Reverts #63 Looks like some checks did not pass after all because of a path error.

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Code change tested manually if not covered by automated tests
  • Pull request linked to one or more issues/stories
  • Acceptance criteria of the linked stories satisfied
  • Code change comprehended by those who approved it
  • State of target branch maintained or improved after the code change

@RuthgerD
Copy link

Why?

@RuthgerD
Copy link

RuthgerD commented May 18, 2022

Seems like the last change you pushed to the previous PR about this broke it again, presumably due to the path change ? Better fix it instead of reverting it though

@Dreia
Copy link
Contributor Author

Dreia commented May 18, 2022

Yes it was the path

@Dreia Dreia added the #Sprint3 User stories for 3 label May 18, 2022
@Dreia Dreia added this to the Emulator milestone May 18, 2022
@Dreia Dreia self-assigned this May 18, 2022
@Dreia Dreia merged commit f3a5b1d into Finish-Line May 18, 2022
@Dreia Dreia deleted the revert-63-Godot-CI branch May 18, 2022 17:04
@Dreia
Copy link
Contributor Author

Dreia commented May 18, 2022

This merge closes related issue #60

@faisal1201 faisal1201 linked an issue May 29, 2022 that may be closed by this pull request
@faisal1201 faisal1201 removed this from the Emulator milestone May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#Sprint3 User stories for 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot CI
3 participants