Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI does not load when JavaScript is disabled in browser #1273

Closed
tdonohue opened this issue Jul 15, 2021 · 2 comments · Fixed by #1275
Closed

UI does not load when JavaScript is disabled in browser #1273

tdonohue opened this issue Jul 15, 2021 · 2 comments · Fixed by #1275
Assignees
Labels
bug component: SEO Search Engine Optimization high priority
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Jul 15, 2021

Describe the bug
If you turn off Javascript in your browser, the UI becomes unresponsive. No errors appear (at least not in the DevTools in the browser), but no page will load successfully.

UPDATE: I've determined this is caused by #1244 If I revert that PR, everything works.

To Reproduce
Steps to reproduce the behavior:

  1. Turn off JS in your browser tab (e.g in Chrome, go into DevTools, select "Settings" (upper right), check "Disable Javascript")
  2. Visit the demo site (any page), e.g. https://demo7.dspace.org/ in that tab. This is also reproducible when running the UI on localhost:4000 (via yarn start)

Expected behavior
For SEO purposes, the site must work (at least public pages) with Javascript disabled.

@tdonohue tdonohue added bug component: SEO Search Engine Optimization high priority labels Jul 15, 2021
@tdonohue tdonohue added this to the 7.0 milestone Jul 15, 2021
@tdonohue
Copy link
Member Author

tdonohue commented Jul 15, 2021

I've verified that the 7.0 Beta5 release worked properly. You could turn off Javascript and still interact with the site. So, this issue has been caused since Beta 5. So, some UI PR on our 7.0 board has broken server-side rendering (SSR). I'm attempting to narrow it down further.

@tdonohue
Copy link
Member Author

After further testing/debugging, I've determined the cause to be PR #1244 (created by @atarix83 ). That PR accidentally breaks SSR. If I revert that PR locally & start the UI (via yarn start), then I can run the UI with Javascript disabled.

@atarix83 or @abollini : Is there someone from 4Science that could help fix this issue? If not, we likely will need to revert that PR prior to the 7.0 release.

(As a sidenote, it'd also be good to figure out a way to avoid this in the future... we likely need e2e tests that verify that SSR is working at even a basic level. That's not necessarily required for 7.0, but we should start investigating for 7.1 to ensure a future PR doesn't accidentally break SSR.)

@atarix83 atarix83 mentioned this issue Jul 20, 2021
6 tasks
artlowel added a commit that referenced this issue Jul 22, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Feb 6, 2024
…#1273)

DSC-983 counters component maintenance

Approved-by: Davide Negretti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: SEO Search Engine Optimization high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants