#1273 no js issue #1275
Merged
#1273 no js issue #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed while logging-in with external idp" This reverts commit 73a9fe1
artlowel
requested changes
Jul 20, 2021
| @@ -18,10 +19,11 @@ export class ObjectCacheEffects { | |||
| */ | |||
| @Effect() fixTimestampsOnRehydrate = this.actions$ | |||
| .pipe(ofType(StoreActionTypes.REHYDRATE), | |||
| map(() => new ResetObjectCacheTimestampsAction(new Date().getTime())) | |||
| map(() => new ResetObjectCacheTimestampsAction(new Date().getTime())), | |||
| tap(() => this.authorizationsService.invalidateAuthorizationsRequestCache()) | |||
There was a problem hiding this comment.
I wouldn't add this to the bottom of another, unrelated effect. I'd add a separate effect that listens to the same action, with dispatch: false especially for this.
That way the effect can have a name that reflects what it does, it makes the code easier to understand, and to describe in typedocs.
There was a problem hiding this comment.
That way it can also be moved to auth.effects.ts which is likely a better fit
artlowel
approved these changes
Jul 22, 2021
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jan 26, 2024
…#1275) DSC-1484 create utility functions main Approved-by: Davide Negretti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
This PR resolves both issues mentioned previously. I've reverted the #1244 in order to fix the #1273 and then I've used a new approach to solve the #1179.
Since the #1179 issue was due to cache problem with request to
authorizationsendpoint. I've added a method to set stale all the requests to theauthorizationsendpoint when the store is rehydrated from SSR to CSRInclude guidance for how to test or review your PR.
Test both issues are sorted out.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.