Add check for samtools in the PATH of the hisatgenotype script #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
samtoolsis not in the PATH, thehisatgenotypescript runs to completion but without any output or obvious error messages.This PR adds a check to ensure that
samtoolsis in the PATH when thehisatgenotypescript is run.Note that this is separated from the samtools check in the
setup.shscript as that checks when that script is run (#31). It's conceived that samtools was available at that time (e.g. through a conda environment), but then when an end-user runs hisatgenotype they forgot to activate this same environment (I did this by accident). This PR makes sure that the program fails fast so that end-users can be notified right away.