Implement code origin support for grpc server entry spans #7942

evanchooly · 2024-11-12T17:01:12Z

What Does This Do

This updates the grpc integration to enable code origin support for grpc servers.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3109

pr-commenter · 2024-11-12T17:21:58Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1732722348	1732722725
end_time	2024-11-27T15:47:04	2024-11-27T15:53:23
git_branch	master	evanchooly/DEBUG-3109
git_commit_sha	`966ef84`	`3276467`
start_time	2024-11-27T15:45:49	2024-11-27T15:52:06

See matching parameters

	Baseline	Candidate
ci_job_id	722131361	722131361
ci_pipeline_id	50065956	50065956
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1732721714	1732721714

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-30.385µs; +35.345µs] or [-11.146%; +12.966%]	unstable [-44.159µs; +47.898µs] or [-14.078%; +15.270%]	unstable [-59318.283ns; +60309.694ns] or [-17.976%; +18.276%]	unstable [-125.814µs; +114.198µs] or [-20.557%; +18.659%]	unstable [-201.175op/s; +66.222op/s] or [-7.645%; +2.516%]
scenario:basic	same	same	same	unstable [-27.805µs; +80.371µs] or [-5.214%; +15.072%]	unstable [-96.361op/s; +224.566op/s] or [-3.854%; +8.983%]
scenario:loop	same	same	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (313.665 µs) : 266, 362
.   : milestone, 314,
basic (310.778 µs) : 300, 322
.   : milestone, 311,
loop (10.385 ms) : 10343, 10428
.   : milestone, 10385,
section candidate
noprobe (315.534 µs) : 276, 355
.   : milestone, 316,
basic (305.936 µs) : 295, 317
.   : milestone, 306,
loop (10.49 ms) : 10336, 10644
.   : milestone, 10490,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	313.665 µs [265.634 µs, 361.695 µs]
basic	310.778 µs [299.938 µs, 321.618 µs]
loop	10.385 ms [10.343 ms, 10.428 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	315.534 µs [276.248 µs, 354.821 µs]
basic	305.936 µs [295.174 µs, 316.698 µs]
loop	10.49 ms [10.336 ms, 10.644 ms]

pr-commenter · 2024-11-12T17:30:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3109
git_commit_date	1732709291	1732721714
git_commit_sha	`966ef84`	`3276467`
release_version	1.44.0-SNAPSHOT~966ef84e87	1.44.0-SNAPSHOT~3276467f1e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732724093	1732724093
ci_job_id	722131355	722131355
ci_pipeline_id	50065956	50065956
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090287
Total [baseline] (10.48 s) : 0, 10480355
Agent [candidate] (1.095 s) : 0, 1094877
Total [candidate] (10.423 s) : 0, 10422867
section appsec
Agent [baseline] (1.225 s) : 0, 1224673
Total [baseline] (10.694 s) : 0, 10693815
Agent [candidate] (1.227 s) : 0, 1226539
Total [candidate] (10.775 s) : 0, 10774566
section iast
Agent [baseline] (1.219 s) : 0, 1218551
Total [baseline] (10.899 s) : 0, 10899348
Agent [candidate] (1.235 s) : 0, 1234637
Total [candidate] (10.952 s) : 0, 10951859
section profiling
Agent [baseline] (1.317 s) : 0, 1317151
Total [baseline] (10.85 s) : 0, 10850340
Agent [candidate] (1.317 s) : 0, 1317494
Total [candidate] (10.812 s) : 0, 10811782

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.225 s	134.386 ms (12.3%)
Agent	iast	1.219 s	128.264 ms (11.8%)
Agent	profiling	1.317 s	226.864 ms (20.8%)
Total	tracing	10.48 s	-
Total	appsec	10.694 s	213.46 ms (2.0%)
Total	iast	10.899 s	418.992 ms (4.0%)
Total	profiling	10.85 s	369.985 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.227 s	131.662 ms (12.0%)
Agent	iast	1.235 s	139.761 ms (12.8%)
Agent	profiling	1.317 s	222.618 ms (20.3%)
Total	tracing	10.423 s	-
Total	appsec	10.775 s	351.699 ms (3.4%)
Total	iast	10.952 s	528.992 ms (5.1%)
Total	profiling	10.812 s	388.915 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.607 ms) : 0, 693607
BytebuddyAgent [candidate] (696.411 ms) : 0, 696411
GlobalTracer [baseline] (318.395 ms) : 0, 318395
GlobalTracer [candidate] (318.59 ms) : 0, 318590
AppSec [baseline] (54.694 ms) : 0, 54694
AppSec [candidate] (54.787 ms) : 0, 54787
Remote Config [baseline] (673.946 µs) : 0, 674
Remote Config [candidate] (681.104 µs) : 0, 681
Telemetry [baseline] (9.212 ms) : 0, 9212
Telemetry [candidate] (10.622 ms) : 0, 10622
section appsec
BytebuddyAgent [baseline] (710.128 ms) : 0, 710128
BytebuddyAgent [candidate] (712.638 ms) : 0, 712638
GlobalTracer [baseline] (314.443 ms) : 0, 314443
GlobalTracer [candidate] (314.43 ms) : 0, 314430
AppSec [baseline] (167.694 ms) : 0, 167694
AppSec [candidate] (166.55 ms) : 0, 166550
IAST [baseline] (21.192 ms) : 0, 21192
IAST [candidate] (19.141 ms) : 0, 19141
Remote Config [baseline] (651.962 µs) : 0, 652
Remote Config [candidate] (655.0 µs) : 0, 655
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (8.935 ms) : 0, 8935
section iast
BytebuddyAgent [baseline] (810.947 ms) : 0, 810947
BytebuddyAgent [candidate] (823.403 ms) : 0, 823403
GlobalTracer [baseline] (306.477 ms) : 0, 306477
GlobalTracer [candidate] (309.708 ms) : 0, 309708
AppSec [baseline] (57.508 ms) : 0, 57508
AppSec [candidate] (58.423 ms) : 0, 58423
IAST [baseline] (21.775 ms) : 0, 21775
IAST [candidate] (21.034 ms) : 0, 21034
Remote Config [baseline] (645.743 µs) : 0, 646
Remote Config [candidate] (611.87 µs) : 0, 612
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.549 ms) : 0, 7549
section profiling
BytebuddyAgent [baseline] (688.233 ms) : 0, 688233
BytebuddyAgent [candidate] (688.001 ms) : 0, 688001
GlobalTracer [baseline] (433.774 ms) : 0, 433774
GlobalTracer [candidate] (434.223 ms) : 0, 434223
AppSec [baseline] (53.766 ms) : 0, 53766
AppSec [candidate] (54.013 ms) : 0, 54013
Remote Config [baseline] (657.042 µs) : 0, 657
Remote Config [candidate] (660.19 µs) : 0, 660
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.731 ms) : 0, 7731
ProfilingAgent [baseline] (93.939 ms) : 0, 93939
ProfilingAgent [candidate] (93.671 ms) : 0, 93671
Profiling [baseline] (93.963 ms) : 0, 93963
Profiling [candidate] (93.695 ms) : 0, 93695

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098595
Total [baseline] (8.716 s) : 0, 8716184
Agent [candidate] (1.091 s) : 0, 1090979
Total [candidate] (8.685 s) : 0, 8685270
section iast
Agent [baseline] (1.226 s) : 0, 1226113
Total [baseline] (9.237 s) : 0, 9237038
Agent [candidate] (1.23 s) : 0, 1230186
Total [candidate] (9.251 s) : 0, 9250869
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1220389
Total [baseline] (9.224 s) : 0, 9223686
Agent [candidate] (1.218 s) : 0, 1218261
Total [candidate] (9.179 s) : 0, 9178764
section iast_TELEMETRY_OFF
Agent [baseline] (1.234 s) : 0, 1233655
Total [baseline] (9.245 s) : 0, 9244546
Agent [candidate] (1.218 s) : 0, 1218083
Total [candidate] (9.217 s) : 0, 9216663

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.099 s	-
Agent	iast	1.226 s	127.517 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	121.793 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.234 s	135.06 ms (12.3%)
Total	tracing	8.716 s	-
Total	iast	9.237 s	520.853 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.224 s	507.501 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.245 s	528.362 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	iast	1.23 s	139.207 ms (12.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.218 s	127.282 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.218 s	127.104 ms (11.7%)
Total	tracing	8.685 s	-
Total	iast	9.251 s	565.599 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.179 s	493.494 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.217 s	531.393 ms (6.1%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.747 ms) : 0, 699747
BytebuddyAgent [candidate] (694.441 ms) : 0, 694441
GlobalTracer [baseline] (319.89 ms) : 0, 319890
GlobalTracer [candidate] (318.513 ms) : 0, 318513
AppSec [baseline] (55.132 ms) : 0, 55132
AppSec [candidate] (54.42 ms) : 0, 54420
Remote Config [baseline] (692.631 µs) : 0, 693
Remote Config [candidate] (687.291 µs) : 0, 687
Telemetry [baseline] (9.304 ms) : 0, 9304
Telemetry [candidate] (9.135 ms) : 0, 9135
section iast
BytebuddyAgent [baseline] (816.127 ms) : 0, 816127
BytebuddyAgent [candidate] (820.181 ms) : 0, 820181
GlobalTracer [baseline] (308.715 ms) : 0, 308715
GlobalTracer [candidate] (308.487 ms) : 0, 308487
AppSec [baseline] (56.593 ms) : 0, 56593
AppSec [candidate] (58.352 ms) : 0, 58352
IAST [baseline] (22.654 ms) : 0, 22654
IAST [candidate] (21.023 ms) : 0, 21023
Remote Config [baseline] (634.389 µs) : 0, 634
Remote Config [candidate] (629.785 µs) : 0, 630
Telemetry [baseline] (7.547 ms) : 0, 7547
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.566 ms) : 0, 812566
BytebuddyAgent [candidate] (811.494 ms) : 0, 811494
GlobalTracer [baseline] (307.537 ms) : 0, 307537
GlobalTracer [candidate] (306.134 ms) : 0, 306134
AppSec [baseline] (57.743 ms) : 0, 57743
AppSec [candidate] (56.962 ms) : 0, 56962
IAST [baseline] (20.711 ms) : 0, 20711
IAST [candidate] (21.804 ms) : 0, 21804
Remote Config [baseline] (640.492 µs) : 0, 640
Remote Config [candidate] (625.199 µs) : 0, 625
Telemetry [baseline] (7.462 ms) : 0, 7462
Telemetry [candidate] (7.486 ms) : 0, 7486
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (821.589 ms) : 0, 821589
BytebuddyAgent [candidate] (810.761 ms) : 0, 810761
GlobalTracer [baseline] (310.874 ms) : 0, 310874
GlobalTracer [candidate] (306.766 ms) : 0, 306766
AppSec [baseline] (58.37 ms) : 0, 58370
AppSec [candidate] (58.093 ms) : 0, 58093
IAST [baseline] (20.693 ms) : 0, 20693
IAST [candidate] (20.559 ms) : 0, 20559
Remote Config [baseline] (650.141 µs) : 0, 650
Remote Config [candidate] (622.827 µs) : 0, 623
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.464 ms) : 0, 7464

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-27T15:44:58	2024-11-27T15:51:57
git_branch	master	evanchooly/DEBUG-3109
git_commit_date	1732709291	1732721714
git_commit_sha	`966ef84`	`3276467`
release_version	1.44.0-SNAPSHOT~966ef84e87	1.44.0-SNAPSHOT~3276467f1e
start_time	2024-11-27T15:44:44	2024-11-27T15:51:44

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732723071	1732723071
ci_job_id	722131356	722131356
ci_pipeline_id	50065956	50065956
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.072 µs) : 354, 394
.   : milestone, 374,
iast (497.99 µs) : 475, 520
.   : milestone, 498,
iast_FULL (656.045 µs) : 634, 678
.   : milestone, 656,
iast_GLOBAL (517.645 µs) : 496, 539
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (492.436 µs) : 471, 514
.   : milestone, 492,
iast_INACTIVE (459.815 µs) : 438, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (489.223 µs) : 467, 511
.   : milestone, 489,
tracing (451.433 µs) : 430, 473
.   : milestone, 451,
section candidate
no_agent (373.054 µs) : 353, 393
.   : milestone, 373,
iast (489.133 µs) : 468, 510
.   : milestone, 489,
iast_FULL (652.904 µs) : 631, 674
.   : milestone, 653,
iast_GLOBAL (514.97 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (496.098 µs) : 475, 517
.   : milestone, 496,
iast_INACTIVE (456.086 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (482.294 µs) : 461, 504
.   : milestone, 482,
tracing (448.172 µs) : 427, 469
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.072 µs [354.361 µs, 393.783 µs]	-
iast	497.99 µs [475.49 µs, 520.49 µs]	123.918 µs (33.1%)
iast_FULL	656.045 µs [634.413 µs, 677.677 µs]	281.973 µs (75.4%)
iast_GLOBAL	517.645 µs [496.347 µs, 538.943 µs]	143.573 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED	492.436 µs [471.181 µs, 513.691 µs]	118.363 µs (31.6%)
iast_INACTIVE	459.815 µs [438.268 µs, 481.363 µs]	85.743 µs (22.9%)
iast_TELEMETRY_OFF	489.223 µs [467.169 µs, 511.276 µs]	115.15 µs (30.8%)
tracing	451.433 µs [430.212 µs, 472.655 µs]	77.361 µs (20.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.054 µs [353.197 µs, 392.912 µs]	-
iast	489.133 µs [467.952 µs, 510.313 µs]	116.079 µs (31.1%)
iast_FULL	652.904 µs [631.431 µs, 674.377 µs]	279.85 µs (75.0%)
iast_GLOBAL	514.97 µs [493.762 µs, 536.178 µs]	141.916 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED	496.098 µs [474.788 µs, 517.409 µs]	123.044 µs (33.0%)
iast_INACTIVE	456.086 µs [434.962 µs, 477.211 µs]	83.032 µs (22.3%)
iast_TELEMETRY_OFF	482.294 µs [460.514 µs, 504.075 µs]	109.24 µs (29.3%)
tracing	448.172 µs [427.446 µs, 468.898 µs]	75.118 µs (20.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.754 ms) : 1730, 1778
.   : milestone, 1754,
appsec_no_iast (1.767 ms) : 1742, 1791
.   : milestone, 1767,
iast (1.511 ms) : 1488, 1533
.   : milestone, 1511,
profiling (1.55 ms) : 1525, 1575
.   : milestone, 1550,
tracing (1.489 ms) : 1465, 1513
.   : milestone, 1489,
section candidate
no_agent (1.366 ms) : 1346, 1387
.   : milestone, 1366,
appsec (1.733 ms) : 1708, 1758
.   : milestone, 1733,
appsec_no_iast (1.776 ms) : 1751, 1800
.   : milestone, 1776,
iast (1.508 ms) : 1484, 1531
.   : milestone, 1508,
profiling (1.533 ms) : 1510, 1555
.   : milestone, 1533,
tracing (1.508 ms) : 1484, 1532
.   : milestone, 1508,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.375 ms]	-
appsec	1.754 ms [1.73 ms, 1.778 ms]	398.409 µs (29.4%)
appsec_no_iast	1.767 ms [1.742 ms, 1.791 ms]	411.283 µs (30.3%)
iast	1.511 ms [1.488 ms, 1.533 ms]	155.342 µs (11.5%)
profiling	1.55 ms [1.525 ms, 1.575 ms]	195.028 µs (14.4%)
tracing	1.489 ms [1.465 ms, 1.513 ms]	133.861 µs (9.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.366 ms [1.346 ms, 1.387 ms]	-
appsec	1.733 ms [1.708 ms, 1.758 ms]	366.928 µs (26.9%)
appsec_no_iast	1.776 ms [1.751 ms, 1.8 ms]	409.545 µs (30.0%)
iast	1.508 ms [1.484 ms, 1.531 ms]	141.769 µs (10.4%)
profiling	1.533 ms [1.51 ms, 1.555 ms]	166.525 µs (12.2%)
tracing	1.508 ms [1.484 ms, 1.532 ms]	141.462 µs (10.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3109
git_commit_date	1732709291	1732721714
git_commit_sha	`966ef84`	`3276467`
release_version	1.44.0-SNAPSHOT~966ef84e87	1.44.0-SNAPSHOT~3276467f1e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732723660	1732723660
ci_job_id	722131357	722131357
ci_pipeline_id	50065956	50065956
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
appsec (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
iast (18.896 s) : 18896000, 18896000
.   : milestone, 18896000,
iast_GLOBAL (17.651 s) : 17651000, 17651000
.   : milestone, 17651000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
.   : milestone, 15622000,
appsec (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
iast (18.966 s) : 18966000, 18966000
.   : milestone, 18966000,
iast_GLOBAL (17.642 s) : 17642000, 17642000
.   : milestone, 17642000,
profiling (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,
tracing (15.213 s) : 15213000, 15213000
.   : milestone, 15213000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.001 s [15.001 s, 15.001 s]	-
appsec	14.939 s [14.939 s, 14.939 s]	-62.0 ms (-0.4%)
iast	18.896 s [18.896 s, 18.896 s]	3.895 s (26.0%)
iast_GLOBAL	17.651 s [17.651 s, 17.651 s]	2.65 s (17.7%)
profiling	15.138 s [15.138 s, 15.138 s]	137.0 ms (0.9%)
tracing	15.1 s [15.1 s, 15.1 s]	99.0 ms (0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.622 s [15.622 s, 15.622 s]	-
appsec	15.163 s [15.163 s, 15.163 s]	-459.0 ms (-2.9%)
iast	18.966 s [18.966 s, 18.966 s]	3.344 s (21.4%)
iast_GLOBAL	17.642 s [17.642 s, 17.642 s]	2.02 s (12.9%)
profiling	14.902 s [14.902 s, 14.902 s]	-720.0 ms (-4.6%)
tracing	15.213 s [15.213 s, 15.213 s]	-409.0 ms (-2.6%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3276467f1e, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.347 ms) : 2305, 2388
.   : milestone, 2347,
iast (2.106 ms) : 2053, 2159
.   : milestone, 2106,
iast_GLOBAL (2.143 ms) : 2090, 2196
.   : milestone, 2143,
profiling (1.985 ms) : 1942, 2028
.   : milestone, 1985,
tracing (1.934 ms) : 1894, 1975
.   : milestone, 1934,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.351 ms) : 2309, 2392
.   : milestone, 2351,
iast (2.109 ms) : 2056, 2163
.   : milestone, 2109,
iast_GLOBAL (2.154 ms) : 2100, 2207
.   : milestone, 2154,
profiling (2.441 ms) : 2195, 2688
.   : milestone, 2441,
tracing (1.944 ms) : 1902, 1985
.   : milestone, 1944,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	2.347 ms [2.305 ms, 2.388 ms]	871.969 µs (59.1%)
iast	2.106 ms [2.053 ms, 2.159 ms]	631.694 µs (42.8%)
iast_GLOBAL	2.143 ms [2.09 ms, 2.196 ms]	668.587 µs (45.3%)
profiling	1.985 ms [1.942 ms, 2.028 ms]	510.503 µs (34.6%)
tracing	1.934 ms [1.894 ms, 1.975 ms]	459.821 µs (31.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.351 ms [2.309 ms, 2.392 ms]	879.624 µs (59.8%)
iast	2.109 ms [2.056 ms, 2.163 ms]	638.401 µs (43.4%)
iast_GLOBAL	2.154 ms [2.1 ms, 2.207 ms]	682.663 µs (46.4%)
profiling	2.441 ms [2.195 ms, 2.688 ms]	970.176 µs (66.0%)
tracing	1.944 ms [1.902 ms, 1.985 ms]	472.594 µs (32.1%)

...5/src/main/java/datadog/trace/instrumentation/grpc/server/MethodHandlersInstrumentation.java

.../agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java

evanchooly · 2024-11-21T15:58:48Z

@amarziali @jpbempel this ready for a (hopefully) final review when you get a chance.

amarziali

The PR looks ok. There are minor changes to address (I left very small comments). I did not find any better alternative to instrument less types nor to avoid using reflection

...5/src/main/java/datadog/trace/instrumentation/grpc/server/MethodHandlersInstrumentation.java

…race/instrumentation/grpc/server/MethodHandlersInstrumentation.java Co-authored-by: Andrea Marziali <andrea.marziali@datadoghq.com>

github-actions · 2024-12-05T12:46:12Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

evanchooly requested a review from amarziali November 12, 2024 17:01

jpbempel reviewed Nov 14, 2024

View reviewed changes

...5/src/main/java/datadog/trace/instrumentation/grpc/server/MethodHandlersInstrumentation.java Outdated Show resolved Hide resolved

.../agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java Outdated Show resolved Hide resolved

evanchooly force-pushed the evanchooly/DEBUG-3109 branch from daaa592 to 6128078 Compare November 20, 2024 15:52

evanchooly marked this pull request as ready for review November 20, 2024 17:23

evanchooly requested review from a team as code owners November 20, 2024 17:23

evanchooly requested review from jpbempel and removed request for a team November 20, 2024 17:23

jpbempel approved these changes Nov 22, 2024

View reviewed changes

Add code origin support to the grpc server integration

7c2e3a1

evanchooly force-pushed the evanchooly/DEBUG-3109 branch from f2703f6 to 7c2e3a1 Compare November 26, 2024 18:09

amarziali reviewed Nov 27, 2024

View reviewed changes

...5/src/main/java/datadog/trace/instrumentation/grpc/server/MethodHandlersInstrumentation.java Show resolved Hide resolved

evanchooly and others added 3 commits November 27, 2024 08:52

Update dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/t…

1edc7df

…race/instrumentation/grpc/server/MethodHandlersInstrumentation.java Co-authored-by: Andrea Marziali <andrea.marziali@datadoghq.com>

PR feedback updates

9f4aaa8

wrap advice in a try/catch

3276467

amarziali approved these changes Nov 27, 2024

View reviewed changes

evanchooly merged commit f7a6771 into master Nov 27, 2024
103 checks passed

evanchooly deleted the evanchooly/DEBUG-3109 branch November 27, 2024 16:31

github-actions bot added this to the 1.44.0 milestone Nov 27, 2024

jpbempel added comp: debugger Dynamic Instrumentation type: enhancement labels Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement code origin support for grpc server entry spans #7942

Implement code origin support for grpc server entry spans #7942

evanchooly commented Nov 12, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 12, 2024 •

edited

Loading

pr-commenter bot commented Nov 12, 2024 •

edited

Loading

evanchooly commented Nov 21, 2024

amarziali left a comment

github-actions bot commented Dec 5, 2024

Implement code origin support for grpc server entry spans #7942

Implement code origin support for grpc server entry spans #7942

Conversation

evanchooly commented Nov 12, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 12, 2024 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Nov 12, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

evanchooly commented Nov 21, 2024

amarziali left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

evanchooly commented Nov 12, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 12, 2024 •

edited

Loading

pr-commenter bot commented Nov 12, 2024 •

edited

Loading