Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark JUnit 5 setup and teardown action spans as failed if there is an error #8033

Merged

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 28, 2024

What Does This Do

If there is an error in a traced JUnit 5 setup or teardown action, corresponding span is marked as failed and error details are attached to it.

Contributor Checklist

Jira ticket: SDTEST-970

@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/junit-5-failed-setup-teardown
git_commit_date 1732796662 1732796849
git_commit_sha 7f91a3e 9cea5f7
release_version 1.44.0-SNAPSHOT~7f91a3ecc2 1.44.0-SNAPSHOT~9cea5f7abf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732799308 1732799308
ci_job_id 722764484 722764484
ci_pipeline_id 50103398 50103398
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1104157
Total [baseline] (8.666 s) : 0, 8665759
Agent [candidate] (1.103 s) : 0, 1102952
Total [candidate] (8.719 s) : 0, 8719469
section iast
Agent [baseline] (1.221 s) : 0, 1220949
Total [baseline] (9.212 s) : 0, 9211968
Agent [candidate] (1.232 s) : 0, 1231991
Total [candidate] (9.238 s) : 0, 9238207
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.236 s) : 0, 1235825
Total [baseline] (9.235 s) : 0, 9234800
Agent [candidate] (1.219 s) : 0, 1219295
Total [candidate] (9.23 s) : 0, 9230391
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1211905
Total [baseline] (9.171 s) : 0, 9170611
Agent [candidate] (1.214 s) : 0, 1213735
Total [candidate] (9.181 s) : 0, 9181089
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.104 s -
Agent iast 1.221 s 116.792 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.236 s 131.668 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.212 s 107.748 ms (9.8%)
Total tracing 8.666 s -
Total iast 9.212 s 546.208 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.235 s 569.041 ms (6.6%)
Total iast_TELEMETRY_OFF 9.171 s 504.851 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent iast 1.232 s 129.039 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 116.342 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.214 s 110.782 ms (10.0%)
Total tracing 8.719 s -
Total iast 9.238 s 518.737 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.23 s 510.922 ms (5.9%)
Total iast_TELEMETRY_OFF 9.181 s 461.619 ms (5.3%)
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (703.379 ms) : 0, 703379
BytebuddyAgent [candidate] (702.65 ms) : 0, 702650
GlobalTracer [baseline] (319.218 ms) : 0, 319218
GlobalTracer [candidate] (320.963 ms) : 0, 320963
AppSec [baseline] (55.347 ms) : 0, 55347
AppSec [candidate] (55.498 ms) : 0, 55498
Remote Config [baseline] (696.639 µs) : 0, 697
Remote Config [candidate] (692.457 µs) : 0, 692
Telemetry [baseline] (11.6 ms) : 0, 11600
Telemetry [candidate] (9.204 ms) : 0, 9204
section iast
BytebuddyAgent [baseline] (812.545 ms) : 0, 812545
BytebuddyAgent [candidate] (821.349 ms) : 0, 821349
GlobalTracer [baseline] (307.237 ms) : 0, 307237
GlobalTracer [candidate] (308.627 ms) : 0, 308627
AppSec [baseline] (58.18 ms) : 0, 58180
AppSec [candidate] (57.735 ms) : 0, 57735
IAST [baseline] (21.004 ms) : 0, 21004
IAST [candidate] (21.992 ms) : 0, 21992
Remote Config [baseline] (638.476 µs) : 0, 638
Remote Config [candidate] (657.844 µs) : 0, 658
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.677 ms) : 0, 7677
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (822.653 ms) : 0, 822653
BytebuddyAgent [candidate] (811.834 ms) : 0, 811834
GlobalTracer [baseline] (311.156 ms) : 0, 311156
GlobalTracer [candidate] (306.6 ms) : 0, 306600
AppSec [baseline] (58.395 ms) : 0, 58395
AppSec [candidate] (58.116 ms) : 0, 58116
IAST [baseline] (21.377 ms) : 0, 21377
IAST [candidate] (20.811 ms) : 0, 20811
Remote Config [baseline] (666.505 µs) : 0, 667
Remote Config [candidate] (628.939 µs) : 0, 629
Telemetry [baseline] (7.635 ms) : 0, 7635
Telemetry [candidate] (7.495 ms) : 0, 7495
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.334 ms) : 0, 806334
BytebuddyAgent [candidate] (807.877 ms) : 0, 807877
GlobalTracer [baseline] (305.681 ms) : 0, 305681
GlobalTracer [candidate] (306.176 ms) : 0, 306176
AppSec [baseline] (57.646 ms) : 0, 57646
AppSec [candidate] (57.82 ms) : 0, 57820
IAST [baseline] (20.488 ms) : 0, 20488
IAST [candidate] (20.213 ms) : 0, 20213
Remote Config [baseline] (627.648 µs) : 0, 628
Remote Config [candidate] (607.72 µs) : 0, 608
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.301 ms) : 0, 7301
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087808
Total [baseline] (10.43 s) : 0, 10429845
Agent [candidate] (1.089 s) : 0, 1088794
Total [candidate] (10.476 s) : 0, 10475999
section appsec
Agent [baseline] (1.226 s) : 0, 1225842
Total [baseline] (10.731 s) : 0, 10731415
Agent [candidate] (1.226 s) : 0, 1226210
Total [candidate] (10.723 s) : 0, 10723428
section iast
Agent [baseline] (1.22 s) : 0, 1219815
Total [baseline] (10.936 s) : 0, 10936044
Agent [candidate] (1.233 s) : 0, 1233145
Total [candidate] (11.089 s) : 0, 11089283
section profiling
Agent [baseline] (1.315 s) : 0, 1314741
Total [baseline] (10.828 s) : 0, 10827749
Agent [candidate] (1.314 s) : 0, 1314247
Total [candidate] (10.9 s) : 0, 10899630
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.226 s 138.034 ms (12.7%)
Agent iast 1.22 s 132.007 ms (12.1%)
Agent profiling 1.315 s 226.933 ms (20.9%)
Total tracing 10.43 s -
Total appsec 10.731 s 301.57 ms (2.9%)
Total iast 10.936 s 506.199 ms (4.9%)
Total profiling 10.828 s 397.904 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent appsec 1.226 s 137.415 ms (12.6%)
Agent iast 1.233 s 144.351 ms (13.3%)
Agent profiling 1.314 s 225.453 ms (20.7%)
Total tracing 10.476 s -
Total appsec 10.723 s 247.428 ms (2.4%)
Total iast 11.089 s 613.284 ms (5.9%)
Total profiling 10.9 s 423.63 ms (4.0%)
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.239 ms) : 0, 692239
BytebuddyAgent [candidate] (693.853 ms) : 0, 693853
GlobalTracer [baseline] (317.292 ms) : 0, 317292
GlobalTracer [candidate] (318.13 ms) : 0, 318130
AppSec [baseline] (54.798 ms) : 0, 54798
AppSec [candidate] (54.658 ms) : 0, 54658
Remote Config [baseline] (665.438 µs) : 0, 665
Remote Config [candidate] (703.854 µs) : 0, 704
Telemetry [baseline] (9.102 ms) : 0, 9102
Telemetry [candidate] (7.712 ms) : 0, 7712
section appsec
BytebuddyAgent [baseline] (711.595 ms) : 0, 711595
BytebuddyAgent [candidate] (712.469 ms) : 0, 712469
GlobalTracer [baseline] (314.654 ms) : 0, 314654
GlobalTracer [candidate] (314.372 ms) : 0, 314372
AppSec [baseline] (167.429 ms) : 0, 167429
AppSec [candidate] (167.911 ms) : 0, 167911
IAST [baseline] (19.183 ms) : 0, 19183
IAST [candidate] (19.182 ms) : 0, 19182
Remote Config [baseline] (651.687 µs) : 0, 652
Remote Config [candidate] (645.726 µs) : 0, 646
Telemetry [baseline] (8.177 ms) : 0, 8177
Telemetry [candidate] (7.471 ms) : 0, 7471
section iast
BytebuddyAgent [baseline] (812.596 ms) : 0, 812596
BytebuddyAgent [candidate] (822.537 ms) : 0, 822537
GlobalTracer [baseline] (306.752 ms) : 0, 306752
GlobalTracer [candidate] (309.23 ms) : 0, 309230
AppSec [baseline] (57.996 ms) : 0, 57996
AppSec [candidate] (57.22 ms) : 0, 57220
IAST [baseline] (20.662 ms) : 0, 20662
IAST [candidate] (22.05 ms) : 0, 22050
Remote Config [baseline] (623.592 µs) : 0, 624
Remote Config [candidate] (635.343 µs) : 0, 635
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.529 ms) : 0, 7529
section profiling
BytebuddyAgent [baseline] (687.401 ms) : 0, 687401
BytebuddyAgent [candidate] (687.562 ms) : 0, 687562
GlobalTracer [baseline] (432.622 ms) : 0, 432622
GlobalTracer [candidate] (432.047 ms) : 0, 432047
AppSec [baseline] (53.733 ms) : 0, 53733
AppSec [candidate] (53.568 ms) : 0, 53568
Remote Config [baseline] (673.29 µs) : 0, 673
Remote Config [candidate] (655.423 µs) : 0, 655
Telemetry [baseline] (7.659 ms) : 0, 7659
Telemetry [candidate] (7.695 ms) : 0, 7695
ProfilingAgent [baseline] (93.626 ms) : 0, 93626
ProfilingAgent [candidate] (93.691 ms) : 0, 93691
Profiling [baseline] (93.649 ms) : 0, 93649
Profiling [candidate] (93.715 ms) : 0, 93715
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-28T12:36:12 2024-11-28T12:43:11
git_branch master nikita-tkachenko/junit-5-failed-setup-teardown
git_commit_date 1732796662 1732796849
git_commit_sha 7f91a3e 9cea5f7
release_version 1.44.0-SNAPSHOT~7f91a3ecc2 1.44.0-SNAPSHOT~9cea5f7abf
start_time 2024-11-28T12:35:59 2024-11-28T12:42:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732798145 1732798145
ci_job_id 722764485 722764485
ci_pipeline_id 50103398 50103398
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.766 ms) : 1741, 1790
.   : milestone, 1766,
appsec_no_iast (1.742 ms) : 1717, 1767
.   : milestone, 1742,
iast (1.48 ms) : 1457, 1503
.   : milestone, 1480,
profiling (1.543 ms) : 1516, 1569
.   : milestone, 1543,
tracing (1.499 ms) : 1474, 1524
.   : milestone, 1499,
section candidate
no_agent (1.367 ms) : 1347, 1388
.   : milestone, 1367,
appsec (1.744 ms) : 1719, 1769
.   : milestone, 1744,
appsec_no_iast (1.745 ms) : 1721, 1769
.   : milestone, 1745,
iast (1.495 ms) : 1472, 1518
.   : milestone, 1495,
profiling (1.561 ms) : 1536, 1585
.   : milestone, 1561,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.339 ms, 1.377 ms] -
appsec 1.766 ms [1.741 ms, 1.79 ms] 407.48 µs (30.0%)
appsec_no_iast 1.742 ms [1.717 ms, 1.767 ms] 383.889 µs (28.3%)
iast 1.48 ms [1.457 ms, 1.503 ms] 122.132 µs (9.0%)
profiling 1.543 ms [1.516 ms, 1.569 ms] 184.562 µs (13.6%)
tracing 1.499 ms [1.474 ms, 1.524 ms] 141.016 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.347 ms, 1.388 ms] -
appsec 1.744 ms [1.719 ms, 1.769 ms] 376.798 µs (27.6%)
appsec_no_iast 1.745 ms [1.721 ms, 1.769 ms] 377.845 µs (27.6%)
iast 1.495 ms [1.472 ms, 1.518 ms] 127.447 µs (9.3%)
profiling 1.561 ms [1.536 ms, 1.585 ms] 193.552 µs (14.2%)
tracing 1.483 ms [1.458 ms, 1.508 ms] 115.825 µs (8.5%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.039 µs) : 352, 392
.   : milestone, 372,
iast (490.694 µs) : 469, 512
.   : milestone, 491,
iast_FULL (649.475 µs) : 628, 671
.   : milestone, 649,
iast_GLOBAL (519.967 µs) : 498, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (487.756 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (443.421 µs) : 423, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (479.479 µs) : 458, 501
.   : milestone, 479,
tracing (450.416 µs) : 429, 472
.   : milestone, 450,
section candidate
no_agent (369.412 µs) : 350, 389
.   : milestone, 369,
iast (490.838 µs) : 470, 512
.   : milestone, 491,
iast_FULL (648.613 µs) : 627, 670
.   : milestone, 649,
iast_GLOBAL (523.568 µs) : 500, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (486.479 µs) : 465, 508
.   : milestone, 486,
iast_INACTIVE (452.708 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (480.235 µs) : 458, 503
.   : milestone, 480,
tracing (451.76 µs) : 430, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.039 µs [351.907 µs, 392.171 µs] -
iast 490.694 µs [469.246 µs, 512.142 µs] 118.655 µs (31.9%)
iast_FULL 649.475 µs [627.829 µs, 671.121 µs] 277.436 µs (74.6%)
iast_GLOBAL 519.967 µs [497.724 µs, 542.209 µs] 147.927 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 487.756 µs [466.441 µs, 509.07 µs] 115.716 µs (31.1%)
iast_INACTIVE 443.421 µs [422.964 µs, 463.877 µs] 71.381 µs (19.2%)
iast_TELEMETRY_OFF 479.479 µs [457.777 µs, 501.181 µs] 107.44 µs (28.9%)
tracing 450.416 µs [428.529 µs, 472.302 µs] 78.376 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.412 µs [349.81 µs, 389.013 µs] -
iast 490.838 µs [469.577 µs, 512.1 µs] 121.427 µs (32.9%)
iast_FULL 648.613 µs [626.995 µs, 670.231 µs] 279.201 µs (75.6%)
iast_GLOBAL 523.568 µs [500.299 µs, 546.837 µs] 154.157 µs (41.7%)
iast_HARDCODED_SECRET_DISABLED 486.479 µs [465.182 µs, 507.777 µs] 117.068 µs (31.7%)
iast_INACTIVE 452.708 µs [431.006 µs, 474.41 µs] 83.296 µs (22.5%)
iast_TELEMETRY_OFF 480.235 µs [457.879 µs, 502.591 µs] 110.823 µs (30.0%)
tracing 451.76 µs [430.254 µs, 473.266 µs] 82.349 µs (22.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/junit-5-failed-setup-teardown
git_commit_date 1732796662 1732796849
git_commit_sha 7f91a3e 9cea5f7
release_version 1.44.0-SNAPSHOT~7f91a3ecc2 1.44.0-SNAPSHOT~9cea5f7abf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732798850 1732798850
ci_job_id 722764486 722764486
ci_pipeline_id 50103398 50103398
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.339 ms) : 2298, 2381
.   : milestone, 2339,
iast (2.089 ms) : 2036, 2141
.   : milestone, 2089,
iast_GLOBAL (2.124 ms) : 2071, 2177
.   : milestone, 2124,
profiling (1.963 ms) : 1920, 2005
.   : milestone, 1963,
tracing (1.925 ms) : 1884, 1965
.   : milestone, 1925,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.335 ms) : 2294, 2377
.   : milestone, 2335,
iast (2.081 ms) : 2029, 2133
.   : milestone, 2081,
iast_GLOBAL (2.127 ms) : 2074, 2180
.   : milestone, 2127,
profiling (1.953 ms) : 1911, 1995
.   : milestone, 1953,
tracing (1.925 ms) : 1885, 1965
.   : milestone, 1925,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.339 ms [2.298 ms, 2.381 ms] 870.921 µs (59.3%)
iast 2.089 ms [2.036 ms, 2.141 ms] 620.395 µs (42.3%)
iast_GLOBAL 2.124 ms [2.071 ms, 2.177 ms] 655.971 µs (44.7%)
profiling 1.963 ms [1.92 ms, 2.005 ms] 494.521 µs (33.7%)
tracing 1.925 ms [1.884 ms, 1.965 ms] 456.689 µs (31.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.335 ms [2.294 ms, 2.377 ms] 868.807 µs (59.2%)
iast 2.081 ms [2.029 ms, 2.133 ms] 614.512 µs (41.9%)
iast_GLOBAL 2.127 ms [2.074 ms, 2.18 ms] 660.001 µs (45.0%)
profiling 1.953 ms [1.911 ms, 1.995 ms] 486.199 µs (33.2%)
tracing 1.925 ms [1.885 ms, 1.965 ms] 458.442 µs (31.3%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~9cea5f7abf, baseline=1.44.0-SNAPSHOT~7f91a3ecc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.741 s) : 14741000, 14741000
.   : milestone, 14741000,
appsec (14.749 s) : 14749000, 14749000
.   : milestone, 14749000,
iast (19.109 s) : 19109000, 19109000
.   : milestone, 19109000,
iast_GLOBAL (17.675 s) : 17675000, 17675000
.   : milestone, 17675000,
profiling (15.567 s) : 15567000, 15567000
.   : milestone, 15567000,
tracing (14.876 s) : 14876000, 14876000
.   : milestone, 14876000,
section candidate
no_agent (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
appsec (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
iast (18.844 s) : 18844000, 18844000
.   : milestone, 18844000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
.   : milestone, 17945000,
profiling (14.758 s) : 14758000, 14758000
.   : milestone, 14758000,
tracing (15.123 s) : 15123000, 15123000
.   : milestone, 15123000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.741 s [14.741 s, 14.741 s] -
appsec 14.749 s [14.749 s, 14.749 s] 8.0 ms (0.1%)
iast 19.109 s [19.109 s, 19.109 s] 4.368 s (29.6%)
iast_GLOBAL 17.675 s [17.675 s, 17.675 s] 2.934 s (19.9%)
profiling 15.567 s [15.567 s, 15.567 s] 826.0 ms (5.6%)
tracing 14.876 s [14.876 s, 14.876 s] 135.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.955 s [14.955 s, 14.955 s] -
appsec 14.994 s [14.994 s, 14.994 s] 39.0 ms (0.3%)
iast 18.844 s [18.844 s, 18.844 s] 3.889 s (26.0%)
iast_GLOBAL 17.945 s [17.945 s, 17.945 s] 2.99 s (20.0%)
profiling 14.758 s [14.758 s, 14.758 s] -197.0 ms (-1.3%)
tracing 15.123 s [15.123 s, 15.123 s] 168.0 ms (1.1%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review November 28, 2024 14:12
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner November 28, 2024 14:12
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 3ad344d into master Nov 28, 2024
104 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/junit-5-failed-setup-teardown branch November 28, 2024 14:12
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 28, 2024
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Dec 16, 2024
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.49.0` -> `2.50.0` |
|
[com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.48.0` -> `2.49.0` |
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.82.0` -> `6.83.0` |
|
[com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`3.20.7` -> `3.21.0` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.24.3` -> `2.25.1` |
|
[com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.48.0` -> `2.49.0` |
| [com.google.api:gax](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.58.0` -> `2.59.0` |
|
[com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin)
| plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` ->
`2.6.1` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.43.0` -> `1.44.1` |
| [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.43.0` -> `1.44.1` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.32` -> `2.29.34` |
| [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava)
([source](https://github.com/aws/aws-sdk-java)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` ->
`1.12.780` |
| [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava)
([source](https://github.com/aws/aws-sdk-java)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` ->
`1.12.780` |
|
[com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava)
([source](https://github.com/aws/aws-sdk-java)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` ->
`1.12.780` |
| [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava)
([source](https://github.com/aws/aws-sdk-java)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` ->
`1.12.780` |

---

### Release Notes

<details>
<summary>googleapis/sdk-platform-java
(com.google.api.grpc:proto-google-common-protos)</summary>

###
[`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14)

##### Features

- Add experimental S2A integration in client libraries grpc transport
([#&#8203;3326](googleapis/sdk-platform-java#3326))
([1138ca6](googleapis/sdk-platform-java@1138ca6))
- enable selective generation based on service config include list
([#&#8203;3323](googleapis/sdk-platform-java#3323))
([0cddadb](googleapis/sdk-platform-java@0cddadb))
- introduce `java.time` to java-core
([#&#8203;3330](googleapis/sdk-platform-java#3330))
([f202c3b](googleapis/sdk-platform-java@f202c3b))
- Update Gapic-Generator to generate libraries using `java.time` methods
([#&#8203;3321](googleapis/sdk-platform-java#3321))
([b21c9a4](googleapis/sdk-platform-java@b21c9a4))

##### Bug Fixes

- Fix flaky test
ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart
([#&#8203;3335](googleapis/sdk-platform-java#3335))
([e73740d](googleapis/sdk-platform-java@e73740d))
- httpjson callables to trace attempts (started, failed)
([#&#8203;3300](googleapis/sdk-platform-java#3300))
([15a64ee](googleapis/sdk-platform-java@15a64ee))
- instantiate GaxProperties at build time to ensure we get the protobuf
version
([#&#8203;3365](googleapis/sdk-platform-java#3365))
([bb2a3be](googleapis/sdk-platform-java@bb2a3be))
- protobuf version not always getting set in headers
([#&#8203;3322](googleapis/sdk-platform-java#3322))
([7f6e470](googleapis/sdk-platform-java@7f6e470))
- use BuildKit instead of legacy builder to build the Hermetic Build
images
([#&#8203;3338](googleapis/sdk-platform-java#3338))
([222fb45](googleapis/sdk-platform-java@222fb45))

##### Dependencies

- update google auth library dependencies to v1.30.0
([#&#8203;3367](googleapis/sdk-platform-java#3367))
([a31c682](googleapis/sdk-platform-java@a31c682))
- update grpc dependencies to v1.68.1
([#&#8203;3240](googleapis/sdk-platform-java#3240))
([c8e3941](googleapis/sdk-platform-java@c8e3941))

##### Documentation

- fix list num
([#&#8203;3356](googleapis/sdk-platform-java#3356))
([b7d6296](googleapis/sdk-platform-java@b7d6296))
- **hermetic-build:** indicate usage of Docker Buildkit in development
guide
([#&#8203;3337](googleapis/sdk-platform-java#3337))
([01e742d](googleapis/sdk-platform-java@01e742d))
- modify hermetic build docs
([#&#8203;3331](googleapis/sdk-platform-java#3331))
([25023af](googleapis/sdk-platform-java@25023af))

</details>

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13)

##### Features

- Add Metrics host for built in metrics
([#&#8203;3519](googleapis/java-spanner#3519))
([4ed455a](googleapis/java-spanner@4ed455a))
- Add opt-in for using multiplexed sessions for blind writes
([#&#8203;3540](googleapis/java-spanner#3540))
([216f53e](googleapis/java-spanner@216f53e))
- Add UUID in Spanner TypeCode enum
([41f83dc](googleapis/java-spanner@41f83dc))
- Introduce java.time variables and methods
([#&#8203;3495](googleapis/java-spanner#3495))
([8a7d533](googleapis/java-spanner@8a7d533))
- **spanner:** Support multiplexed session for Partitioned operations
([#&#8203;3231](googleapis/java-spanner#3231))
([4501a3e](googleapis/java-spanner@4501a3e))
- Support 'set local' for retry_aborts_internally
([#&#8203;3532](googleapis/java-spanner#3532))
([331942f](googleapis/java-spanner@331942f))

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.51.0
([41f83dc](googleapis/java-spanner@41f83dc))

##### Dependencies

- Update sdk platform java dependencies
([#&#8203;3549](googleapis/java-spanner#3549))
([6235f0f](googleapis/java-spanner@6235f0f))

</details>

<details>
<summary>googleapis/java-logging
(com.google.cloud:google-cloud-logging)</summary>

###
[`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13)

##### Features

- Introduce `java.time` methods
([#&#8203;1729](googleapis/java-logging#1729))
([323eb33](googleapis/java-logging@323eb33))

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.51.0
([04d8868](googleapis/java-logging@04d8868))

##### Dependencies

- Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0
([#&#8203;1638](googleapis/java-logging#1638))
([7e007d4](googleapis/java-logging@7e007d4))
- Update sdk platform java dependencies
([#&#8203;1736](googleapis/java-logging#1736))
([88b4cdf](googleapis/java-logging@88b4cdf))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.51.0
([106ee4d](googleapis/java-datastore@106ee4d))

##### Dependencies

- Update sdk platform java dependencies
([#&#8203;1685](googleapis/java-datastore#1685))
([4372350](googleapis/java-datastore@4372350))

###
[`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11)

##### Features

- Introduce `java.time` methods and variables
([#&#8203;1671](googleapis/java-datastore#1671))
([5a78a80](googleapis/java-datastore@5a78a80))

##### Dependencies

- Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0
([#&#8203;1605](googleapis/java-datastore#1605))
([5c6a678](googleapis/java-datastore@5c6a678))

##### Documentation

- Update gapic upgrade installation instructions
([#&#8203;1677](googleapis/java-datastore#1677))
([b3fbfcc](googleapis/java-datastore@b3fbfcc))

</details>

<details>
<summary>autonomousapps/dependency-analysis-android-gradle-plugin
(com.autonomousapps.dependency-analysis)</summary>

###
[`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261)

-   \[Fix]: `superClassName` can be null (Object has no superclass).

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1):
1.44.1

##### Components

##### Continuous Integration Visibility

- 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks
([#&#8203;8089](DataDog/dd-trace-java#8089) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

###
[`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0):
1.44.0

##### Known Issues

> \[!WARNING]\
> This release contains a known issue that causes failures when using
Test Optimization to trace JUnit 5 tests in a Maven project where Maven
Surefire is configured with `forkCount` > 1.
> The issue is fixed in v1.44.1

##### Breaking Changes

> \[!WARNING]\
> Support for `X-Forwarded` header is dropped from default client IP
resolution.
> It can still be re-activated using the
`dd.trace.client-ip-header=x-forwarded` system property, or the
`DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See
[#&#8203;7946](DataDog/dd-trace-java#7946).

##### Components

##### Application Security Management (IAST)

- ✨ Set unexpected IAST exceptions to debug log level
([#&#8203;8044](DataDog/dd-trace-java#8044) -
[@&#8203;smola](https://github.com/smola))
- ✨ Increase IAST propagation to StringBuffer subSequence
([#&#8203;8038](DataDog/dd-trace-java#8038) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Increase IAST propagation to StringBuilder subSequence
([#&#8203;8026](DataDog/dd-trace-java#8026) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Add IAST propagation to String valueOf
([#&#8203;8013](DataDog/dd-trace-java#8013) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Increase IAST propagation to StringBuilder append
([#&#8203;8010](DataDog/dd-trace-java#8010) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Expand SSRF support in IAST to apache-httpclient-5 and
apache-httpasyncclient-4
([#&#8203;7920](DataDog/dd-trace-java#7920) -
[@&#8203;Mariovido](https://github.com/Mariovido))

##### Build & Tooling

- ✨ Generate Muzzle classes for Groovy instrumentations
([#&#8203;8004](DataDog/dd-trace-java#8004) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

##### Continuous Integration Visibility

- ✨ Support distributed traces in tests
([#&#8203;8078](DataDog/dd-trace-java#8078) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Implement fail-fast tests ordering for JUnit 5
([#&#8203;8055](DataDog/dd-trace-java#8055) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Mark JUnit 5 setup and teardown action spans as failed if
there is an error
([#&#8203;8033](DataDog/dd-trace-java#8033) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Add tracing of setup and teardown actions in JUnit 4
([#&#8203;8030](DataDog/dd-trace-java#8030) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))

##### Crash tracking

- ✨ Improve crash tracking install logging
([#&#8203;8045](DataDog/dd-trace-java#8045) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

##### Data Streams Monitoring

- 🐛 Add Data Streams support in AWS SQS without raw message delivery
([#&#8203;8071](DataDog/dd-trace-java#8071) -
[@&#8203;piochelepiotr](https://github.com/piochelepiotr))
- ✨ Add new tag for enabled products / features to DSM
checkpoints
([#&#8203;8051](DataDog/dd-trace-java#8051) -
[@&#8203;kr-igor](https://github.com/kr-igor))
- 💡 Instrument self hosted Kafka connectors
([#&#8203;7959](DataDog/dd-trace-java#7959) -
[@&#8203;piochelepiotr](https://github.com/piochelepiotr))

##### Dynamic Instrumentation

- ✨ Add Micronaut 4 support for code origin for spans
([#&#8203;8039](DataDog/dd-trace-java#8039) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Refactor probe matching for methods
([#&#8203;8021](DataDog/dd-trace-java#8021) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Update the CodeOriginProbe fingerprint to not rely on a
stack walk
([#&#8203;8016](DataDog/dd-trace-java#8016) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- ✨ Implement code origin support for grpc server entry spans
([#&#8203;7942](DataDog/dd-trace-java#7942) -
[@&#8203;evanchooly](https://github.com/evanchooly))

##### GraalVM native-image

- 🐛 Update Graal build-time instrumentation config for
TracePropagationStyle
([#&#8203;8065](DataDog/dd-trace-java#8065) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- 🐛 Fix NoClassDefFoundError: Could not initialize class
DDSpanLink$EncoderHolder in Graal native-image
([#&#8203;8036](DataDog/dd-trace-java#8036) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🐛🧹 Fix native-image generation of reactive applications
([#&#8203;8012](DataDog/dd-trace-java#8012) -
[@&#8203;mcculls](https://github.com/mcculls))

##### OpenTracing

- 🧹 Custom ScopeManagers are deprecated and will be removed in a
future release of dd-trace-ot
([#&#8203;8058](DataDog/dd-trace-java#8058) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Tracer core

- ✨🧪 Service naming: split by jee deployment
([#&#8203;8064](DataDog/dd-trace-java#8064) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Exclude jboss mdb proxies from instrumenting
([#&#8203;8061](DataDog/dd-trace-java#8061) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add a built-in trace interceptor for keeping traces
depending of their latency
([#&#8203;8040](DataDog/dd-trace-java#8040) -
[@&#8203;cecile75](https://github.com/cecile75))
- 💡 Introduce marker mechanism for eagerly initializing helpers
([#&#8203;8028](DataDog/dd-trace-java#8028) -
[@&#8203;mcculls](https://github.com/mcculls))
- 💡 Add JSON component
([#&#8203;7973](DataDog/dd-trace-java#7973) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨⚠️ Remove support for X-Forwarded in client IP
resolution
([#&#8203;7946](DataDog/dd-trace-java#7946) -
[@&#8203;smola](https://github.com/smola))

##### Instrumentations

##### Apache HttpComponents

- ✨ Expand SSRF support in IAST to apache-httpclient-5 and
apache-httpasyncclient-4
([#&#8203;7920](DataDog/dd-trace-java#7920) -
[@&#8203;Mariovido](https://github.com/Mariovido))

##### gRPC instrumentation

- 🐛 Use lower priorities for grpc server errors
([#&#8203;8043](DataDog/dd-trace-java#8043) -
[@&#8203;amarziali](https://github.com/amarziali))

##### JDBC instrumentation

- ✨ Add trace injection for prepared statements in Postgres
([#&#8203;7940](DataDog/dd-trace-java#7940) -
[@&#8203;nenadnoveljic](https://github.com/nenadnoveljic))

##### JMS instrumentation

- 🐛 Protect mdb from instrumenting multiple time the same event
([#&#8203;8062](DataDog/dd-trace-java#8062) -
[@&#8203;amarziali](https://github.com/amarziali))

##### Kafka instrumentation

- 💡 Instrument self hosted Kafka connectors
([#&#8203;7959](DataDog/dd-trace-java#7959) -
[@&#8203;piochelepiotr](https://github.com/piochelepiotr))

##### OpenTelemetry instrumentation

- 🐛 Support using OpenTelemetry Event API inside `@WithSpan`
annotated method
([#&#8203;8019](DataDog/dd-trace-java#8019) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Reactor instrumentation

- 🐛🧹 Fix native-image generation of reactive applications
([#&#8203;8012](DataDog/dd-trace-java#8012) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Spring instrumentation

- 🐛 Avoid double instrumenting lambdas on latest spring scheduling
([#&#8203;8005](DataDog/dd-trace-java#8005) -
[@&#8203;amarziali](https://github.com/amarziali))

##### All other instrumentations

- 🐛 Twilio: allow service name flattening
([#&#8203;8025](DataDog/dd-trace-java#8025) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Instrument Mulesoft 4.5.0+
([#&#8203;7981](DataDog/dd-trace-java#7981) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

<details>
<summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary>

###
[`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11)

[Compare
Source](aws/aws-sdk-java@1.12.779...1.12.780)

#### **Amazon Simple Storage Service**

-   ### Bugfixes
- AWS SDK for Java 1.x now includes additional validation for Amazon S3
client APIs to handle scenarios where an empty string ('') is passed as
the key argument to the following operations: PutObject, DeleteObject,
ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging,
GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold,
GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent,
SetObjectRetention, GetObjectRetention, AbortMultipartUpload,
CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart,
RestoreObjectV2, and RestoreObject. The SDK will validate the key
argument and throw an exception if it is an empty string, ensuring
correct and expected behavior.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants