Skip incompatible services on ARM64 yarn services
#2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 3.83 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2868 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 317 317
Lines 11303 11303
Branches 33 33
=======================================
Hits 10081 10081
Misses 1222 1222 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jbertran
force-pushed
the
jbertran/local-yarn-services-on-m1
branch
from
ad9070e
to
3d17f54
Compare
jbertran
force-pushed
the
jbertran/local-yarn-services-on-m1
branch
from
3d17f54
to
d7b65c1
Compare
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
jbertran
force-pushed
the
jbertran/local-yarn-services-on-m1
branch
from
d7b65c1
to
f1bdcf2
Compare
Qard
approved these changes
Mar 6, 2023
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some libraries relying on native modules will not compile on ARM64:
couchbaseis missing an ARM64configdirectory 1oracledbstill does not support it because first party client libraries are not available 2grpcis EoL and does not support ARM64 3We skip these services such that
yarn servicesstill succeeds and installs all other dependencies.1 couchbase/couchnode#106
2 oracle/node-oracledb#1349
3 grpc/grpc-node#1880 (comment)
Motivation
This allows developers to confidently run tests unrelated to the 3 services above knowing that the script succeeded.
Plugin Checklist
Additional Notes