Add Mac M1 arm64 Support #106
Conversation
|
Hey @pstuart, Thanks for the PR! As soon as you've signed the CLA on Gerrit, I'll get this merged in. Cheers, Brett |
|
I believe I have, but initially the link to new-agreement just came up blank, but did find the individual agreement and signed that. If you can confirm it is signed, that would be great. |
This reverts commit 0820205.
|
Anything I can do to get this merged? It's blocking my productivity on my team with new Mac M1s |
|
Hey @pstuart , Can you confirm that the email mentioned in the Robot's comment is attached to your Gerrit account? Cheers, Brett |
|
Yes, the second one is. |
|
I think the issues is with Gerrit and its github token auth. It doesn't import the email address. I manually added and verified my email address in Gerrit. Maybe that will help. |
|
But I see nothing beyond that I have accepted the individual agreement. Not sure what I should be looking for TBH. |
Yeah, this is likely it and now @brett19 might need to poke something. It's not so much that there is an issue with the token auth as it is that Github doesn't pass along identifying details like email address. They want the user to put in that info if they want to share it, so we end up needing to ask for it. It's that classic spectrum between security/privacy and user convenience. :) |
|
Hey @pstuart , Can you check this page for your email: Cheers, Brett |
|
Email is now set there, but still stuck in this lala land. honestly, I've given up and forked this so I can move on with my project. Hopefully you guys can sort this out with your requirements but its a lot to jump through for copying and renaming a folder. |
|
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement. Keep in mind that the emails we are seeing on the commits are: Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed. ::SDKBOT/PR:no_cla |
|
Thanks @pstuart, I'll take a look at why the bot is being finicky. Usually the email and CLA is all that's needed, it looks like something has gone awry though. Thanks for the pull request! |
|
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement. Keep in mind that the emails we are seeing on the commits are: Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed. ::SDKBOT/PR:no_cla |
|
Just wanted to check in and see if you were able to sort this out? I really don't care if someone else can just do the task and recreate the pull request. This is preventing anyone on a mac m1 to use your software and it is such a simple fix. |
|
Hey @pstuart, I think the Gerrit issue is related to the fact that the pull request contains multiple commits from multiple different email addresses. In the meantime, I've created a change-set that effectively covers the same change here: Cheers, Brett |
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
Some libraries relying on native modules will not compile on ARM64: * couchbase is missing an ARM64 `config` directory [1] * oracledb still does not support it because first party client libraries are not available [2] * grpc is EoL and does not support ARM64 [3] We skip these services such that `yarn services` still succeeds and installs all other dependencies. [1] couchbase/couchnode#106 [2] oracle/node-oracledb#1349 [3] grpc/grpc-node#1880 (comment)
This change allows for Mac M1 chipsets based on arm64 technology to build the code during an NPM install process while using native apple code