i#2626 fp/simd encode: Add support for vector and scalar FMUL. #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the encoding scheme introduced in #2811. Everything expect the tests are auto-generated now. Change-Id: I0cb18af8aabf121417404e83d262745e1bbd0a8f
derekbruening
approved these changes
Mar 23, 2018
core/arch/aarch64/instr_create.h
Outdated
| @@ -47,18 +47,33 @@ | |||
| */ | |||
| #define FSZ_HALF 1 | |||
|
|
|||
| /** | |||
| * Operand indication half-precision floating point vector elements. | |||
There was a problem hiding this comment.
s/indication/indicating/
Maybe also:
s/elements./elements for the other operands of the containing instruction./
core/arch/aarch64/instr_create.h
Outdated
| /** | ||
| * Used in an additional immediate source operand to a vector operation, denotes | ||
| * single-precision floating point vector elements. See \ref sec_IR_AArch64. | ||
| */ | ||
| #define FSZ_SINGLE 2 | ||
|
|
||
| /** | ||
| * Operand indication single-precision floating point vector elements. |
core/arch/aarch64/instr_create.h
Outdated
| /** | ||
| * Used in an additional immediate source operand to a vector operation, denotes | ||
| * double-precision floating point vector elements. See \ref sec_IR_AArch64. | ||
| */ | ||
| #define FSZ_DOUBLE 3 | ||
|
|
||
| /** | ||
| * Operand indication double-precision floating point vector elements. |
core/arch/aarch64/instr_create.h
Outdated
| * \param Rd output register | ||
| * \param Rm input register | ||
| * \param Rn input register | ||
| * \param width vector element width as immediate |
There was a problem hiding this comment.
nit: All 4 of these are nicer as complete sentences: "The output register.", etc.
Maybe for the width you could reference OPND_CREATE_DOUBLE() + the other 2 (just trying to imagine what would make it easy for users).
Change-Id: Ice1681292607aa9cc267a187bfe1d5b96719e54f
|
Done, thanks @derekbruening ! |
fhahn
added a commit
that referenced
this pull request
Apr 24, 2018
This patch adds encoding & decoding support for most arithmetic FP Neon instructions. The structure of the generated macros and tests follows the style of #2896. codec.txt contains comments if not all encodings of an instruction are supported yet. Also missing are the Arm v8.3-a FCADD and FCMLA instructions, because their rotation arguments require a bit of special handling to get nice macros. Issue #2626 Change-Id: I8c3a8ac3e03d9b466c1872ed5382639b746092b2
fhahn
added a commit
that referenced
this pull request
Apr 25, 2018
) This patch adds encoding & decoding support for most arithmetic FP Neon instructions. The structure of the generated macros and tests follows the style of #2896. codec.txt contains comments if not all encodings of an instruction are supported yet. Also missing are the Arm v8.3-a FCADD and FCMLA instructions, because their rotation arguments require a bit of special handling to get nice macros. Issue #2626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the encoding scheme introduced in #2811. It also adds INSTR_CREATE_ macros and related tests.
Everything expect the tests are auto-generated now.
Issue: #2626
Change-Id: I0cb18af8aabf121417404e83d262745e1bbd0a8f