Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2051] Utilities, Scripts, Workflow Audits #2094

Merged
merged 7 commits into from
Nov 17, 2023

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Nov 16, 2023

Broken out of #2068

Description

This is a full-pass update to some of the supporting files for EDMC. Primarily, these contain logic overhauls to the files. These updates are intended to optimize existing code, update older Python 2 style code to more updated standards, and increase readability and compatibility.

This also includes development requirements updates and a simplification of the winsparkle pull process.

Type of change

  • Rewrite of Existing Code

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Multiple install runs, clean installs, self-updates, and others made to confirm functionality, including under a variety of existing pre-install situations.
  • All PyTest tests pass

@Rixxan Rixxan self-assigned this Nov 16, 2023
@Rixxan Rixxan added code cleanup Cleaning up code dependencies Pull requests that update a dependency file labels Nov 16, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Nov 16, 2023
scripts/find_localised_strings.py Outdated Show resolved Hide resolved
scripts/find_localised_strings.py Outdated Show resolved Hide resolved
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C1701D C1701D merged commit 27dba61 into EDCD:develop Nov 17, 2023
1 check passed
@C1701D C1701D deleted the enhancement/2051/docs-workflows-utils branch November 17, 2023 00:49
@Rixxan Rixxan linked an issue Dec 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Existing Code - Non Breaking Updates
2 participants