Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Pass Logic Audit #2068

Closed
wants to merge 54 commits into from
Closed

First Pass Logic Audit #2068

wants to merge 54 commits into from

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Aug 25, 2023

Description

Contains the first pass of a major SemVer-compliant logic overhaul to excise some of the remaining Python 2 code and optimize the existing Python to start to take advantage of new features and PEP8 optimal paths. This should not break any existing installs or the public API, though further testing is in order.

Also includes previous updates which include the option to open the log folder (previously merged) and add the ability to start EDMC minimized by passing command arguments.

Full Changes:

  • Huge Logic Overhaul
  • EDMC Can be minimized on start by passing the --start_min argument.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Rewrite of Existing Code

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Multiple install runs, clean installs, self-updates, and others made to confirm functionality, including under a variety of existing pre-install situations.
  • All PyTest tests pass
  • Tested by the EDMC Internal Alpha Group and initial bugs fixed.

Rixxan added 30 commits August 4, 2023 00:44
@Rixxan
EDCD#2051 Remove Unneeded object calls
51ad16c
@Rixxan
EDCD#2051 Update 3 More Files
9f57113
@Rixxan
EDCD#2051 3 More Files
b568a61
@Rixxan
EDCD#2051 Another 3 Files
82266d6 
Why am I doing it this way? Because this is probably going to break something and I'd like to get it down to 3 files.
@Rixxan
EDCD#2051 And another 3!
d6efcf7
@Rixxan
EDCD#2051 Drei Gläser
919dbaf
@Rixxan
EDCD#2051 One... Two... FIVE
7711374
@Rixxan
EDCD#2051 Another three
ee1820c 
Going to need to look at Monitor more carefully.
@Rixxan
EDCD#2051 Being brave... doing 5 files first pass
d8b1c70
@Rixxan
EDCD#2051 And then there were five
aa4d831
@Rixxan
EDCD#2051 First Pass Penultimate
d45c690
@Rixxan
EDCD#2051 Last 4, also cleans up auth page
2f550f0
@Rixxan
EDCD#2051 Revert Subprocess Change
30ccbc3 
Breaks frozen but not script version? WTF?
@Rixxan
Merge branch 'main' into enhancement/2051/logic-audit
ab44b1f
@Rixxan
EDCD#2051 Inara pass
636ce7c
@Rixxan
EDCD#2051 Make MyPy Happy
5bcec55
@Rixxan
EDCD#2051 Other Core Plugin Pass
bb22c4c
@Rixxan
EDCD#2051 Other Core Plugin Pass
49fca9f
@Rixxan
Merge branch 'enhancement/2051/logic-audit' of https://github.com/Hul…
b779f6d 
…lSeals/EDMarketConnector into enhancement/2051/logic-audit
@Rixxan
EDCD#2051 Update Scripts, Config
4bc9871
@Rixxan
EDCD#2051 Update Docstrings
74eadce
@Rixxan
EDCD#2051 Begin Test Updates
56f7c65
@Rixxan
EDCD#2051 Finish 6 files
e36f3c6
@Rixxan
EDCD#2051 Update Union Usage
e1e0fff
@Rixxan
EDCD#2051 A few more ready for testing
9331dd0 
Avoids touching Theme too much for now.
@Rixxan
EDCD#2051 Another Set
4877f8f
@Rixxan
EDCD#2051 Disable MyPy for Now
14477d1
@Rixxan
EDCD#2051 Audit EDMC main GUI
5442dd1
@Rixxan
EDCD#2051 A Bunch More Files
46023e3
@Rixxan
[Minor] Flake8, eat your heart out
5d3eeb4
@Rixxan Rixxan added help wanted code cleanup Cleaning up code labels Aug 25, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Aug 25, 2023
@Rixxan Rixxan requested a review from C1701D August 25, 2023 21:01
@Rixxan Rixxan self-assigned this Aug 25, 2023
Rixxan added 2 commits August 25, 2023 17:41
@Rixxan
EDCD#2051 Update MyPy Ignores
b2427ed 
Add some missing ones, remove some no-longer needed ones. Also updates type hints.
@Rixxan
2051 Apparently not all of them were incorrect to Windows
3d82a46
Rixxan
Rixxan commented Aug 26, 2023
View reviewed changes
scripts/mypy-all.sh Outdated Show resolved Hide resolved
C1701D
C1701D reviewed Sep 19, 2023
View reviewed changes
config/__init__.py Outdated Show resolved Hide resolved
config/linux.py Outdated Show resolved Hide resolved
config/windows.py Outdated Show resolved Hide resolved
config/windows.py Outdated Show resolved Hide resolved
dashboard.py Outdated Show resolved Hide resolved
plugins/coriolis.py Outdated Show resolved Hide resolved
@Rixxan Rixxan force-pushed the enhancement/2051/logic-audit branch from 04cf0c2 to 0f17c09 Compare September 20, 2023 00:10
@Rixxan Rixxan force-pushed the enhancement/2051/logic-audit branch from 0f17c09 to 2056199 Compare September 20, 2023 00:17
@Rixxan Rixxan marked this pull request as draft October 19, 2023 21:24
@Rixxan
Copy link
Contributor Author

Rixxan commented Oct 19, 2023

Breaking this apart into composite parts.

@Rixxan Rixxan changed the base branch from main to develop October 19, 2023 21:43
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this pull request Oct 19, 2023
@Rixxan
[2051] Core Plugin Audit
2c803d7 
Broken out of EDCD#2068
This was referenced Oct 19, 2023
Merged
Merged
@Rixxan Rixxan closed this Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
Merged
Merged
@Rixxan Rixxan mentioned this pull request Dec 1, 2023
Merged
@Rixxan Rixxan linked an issue Dec 1, 2023 that may be closed by this pull request
Audit Existing Code - Non Breaking Updates #2051
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C1701D C1701D C1701D left review comments

Assignees

@Rixxan Rixxan

Labels
code cleanup Cleaning up code help wanted
Projects
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.

Audit Existing Code - Non Breaking Updates
2 participants
@Rixxan @C1701D