Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2051] First Pass Remaining Files #2102

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Dec 1, 2023

Description

The last of the supporting files for EDMC. This will (to my knowledge) complete a first-pass run on all the EDMC files.

The focus here is to retire outdated typing hints, improve overall readability, and implement minor pythonic improvements.

Derived from #2068.

Type of change

  • Rewrite of Existing Code
  • Addition of new features

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests of installation, operation, and building on the developer's machine
  • All PyTest tests pass

@Rixxan Rixxan added the code cleanup Cleaning up code label Dec 1, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Dec 1, 2023
@Rixxan Rixxan requested a review from C1701D December 1, 2023 02:35
@Rixxan Rixxan self-assigned this Dec 1, 2023
It's not a refactor if I don't accidentally nuke a lang comment
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C1701D C1701D merged commit 14319d0 into EDCD:develop Dec 1, 2023
1 check passed
@C1701D C1701D deleted the enhancement/2051/remainders branch December 1, 2023 03:07
@Rixxan Rixxan linked an issue Dec 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Existing Code - Non Breaking Updates
2 participants