Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Existing Code - Non Breaking Updates #2051

Closed
Rixxan opened this issue Aug 4, 2023 · 0 comments · Fixed by #2083, #2094, #2097, #2098 or #2100
Closed

Audit Existing Code - Non Breaking Updates #2051

Rixxan opened this issue Aug 4, 2023 · 0 comments · Fixed by #2083, #2094, #2097, #2098 or #2100
Assignees
@Rixxan @C1701D
Labels
enhancement Staged Feature Complete and in Testing for Next Release
Milestone
5.10.0

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Aug 4, 2023 •
edited
Loading

Describe the enhancement

As part of the new maintainers taking on EDMC, the existing code as it is should be audited and see what in-place improvements can be made to the existing flow and logic in a non-api breaking way. Changes under this issue might include:

  • Import orders
  • Usage of f-strings, improper logic (else's after returns, etc), and other PEP8 nits or minors
  • Cleanup of in-line comments and in-code documentation
  • Non-Function-Breaking updates to function logic
  • Analysis of current checks and tools

Changes such as the location of files and top-level imports, or other major breaking changes, should not be considered under this issue.
@Rixxan Rixxan added this to the 5.9.3 milestone Aug 4, 2023
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Remove Unneeded object calls
51ad16c
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Update 3 More Files
9f57113
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 3 More Files
b568a61
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Another 3 Files
82266d6 
Why am I doing it this way? Because this is probably going to break something and I'd like to get it down to 3 files.
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 And another 3!
d6efcf7
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Drei Gläser
919dbaf
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 One... Two... FIVE
7711374
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Another three
ee1820c 
Going to need to look at Monitor more carefully.
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Being brave... doing 5 files first pass
d8b1c70
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 And then there were five
aa4d831
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 First Pass Penultimate
d45c690
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 4, 2023
@Rixxan
EDCD#2051 Last 4, also cleans up auth page
2f550f0
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 6, 2023
@Rixxan
EDCD#2051 Revert Subprocess Change
30ccbc3 
Breaks frozen but not script version? WTF?
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Inara pass
636ce7c
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Make MyPy Happy
5bcec55
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Other Core Plugin Pass
bb22c4c
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Other Core Plugin Pass
49fca9f
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Update Scripts, Config
4bc9871
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 10, 2023
@Rixxan
EDCD#2051 Update Docstrings
74eadce
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 Begin Test Updates
56f7c65
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 Finish 6 files
e36f3c6
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 Update Union Usage
e1e0fff
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 A few more ready for testing
9331dd0 
Avoids touching Theme too much for now.
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 Another Set
4877f8f
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 11, 2023
@Rixxan
EDCD#2051 Disable MyPy for Now
14477d1
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 12, 2023
@Rixxan
EDCD#2051 Audit EDMC main GUI
5442dd1
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 12, 2023
@Rixxan
EDCD#2051 A Bunch More Files
46023e3
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 12, 2023
@Rixxan
EDCD#2051 Second Pass Plugins
1ba119b
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 12, 2023
@Rixxan
EDCD#2051 Black Run
e2f4dbc 
Oh lawd he comin'
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 15, 2023
@Rixxan
EDCD#2051 Retire Ship.p
62e883e
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 15, 2023
@Rixxan
EDCD#2051 Outfitting.py
6df71c2
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 16, 2023
@Rixxan
EDCD#2051 Final First Pass + Retire More Pickles
1af1d6f
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 16, 2023
@Rixxan
EDCD#2051 Revert Bad Refactor
84ab112 
As Expected, This One Didn't Work.
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 16, 2023
@Rixxan @C1701D
EDCD#2051 More Graceful Monitoring
5105d20 
Co-Authored-By: Phoebe <40956085+C1701D@users.noreply.github.com>
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 17, 2023
@Rixxan @C1701D
EDCD#2051 Update Category Check
8e01b45 
Co-Authored-By: Phoebe <40956085+C1701D@users.noreply.github.com>
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 23, 2023
@Rixxan
EDCD#2051 ReRefactor Monitor
d5108bd
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 23, 2023
@Rixxan
EDCD#2051 Revert Overzealousness
27eed80
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 24, 2023
@Rixxan
EDCD#2051 EDCD#1379 Respect Minimized Start
c9f8818
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 25, 2023
@Rixxan
EDCD#2051 We are Borg. We are not Self.
90893f0
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 25, 2023
@Rixxan
EDCD#2051 Revert Unneeded Assignment
d20c281
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Aug 25, 2023
@Rixxan
EDCD#2051 Update MyPy Ignores
b2427ed 
Add some missing ones, remove some no-longer needed ones. Also updates type hints.
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Sep 19, 2023
@Rixxan
EDCD#2051 First Pass Checks
dea3a95
@Rixxan Rixxan linked a pull request Nov 10, 2023 that will close this issue
[2051] Config Files Audit #2084
Merged
@Rixxan Rixxan removed a link to a pull request Dec 1, 2023
[2051] Config Files Audit #2084
Merged
This was linked to pull requests Dec 1, 2023
First Pass Logic Audit #2068
Closed
[2051] Core Plugin Audit #2083
Merged
[2051] Utilities, Scripts, Workflow Audits #2094
Merged
[2051] Update Supporting Files #2097
Merged
[2051] Convert Pickle to Json #2098
Merged
[2051] Additional Core Files #2100
Merged
[2051] First Pass Remaining Files #2102
Merged
@Rixxan Rixxan added the Staged Feature Complete and in Testing for Next Release label Dec 1, 2023
@Rixxan Rixxan closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rixxan Rixxan

@C1701D C1701D

Labels
enhancement Staged Feature Complete and in Testing for Next Release
Projects
None yet
Milestone
5.10.0
2 participants
@Rixxan @C1701D