Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Update to PSY 0.22 #56

Merged
merged 114 commits into from
Jul 14, 2020
Merged

Update to PSY 0.22 #56

merged 114 commits into from
Jul 14, 2020

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented May 15, 2020

Once PSY test files are updated we need to make a list of getter function from the static injection device data and avoid get_voltage(get_bus(get_static(dynamic))) or p_ref = get_activepower(get_static(dynamic)

@jd-lara jd-lara self-assigned this Jul 11, 2020
@jd-lara jd-lara requested a review from rodrigomha July 11, 2020 01:19
@jd-lara jd-lara marked this pull request as ready for review July 11, 2020 01:19
@jd-lara jd-lara changed the title WIP Update to PSY 0.19 Update to PSY 0.22 Jul 11, 2020
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #56 into master will increase coverage by 17.02%.
The diff coverage is 96.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #56       +/-   ##
===========================================
+ Coverage   75.25%   92.28%   +17.02%     
===========================================
  Files          30       44       +14     
  Lines        1075     1827      +752     
===========================================
+ Hits          809     1686      +877     
+ Misses        266      141      -125     
Impacted Files Coverage Δ
src/LITS.jl 100.00% <ø> (ø)
...itialization/inverter_components/init_converter.jl 0.00% <0.00%> (ø)
src/models/device.jl 100.00% <ø> (ø)
src/models/generator_models/pss_models.jl 100.00% <ø> (+84.61%) ⬆️
src/models/generator_models/shaft_models.jl 100.00% <ø> (ø)
src/models/system.jl 78.18% <66.66%> (-21.82%) ⬇️
src/base/file_system.jl 80.00% <80.00%> (ø)
src/base/simulation_initialization.jl 83.78% <83.78%> (ø)
src/base/simulation.jl 84.07% <90.90%> (-10.35%) ⬇️
src/initialization/generator_components/init_tg.jl 96.61% <96.61%> (ø)
... and 43 more

PSY.get_V_ref(value::PSY.AVRFixed) = value.Vf
PSY.set_V_ref!(value::PSY.AVRFixed, val::Float64) = value.Vf = val

get_V_ref_control(value::PSY.DynamicGenerator) = PSY.get_V_ref(PSY.get_avr(value))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create these functions on PSY.

@jd-lara jd-lara merged commit 40c2440 into master Jul 14, 2020
@jd-lara jd-lara deleted the jd/update_test_files branch July 16, 2020 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants