-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for older frameworks/Add support for newer frameworks #45
Comments
see also #41 |
supporting netstandare1.2 on SqlServer requires supporting it on Data too, but Data depends on System.Data.Odbc and System.Configuration.ConfigurationManager, which are supported on netstandard2.0 and higher. So this would be impossible. |
tsahi
added a commit
that referenced
this issue
Feb 5, 2021
tsahi
added a commit
that referenced
this issue
Feb 5, 2021
remove conditional compilation of code which isn't in Data anymore. remove System.Data.Odbc package from Data since we target netcoreapp2.1, which includes OleDb, compile the System.Data.Common\*.cs files only for netstandard2.0 add netcoreapp2.1 to Data.OleDb, replace 3.0 with 3.1 include System.Data.OleDb package in netcoreapp2.1 #45
tsahi
added a commit
that referenced
this issue
Feb 5, 2021
…but only for netstandard target. on other targets this is not compiled. code and comment cleanup #45
tsahi
added a commit
that referenced
this issue
Feb 19, 2021
tsahi
added a commit
that referenced
this issue
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Following the discussion at #38, we still support old frameworks that went out of support. We should remove support for these frameworks, which will let us remove dependency on older NuGet Packages.
on the other hand, adding direct support for newer frameworks will let us add support for ADO.NET providers we don't currently support on all frameworks.
Describe the solution you'd like
We currently support the following frameworks directly:
As a result, we support OleDb from netcoreapp3.0, although it's available for netcoreapp2.1.
I suggest we:
Additional context
These are the End Of Support dates for .NET Core versions, from the Microsoft web site:
As we can see, support for .NET Core 2.0 and 2.2 is long overdue, and .NET Core 3.0 also recently went out of support.
Support for .NET Framework 4.5 ended January 12, 2016, and is replaced with version 4.5.2.
The text was updated successfully, but these errors were encountered: