Deploy Checklist: New Expensify 2024-07-08

[github-actions]

Release Version: 9.0.5-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Display submitted message in report action #41040
• Client side pagination gap detection #41962
• Feat/Dupe detection review fields #42503
• Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036
• Fix action button width, disable sorting by Taxes #43140
• fix: not found page when select draft policy #43153
• [Travel] Bring back refactored AddressPage #43348
• Add workspace upgrade flow #43822
• [No QA] Enable no-unsafe-assignment eslint rule #44003
• [Details Revamp] Remove the Three Dot Menu on Affected Reports #44025
• perf: improve native apps startup #44068
• fix: QBO - Confirmation page still shows tag field when all subtags are disabled. #44221
• [Unapprove] Add unapprove feature to approved reports  #44229
• Fix crashes when saving 0 as custom tag name #44391
• Feature: Implement the policy report field delete flow #44493
• One-expense-report old chat messages stays in chat  #44529
• [NoQA] Patch 98 #44551
• [Pending / Scanning] Fix Optimistic ReportID for Instant submit / No Approvers #44612
• correct logic of from and to for narrow layout in Shared in Search #44658
• [#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input  #44661
• [Details Revamp] Allow Editing Report Title from Details Page #44671
• fix: dismiss violation action in review duplication feat #44711
• [#Wave-Control: Add NetSuite] Settings Configuration in NewDot: Advanced List #44723
• [No QA] Update react-navigation StrictMode patch to work also for native apps #44726
• Disable newly added workspace member row if the personal detail is optimistic #44734
• set initial system chat message for LHN preview #44738
• [#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743
• Implementing NetSuite Sync #44759
• [No QA]: Workspace Feed - Initial card page #44770
• Remove dupe attributes in type SearchReport #44791
• Hide disabled actions from main secondary interaction (right click/long tap) report action context menu for System chats #44808
• fix: list not scrolling to the linked report action #44819
• cleanup: don't run through containsOnlyEmojis for an empty string #44822
• fix RHP animation on Safari #44840
• [No QA] Adding email to usermetadata object #44842
• [NoQA] chore: bump onyx to 2.0.55 #44847
• remove GBP as a currency for the subscription page #44858
• [NoQA] Fix eslint on main #44867
• fix: Category - Disabled parent category is not grayed out in the list. #44875
• Fix tab highlight for Expensify card list #44893
• Add new read commands for the workspace profile and initial settings pages - v2 #44902
• fix: Web - Chat - Notification preferences RHP does not animate smoothly. #44934
• fix: Attachment - Wrong video playback speed is highlighted. #44935
• [ImgBot] Optimize images #44938
• Correctly return early for CHANGEFIELD #44944
• Fix missing title and details in report details page #44973
• [CP Staging] fix: Country field reverts to the previous selection #44981
• fix: Navigate to details page after updating report title  #44988
• [CP Staging] Show Unapprove button only for expense reports & not in transaction thread header if > 1 transaction #45049
• Fix OfflineWithFeedback in WorkspaceViewTagsPage #45068
• [CP Staging] Revert "fix: No option to add receipt when submitting to someone" #45081
• [CP Stating] fix: app crashes when open the transaction thread report #45084
• [CP Staging] Revert "fix: Country field reverts to the previous selection" #45121
• [CP Staging] Expense - No option to cancel payment for paid expense as 3-dot menu is removed #45130

Deploy Blockers:

• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Search - The Select all checbox is not checked when all the expenses are checked #44801
• [HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice #44818
• [$250] Delay in showing LHN and not found page in report screen when switching between bottom tabs #44949
• [$250] Address - Country field reverts to the previous selection after selecting a new state #44957
• [HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid #44959
• [HOLD for payment 2024-07-17][$250] Expense - App crashes when opening an expense report after submitting another expense #44960
• IOU - Title change is not reflected in header and details section #44962
• IOU - Details modal is dismissed after editing title #44963
• [$250] Thread – Unable to leave thread in a task detail. #44964
• Workspace - The price $9 in upgrade page is not legible in light mode #44965
• [$250] Pay someone - Unapprove option is available for "Pay someone" expense, which gives error #44966
• [$250] IOU - Multiple IOUs are unapproved when a single IOU is unapproved #44969
• [HOLD for payment 2024-07-25] Android - Workspace upgrade - Offline indicator is below the content #44971
• Report fields - The report field after deleted offline is still clickable #44974
• [$250] Expense - Missing spacing between currency and amount in unapprove system message #44975
• Expensify card - "It's not here" + console errors after enabling Expensify card #44977
• Report fields - Blank list is shown briefly after deleting all report fields #44983
• Expense - "Unapprove" option is available in report with deleted expense that has comments #44991
• [$250 BLOCKED BY #44388] Send invoice - Invoice report appears broken #44992
• [Search v1] - Action field remains as "Paid" after expenses are unapproved until page is revisited #45001
• [HOLD for payment 2024-07-24] Expense - "Unapprove" option exists on Manually reimbursed reports, on Collect policy with Instant Submit, Submit & Close #45009
• NetSuite - Infinite loading shows when trying to connect #45010
• [HOLD for payment 2024-07-24] Search - Grouped expenses show User submits to User instead of to Workspace #45013
• [PAID] [$250] QBO - Tags - Error message is missing left and right margins and cannot be dismissed #45056
• [$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state #45060
• Track - App shows old receipt when submitting expense with receipt and changing receipt #45062
• [Details revamp] No option to cancel payment for paid expense as 3-dot menu is removed #45077
• [$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses #45078
• [HOLD for payment 2024-08-01] [$250] Expense report - System message "randomly selected for review" displayed with markdown #45141

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mountiny]

Not sure why this is listed #43036 as the PR was reverted in the last release

[mountiny]

checked off #44801 and #44818 as they were old deploy blockers

[Julesssss]

Not sure why this is listed #43036 as the PR was reverted in the last release

Yeah odd.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.5-0 🚀

[Julesssss]

Wow, big delay on that message 😕 We're up to 9.0.5-3 already

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

#44959 resolved with #44973

[Julesssss]

Checking off #44975 as not-a-blocker

[kbecciv]

TR is 45% left!

#44947 is pending verification on Desktop and IOS
#43036 - left comment #43036 (comment)
#43153 is failing with #42552 on IOS app, left comment #43153 (comment)
#43822 is failing with #44965
#44221 is pending verification on Desktop and IOS app
#44229 is pending verification on IOS app
#44391 is pending verification on IOS app
#44529 is pending verification on Desktop and IOS
#44711 is failing with #44197, left comment #44711 (comment)
#44734 is pending verification on IOS app
#44743 is pending verification on Desktop and IOS
#44808 is pending verification on IOS
#44819 is pending verification on IOS
#44893 is failing with #44977, checking off per comment #44977 (comment)
#44902 is pending verification on IOS app
#44944 asked #44944 (comment)
CP #44981 is pending verification

Deploy Blockers:
#44957
#44960
#44962
#44963
#44966
#44969
#44991
#44992
#45001

[blimpich]

Demoting #44991

[mountiny]

demoted #45010

[mountiny]

@thienlnam demoted #45009

[Beamanator]

#45049 CP'd which confirmed fixed blockers #44969 and #44966, checking those 3 off

[Julesssss]

#44988 fixes #44963

[Julesssss]

#44962 resolved by a different fix, checking off

[rlinoz]

checking off #45062, can't repro in latest version

[kbecciv]

TR is completed!

#41962 is failing with #45004
#43036 left comment #43036 (comment)
#43153 is failing with #42552 on IOS app, left comment #43153 (comment)
#43822 is failing with #44965
#44221 is failing with #43851, left comment #44221 (comment)
#44612 - left comment #44612 (comment)
#44711 is failing with #44197, left comment #44711 (comment)
#44893 is failing with #44977, checking off per comment #44977 (comment)
#44944 asked #44944 (comment)

Deploy Blockers:
#44960
#44992
#45013
#45060

[rlinoz]

Unchecking #45062 because we have new reproduction steps #45062 (comment)

[Julesssss]

Hey @kbecciv, could you please retest #45056? It should be resolved in version 9.0.5-8

[kbecciv]

@Julesssss Checking #45056

[Julesssss]

I am demoting #44992 due to reasons discussed here

[Julesssss]

#45081 Cp'd to resolve #45062

[kbecciv]

@Julesssss Issue isn't reproducible, left comment #45056 (comment)

[Julesssss]

Checking off #41962 as the failure isn't a blocker

[Julesssss]

• Checked off Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036
• Checked off fix: not found page when select draft policy #43153
• Checking off Add workspace upgrade flow #43822 as it was fixed here

[Julesssss]

Checking off #44612

[Julesssss]

• Checking off fix: dismiss violation action in review duplication feat #44711 as the raised issue isn't a blocker
• Checking off Correctly return early for CHANGEFIELD #44944 as the linked issue was never a blocker

[Julesssss]

#45078 is not a blocker

Four blockers remaining. I have bumped each assignee in Slack

[rlinoz]

Checking off ##44960, tested and it is fixed by #45084

[luacmartins]

Checked off #45013. Demoted to NAB.

[Julesssss]

Checking off the final two blockers:

• [HOLD for payment 2024-08-01] [$250] Expense report - System message "randomly selected for review" displayed with markdown #45141
• [Details revamp] No option to cancel payment for paid expense as 3-dot menu is removed #45077

[Julesssss]

• App timing nominal
• Github status clear
• Firebase:
  • Development crash that is not occurring for real users, and has previously occured
  • MapView access token, only occurring for new contributors
  • New iOS crash with no logs...

[Julesssss]

^ the above iOS crash has occured for many previous versions (I had filtered for the current version only). Shipping

[Julesssss]