-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250 BLOCKED BY #44388] Send invoice - Invoice report appears broken #44992
Comments
Triggered auto assignment to @carlosmiceli ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Looking into it now. |
I think this is the culprit: #44529 |
Mmmm maybe not. |
Can't figure out yet which PR may be the culprit, but can confirm that it's a FE issue, so I'll add the External label for now to see if we get proposals. |
Job added to Upwork: https://www.upwork.com/jobs/~011040101d9617db1c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
This one could also be related: #43036 |
@carlosmiceli This PR was reverted several days ago: #44891 |
@lanitochka17 is the expected result correct? Shouldn't it read: The invoice report will be appear broken
+ The invoice report will not appear broken |
ProposalPlease re-state the problem that we are trying to solve in this issue.After sending an invoice on staging.new.expensify.com, the invoice report appears broken when viewed in the invoice chat's preview. What is the root cause of that problem?The API post request to https://dev.new.expensify.com:8083/api/OpenReport? returns two report action items for a single invoice request. This then gets into the /src/libs/ReportActionsUtils.ts function getCombinedReportActions where the condition gets invoked,
and returns a json such as in my case:
What changes do you think we should make in order to solve the problem?We can either remove the duplicate entries at index 2 and 3 in the above Json at the backend or apply some filter like checking for duplicate IOUTransactionIDs (this will, however, break other thread types) Please see the screen-recording for a better understanding of what I mean: https://drive.google.com/file/d/1YHXqASNkDGyHHcbMd6BtTTAy0DWcz2hr/view?usp=sharing |
📣 @wasxxm! 📣
|
Contributor details Your Expensify account email: wasxxm@gmail.com |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@lakchote Sorry for the confusion |
@carlosmiceli, @akinwale, @Julesssss Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Please see my fix at #44388 (comment) for the other related issue which also fixes this one. |
It's being worked on. |
Continues to be worked on here: #44388 |
You're weird Melvin. |
@carlosmiceli , this issue might have the same root cause as this one We can put a hold on and test it when the other is closed. |
Yeah, there's a few issues in parallel about this, sounds good! |
This issue has not been updated in over 15 days. @carlosmiceli, @akinwale eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
PR is merged |
Issue not reproducible during KI retests. (First week) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5-4
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The invoice report will not appear broken
Actual Result:
The invoice report appears broken
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6536110_1720458016359.20240709_005813.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwaleThe text was updated successfully, but these errors were encountered: