-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove query strings from static resources #3286
Comments
+1 It is also difficult to generate appropriate urls for application cache manifest. You cannot simply take file names for the urls to make the cache work properly. You also have to consider the current version with the query string for the urls inside the manifest. Which is not as simple as taking the filenames. |
+1 |
3 similar comments
+1 |
+1 |
+1 |
@delight are you ok now? |
@delight have you also read why I referred this issue from #663? Could you please read the following comment: #663 (comment)? |
I don't get it - what's your point ? |
+1 Because versioning is using query strings it is impossible to get fontawesome files to get added to HTML5 application cache and ugly workaround is needed http://stackoverflow.com/questions/24055244/webfont-font-awesome-not-working-corrently-offline I think the version should be in the file names itself which is the recommended way to do versioning http://www.stevesouders.com/blog/2008/08/23/revving-filenames-dont-use-querystring/ |
+1 |
1 similar comment
+1 |
+1 from me as well |
+1 |
+1 |
Added to 5.0.0 milestone |
As a way to bypass this for Offline Cache you can added a custom style directly after loading the font awesome css library with them removed. <link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css">
<style>
/*Temporary Fix for Font Awesome ApplicatonManifest offline Cache */
@font-face {
font-family: 'FontAwesome';
src: url('../fonts/fontawesome-webfont.eot');
src: url('../fonts/fontawesome-webfont.eot') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff2') format('woff2'), url('../fonts/fontawesome-webfont.woff') format('woff'), url('../fonts/fontawesome-webfont.ttf') format('truetype'), url('../fonts/fontawesome-webfont.svg') format('svg');
font-weight: normal;
font-style: normal;
}
</style> |
+1 |
1 similar comment
+1 |
+1! |
A work around has been posted. As well, if you place the fonts on the server (or in your CDN) you don't have to use the query string at all. You only need the query string when accessing the fonts from fontawesome's servers. No fix is needed on their end. This is an end user comprehension issue. |
@chris-purcell the query string is included here so we're all using it by default. The query string confuses caches and breaks browser extensions by default. Of course, we can overwrite |
@chris-purcell Wow, in my case you are correct. It seems I had googled for the problem I was having and ended up on a bug report on the wrong repo. My issue was actually with the addition of version strings to font-awesome in a popular Rails gem. Which it seems, was actually an issue that was fixed 27 days ago: |
@gerrywastaken this is exactly what we're all doing now. It'd be great to have it fixed upstream. |
+1 |
1 similar comment
+1 |
Based on the reference from @rmm5t . FontAwesome needs to take this bugfix along, thus somebody needs to merge this change and it will be fix finally in CDN from Bootstrap. |
See also: w3c/preload#68 |
+1 |
Done! |
commit ? |
src: url('../fonts/fontawesome-webfont.eot?v=4.6.3'); |
Resources with a "?" in the URL are not cached by some proxy caching servers. Remove the query string and encode the parameters into the URL
turn
http://iplocator.herokuapp.com/fonts/fontawesome-webfont.woff?v=4.0.3
into
http://iplocator.herokuapp.com/fonts/fontawesome-webfont-4.0.3.woff
The text was updated successfully, but these errors were encountered: