Add native ESM test running via Snowpack to app-template-react #1197

FredKSchott · 2020-10-03T06:21:06Z

Depended on #1196, #1195 #1203 and #1193. (all merged)
Resolves #1036

Changes

300 dependencies removed! (down from 954 -> 662)!
No more jest means no more second, jest-specific build pipeline!
Replaced with @web/test-runner, which uses Snowpack's internal build pipeline.
Testing through Snowpack = now possible for a larger Snowpack CDN integration

What is in this PR?

A new Snowpack plugin for @web/test-runner
Moving app-template-react from jest -> @web/test-runner
Added a server.shutdown() method to the Snowpack JS API

Testing

Added template tests to our current test suite.

Docs

TODO

vercel · 2020-10-03T06:21:12Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/ch9o4c1r9
✅ Preview: https://snowpack-git-wip-web-test-runner.pikapkg.vercel.app

…es (#1198) * add homepage and repository for published package.json files * add homepage to babel-plugin-package-import * add repository.directory setting Co-authored-by: Patrick Miller <>

- @snowpack/app-scripts-lit-element@1.8.6 - @snowpack/app-scripts-preact@1.9.2 - @snowpack/app-scripts-react@1.12.1 - @snowpack/app-scripts-svelte@1.8.6 - @snowpack/app-scripts-vue@1.8.7 - @snowpack/app-template-11ty@1.8.2 - @snowpack/app-template-blank-typescript@1.9.2 - @snowpack/app-template-blank@1.6.14 - @snowpack/app-template-lit-element-typescript@1.10.1 - @snowpack/app-template-lit-element@1.9.1 - @snowpack/app-template-preact@1.10.1 - @snowpack/app-template-react-typescript@1.12.1 - @snowpack/app-template-react@1.10.1 - @snowpack/app-template-svelte-typescript@1.10.1 - @snowpack/app-template-svelte@1.9.1 - @snowpack/app-template-vue-typescript@1.10.1 - @snowpack/app-template-vue@1.10.1 - create-snowpack-app@1.8.3 - esinstall@0.3.1 - @snowpack/babel-plugin-package-import@1.1.4 - @snowpack/plugin-babel@2.1.2 - @snowpack/plugin-build-script@2.0.8 - @snowpack/plugin-dotenv@2.0.3 - @snowpack/plugin-optimize@0.2.3 - @snowpack/plugin-parcel@2.0.5 - @snowpack/plugin-postcss@1.0.5 - @snowpack/plugin-react-refresh@2.3.1 - @snowpack/plugin-run-script@2.1.4 - @snowpack/plugin-svelte@2.1.1 - @snowpack/plugin-vue@2.2.2 - @snowpack/plugin-webpack@2.0.14 - snowpack@2.13.2

Co-authored-by: Marko Heikkilä <marko.heikkila@nortal.com>

* chore: update tailwind import path Otherwise Tailwinds purging and plugins are not working. * Revert "chore: update tailwind import path" This reverts commit e4ae781. * chore: update using tailwind with postcss docs * Update 08-guides.md Co-authored-by: Fred K. Schott <fkschott@gmail.com>

* add strict tsconfig lint step * add sep lint workflow * add sep lint workflow * add sep lint workflow * add sep lint workflow * Update lint.yml

* add typescript plugin, add tests * update docs and templates * Update plugin.js

…it found (#1233) * writing the first docs test and fixing the errors it found * Creating a GitHub Action * Update docs.yml * fixes to the test runner and actions * removing jest from docs

Co-authored-by: Brian Jacobs <brian.jacobs@natgeo.com>

Webpack's magic comments must be extracted from dynamic imports before the spec is passed to `matchDynamicImportValue`. If a match is found for these types of comments, they are appended to the rewritten import.

* add plugin-sass with new onChange/markChanged interface * add tests * update docs * update yarn lockfile * update ts * update snapshots * add back missing snapshot tests * update add true .sass support

* adding svelte-hmr * make svelte-hmr a normal dep of the plugin, & lazy load svelte-hmr * plugin svelte: document HMR options * add bubbled esm-hmr property * svelte plugin: upgrade svelte-hmr, & enable CSS only updates * Update plugin.js Co-authored-by: Fred K. Schott <fkschott@gmail.com>

…#1255) * fix: do not assume a build script failed completely if there's stderr output * refactor: address pr review comments

* Update 04-features.md * Update 04-features.md Co-authored-by: Fred K. Schott <fkschott@gmail.com>

* fix bad async sass test * fix async sass tests * fix docs test too

FredKSchott · 2020-10-09T04:39:40Z

All dependency PRs merged, closing in favor of a fresh PR: #1197

FredKSchott and others added 2 commits October 2, 2020 22:45

add chai to default esinstall namedExports list

86f1c16

[ci] yarn format

e562120

FredKSchott requested a review from a team as a code owner October 3, 2020 06:21

FredKSchott force-pushed the wip-web-test-runner-base branch from ba6c6af to 5d614e9 Compare October 3, 2020 06:32

FredKSchott force-pushed the wip-web-test-runner branch from 4b4e73f to 2fc9abf Compare October 3, 2020 06:32

vercel bot deployed to Preview October 3, 2020 06:33 View deployment

bump version on docs site

941b27a

FredKSchott mentioned this pull request Oct 4, 2020

support dev streaming logs #1203

Merged

FredKSchott and others added 21 commits October 3, 2020 20:31

make esm-hmr import error reporter more strict

339a47f

Add homepage and repository properties for published package.json fil…

0f50082

…es (#1198) * add homepage and repository for published package.json files * add homepage to babel-plugin-package-import * add repository.directory setting Co-authored-by: Patrick Miller <>

fix missing node_modules directory issue

09ec6b5

filter a default export from cjs named exports

1df4e16

Add GermanTech Jobs as Snowpack user (#1206)

2b1aad2

found some broken links and fixing them (#1192)

dc8cf16

always build before publish

729f648

Update README.md

a7fa6ef

remove bad link

c15db29

Update 01-introduction.md

2c68260

[plugin-webpack] Use default name behavior. (#1215)

d4b21d3

Co-authored-by: Marko Heikkilä <marko.heikkila@nortal.com>

update docs

62908d9

test(babel-plugin): add input option test (#1199)

0388e51

simplify svelte plugin (#1221)

f515365

move known okay warnings to debug log (#1193)

710262d

add strict tsconfig lint step (#1224)

63f2c1a

* add strict tsconfig lint step * add sep lint workflow * add sep lint workflow * add sep lint workflow * add sep lint workflow * Update lint.yml

esinstall: handle cjs auto-named-exports with deep reexports (#1194)

d03cb5c

add missing cli flag support for experimental ssr

2b3670f

Add typescript plugin (#1211)

d86e495

* add typescript plugin, add tests * update docs and templates * Update plugin.js

g-plane and others added 3 commits October 6, 2020 20:46

docs: add logo (#1235)

b21848b

Writing the first docs test and fixing the broken anchor link errors …

75ad503

…it found (#1233) * writing the first docs test and fixing the errors it found * Creating a GitHub Action * Update docs.yml * fixes to the test runner and actions * removing jest from docs

add option to show hmr error overlay, update docs (#1239)

5da777b

Co-authored-by: Brian Jacobs <brian.jacobs@natgeo.com>

drwpow mentioned this pull request Oct 7, 2020

Add app-template-preact-typescript #1238

Merged

drwpow and others added 17 commits October 7, 2020 14:19

Fix Svelte plugin SSR bug; add test (#1241)

1faf063

add testFiles support (#1196)

f269fa6

Recovers webpack magic comments and adds to import (#1243)

55fb2f7

Webpack's magic comments must be extracted from dynamic imports before the spec is passed to `matchDynamicImportValue`. If a match is found for these types of comments, they are appended to the rewritten import.

[ci] yarn format

d235ddb

add plugin-sass with new onChange/markChanged interface (#1225)

68e8d77

* add plugin-sass with new onChange/markChanged interface * add tests * update docs * update yarn lockfile * update ts * update snapshots * add back missing snapshot tests * update add true .sass support

add bubbled esm-hmr property (#1232)

2c3e152

[ci] yarn format

c67d947

[ci] yarn format

9ca5c38

fix favicon 404 ignore error

899dd10

fix: do not assume a build script failed completely if there's stderr (…

1ef62f0

…#1255) * fix: do not assume a build script failed completely if there's stderr output * refactor: address pr review comments

Update 04-features.md (#1251)

e9bb589

* Update 04-features.md * Update 04-features.md Co-authored-by: Fred K. Schott <fkschott@gmail.com>

docs to www (#1249)

1fc6b5d

improve docs layout, cleanup (#1250)

cab5ca2

[ci] yarn format

8fa95d0

Fix bad async sass test on Windows (#1257)

07faf89

* fix bad async sass test * fix async sass tests * fix docs test too

adding nofollow attribute to links (#1240)

3e75be3

FredKSchott force-pushed the wip-web-test-runner branch from 2fc9abf to 4270bd9 Compare October 9, 2020 03:45

vercel bot deployed to Preview October 9, 2020 03:45 View deployment

FredKSchott changed the title ~~[WIP] Add native ESM test running via Snowpack~~ Add native ESM test running via Snowpack to app-template-react Oct 9, 2020

add first @web/test-runner plugin, template implementation

9573476

FredKSchott force-pushed the wip-web-test-runner branch from 4270bd9 to 9573476 Compare October 9, 2020 04:37

vercel bot deployed to Preview October 9, 2020 04:37 View deployment

FredKSchott closed this Oct 9, 2020

FredKSchott mentioned this pull request Oct 11, 2020

feat: check if preact is being used in tsx #1275

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add native ESM test running via Snowpack to app-template-react #1197

Add native ESM test running via Snowpack to app-template-react #1197

FredKSchott commented Oct 3, 2020 •

edited

Loading

vercel bot commented Oct 3, 2020 •

edited

Loading

FredKSchott commented Oct 9, 2020

Add native ESM test running via Snowpack to app-template-react #1197

Add native ESM test running via Snowpack to app-template-react #1197

Conversation

FredKSchott commented Oct 3, 2020 • edited Loading

Changes

What is in this PR?

Testing

Docs

vercel bot commented Oct 3, 2020 • edited Loading

FredKSchott commented Oct 9, 2020

FredKSchott commented Oct 3, 2020 •

edited

Loading

vercel bot commented Oct 3, 2020 •

edited

Loading