Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide community, playlist and featured channels settings #3484

Merged

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented May 3, 2023

Add hide community, playlist and featured channels settings

Pull Request Type

  • Feature Implementation

Related issue

closes #3202

Description

Adds settings to:

  • hide community posts
  • hide featured channels (the channel list under the about section)
  • hide channel playlists (the playlist tab on channels)

Screenshots

With settings enabled:
image

image

Without new settings enabled:
image

image

Testing

hide featured channels

  • go to mr beast's about page
  • see channels
  • go to settings
  • enable hide featured channels
  • go to mr beast's about page
  • dont see channels

hide playlists

  • go to mr beast's page
  • see playlist tab
  • go to settings
  • enable hide channel playlists
  • go to mr beast's channel
  • don't see playlist tab

hide community

  • go to mr beast's page
  • see community tab
  • go to settings
  • enable hide channel community
  • go to mr beast's channel
  • don't see community tab

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 18

@ChunkyProgrammer ChunkyProgrammer changed the title Add hide community, playlist and featured channels setting Add hide community, playlist and featured channels settings May 3, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 3, 2023 05:12
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 3, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and code looks good. At some point we should probably add some headings to the distraction free settings, as they are getting quite busy, e.g. "Sidebar" (+ a good name for the mobile bottom bar), "Watch page", "Channel pages", "Miscellaneous" (for settings that apply in multiple places like hiding video views or the share menu)

@FreeTubeBot FreeTubeBot merged commit 1b45f25 into FreeTubeApp:development May 6, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 6, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the hide-channel-tabs branch May 6, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hide featured channels section on about channel tab
5 participants