Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distraction free setting to hide channel shorts #3569

Merged
merged 2 commits into from
May 23, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented May 20, 2023

Add distraction free setting to hide channel shorts

Pull Request Type

  • Feature Implementation

Related issue

closes #3555

Description

Introduces a setting to hide the shorts tab on the channel page, similar to #3484.

Testing

Check that the tab is hidden for both the local API and for Invidious
https://youtube.com/@LinusTechTips

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: ccbf7e2

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 20, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 20, 2023 13:57
PikachuEXE
PikachuEXE previously approved these changes May 21, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc

@absidue

Bug: Wanted to check if i could navigate to https://www.youtube.com/@LinusTechTips/shorts when settings is enabled but this resulted in searching it instead of going to the channel page.

If u hide playlists/live/community and navigate to https://www.youtube.com/@LinusTechTips/playlists it will default to the videos tab of the channel

Should i open a report or u want to fix it here?

@ChunkyProgrammer
Copy link
Member

@absidue

Bug: Wanted to check if i could navigate to https://www.youtube.com/@LinusTechTips/shorts when settings is enabled but this resulted in searching it instead of going to the channel page.

If u hide playlists/live/community and navigate to https://www.youtube.com/@LinusTechTips/playlists it will default to the videos tab of the channel

Should i open a report or u want to fix it here?

That's because shorts wasnt added here

/^\/(?:(?:channel|user|c)\/)?(?<channelId>[^/]+)(?:\/(?<tab>join|featured|videos|live|streams|playlists|about|community|channels))?\/?$/

@absidue absidue dismissed stale reviews from PikachuEXE and ChunkyProgrammer via a7b0ae2 May 22, 2023 19:51
@absidue absidue force-pushed the hide-channel-shorts branch from a7b0ae2 to 3c2b3c9 Compare May 22, 2023 19:54
@absidue
Copy link
Member Author

absidue commented May 22, 2023

@efb4f5ff-1298-471a-8973-3d47447115dc added support for it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit c53f5b6 into FreeTubeApp:development May 23, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 23, 2023
@absidue absidue deleted the hide-channel-shorts branch May 23, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hide shorts from channel page
5 participants