-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: refine the transaction example in the README #2072
Conversation
Thanks for the contribution! Interesting. I actually get a different error:
However, your change still makes it valid :) |
Yes. You're correct. That's the first error message I met. I changed it to the |
Nice! I've also tried this now. The updated transaction seems to be valid, but trying to add it to the chain results in the error @mmyyrroonn while you're at it, can you add a line to the |
It's a good suggestion. I added one sentence to demonstrate the |
Related: #1669 |
Should I add a change log for this PR? 😄 |
I don't think this needs a change log (@MitchTurner please correct me if I'm mistaken), so you can add the |
That's cool. However, it seems that I cannot modify the label of this PR. |
Makes sense, thanks for highlighting. I've added the label for you now instead. |
## Version v0.34.0 ### Added - [2051](#2051): Add support for AWS KMS signing for the PoA consensus module. The new key can be specified with `--consensus-aws-kms AWS_KEY_ARN`. - [2092](#2092): Allow iterating by keys in rocksdb, and other storages. - [2096](#2096): GraphQL endpoint to fetch blob byte code by its blob ID. ### Changed - [2106](#2106): Remove deadline clock in POA and replace with tokio time functions. #### Breaking - [2051](#2051): Misdocumented `CONSENSUS_KEY` environ variable has been removed, use `CONSENSUS_KEY_SECRET` instead. Also raises MSRV to `1.79.0`. ### Fixed - [2106](#2106): Handle the case when nodes with overriding start on the fresh network. - [2105](#2105): Fixed the rollback functionality to work with empty gas price database. ## What's Changed * doc: refine the transaction example in the README by @mmyyrroonn in #2072 * AWS KMS block signing support and Rust 1.79 by @Dentosal in #2051 * feat(iterators): allow key-only iteration by @rymnc in #2092 * feat: graphql endpoint to fetch the blob byte code by its blob ID by @netrome in #2096 * Small improvements for tests to make them more stable by @xgreenx in #2103 * Fixed the rollback functionality to work with empty gas price database by @xgreenx in #2105 * Bump wasmtime version by @Dentosal in #2089 * Handle the case when nodes with overriding start on the fresh network by @xgreenx in #2106 * Remove deadline clock in POA and replace with tokio time functions. by @AurelienFT in #2109 ## New Contributors * @mmyyrroonn made their first contribution in #2072 **Full Changelog**: v0.33.0...v0.34.0
I tried the command in the readme and met the following errors during my work
I replaced it with the
tx
from the test file below by using the functionto_json()
fuel-core/tests/tests/tx.rs
Lines 155 to 172 in a9e5e89